public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Add missing OBJCOPY variable to Makefile.in
@ 2016-07-03 11:56 JonY
  2016-07-13 22:22 ` Jeff Law
  0 siblings, 1 reply; 4+ messages in thread
From: JonY @ 2016-07-03 11:56 UTC (permalink / raw)
  To: Gcc Patch List; +Cc: Corinna Vinschen


[-- Attachment #1.1: Type: text/plain, Size: 96 bytes --]

This patch allows OBJCOPY to be set by configure. It was missing in
Makefile.in.

Patch OK?

[-- Attachment #1.2: 0001-Add-missing-OBJCOPY-variable-to-Makefile.in.patch --]
[-- Type: text/plain, Size: 601 bytes --]

From c7b2b18116cd0ba73ff585299b5190a05e267d3f Mon Sep 17 00:00:00 2001
From: Corinna Vinschen <corinna@vinschen.de>
Date: Sat, 26 Mar 2016 12:32:18 +0100
Subject: [PATCH] Add missing OBJCOPY variable to Makefile.in

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
---
 Makefile.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.in b/Makefile.in
index 117fbf5..737e602 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -400,6 +400,7 @@ DLLTOOL = @DLLTOOL@
 LD = @LD@
 LIPO = @LIPO@
 NM = @NM@
+OBJCOPY = @OBJCOPY@
 OBJDUMP = @OBJDUMP@
 RANLIB = @RANLIB@
 READELF = @READELF@
-- 
2.8.3


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add missing OBJCOPY variable to Makefile.in
  2016-07-03 11:56 [PATCH] Add missing OBJCOPY variable to Makefile.in JonY
@ 2016-07-13 22:22 ` Jeff Law
  2016-07-13 23:30   ` JonY
  2016-07-14 22:26   ` JonY
  0 siblings, 2 replies; 4+ messages in thread
From: Jeff Law @ 2016-07-13 22:22 UTC (permalink / raw)
  To: JonY, Gcc Patch List; +Cc: Corinna Vinschen

On 07/03/2016 05:56 AM, JonY wrote:
> This patch allows OBJCOPY to be set by configure. It was missing in
> Makefile.in.
>
> Patch OK?
With a ChangeLog and verification that some host/target combination 
still builds this is OK.

jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add missing OBJCOPY variable to Makefile.in
  2016-07-13 22:22 ` Jeff Law
@ 2016-07-13 23:30   ` JonY
  2016-07-14 22:26   ` JonY
  1 sibling, 0 replies; 4+ messages in thread
From: JonY @ 2016-07-13 23:30 UTC (permalink / raw)
  To: Jeff Law, Gcc Patch List; +Cc: Corinna Vinschen

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On 7/14/2016 06:22, Jeff Law wrote:
> On 07/03/2016 05:56 AM, JonY wrote:
>> This patch allows OBJCOPY to be set by configure. It was missing in
>> Makefile.in.
>>
>> Patch OK?
> With a ChangeLog and verification that some host/target combination
> still builds this is OK.
> 
> jeff
> 
> 


Hi Jeff,

I just realized a similar change is required in Makefile.tpl, how do you
regenerate Makefile.in?



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add missing OBJCOPY variable to Makefile.in
  2016-07-13 22:22 ` Jeff Law
  2016-07-13 23:30   ` JonY
@ 2016-07-14 22:26   ` JonY
  1 sibling, 0 replies; 4+ messages in thread
From: JonY @ 2016-07-14 22:26 UTC (permalink / raw)
  To: Jeff Law, Gcc Patch List; +Cc: Corinna Vinschen

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On 7/14/2016 06:22, Jeff Law wrote:
> On 07/03/2016 05:56 AM, JonY wrote:
>> This patch allows OBJCOPY to be set by configure. It was missing in
>> Makefile.in.
>>
>> Patch OK?
> With a ChangeLog and verification that some host/target combination
> still builds this is OK.
> 
> jeff
> 
> 

Modified the patch slightly to include Makefile.tpl.
Tested with Cygwin and cross to mingw-w64.

ChangeLog:
2016-03-26  Corinna Vinschen  <corinna@vinschen.de>

* Makefile.tpl: Add missing OBJCOPY variable.
* Makefile.in: Regenerate.

diff --git a/Makefile.in b/Makefile.in
index 117fbf5..737e602 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -400,6 +400,7 @@ DLLTOOL = @DLLTOOL@
 LD = @LD@
 LIPO = @LIPO@
 NM = @NM@
+OBJCOPY = @OBJCOPY@
 OBJDUMP = @OBJDUMP@
 RANLIB = @RANLIB@
 READELF = @READELF@
diff --git a/Makefile.tpl b/Makefile.tpl
index 94a4f79..597107c 100644
--- a/Makefile.tpl
+++ b/Makefile.tpl
@@ -403,6 +403,7 @@ DLLTOOL = @DLLTOOL@
 LD = @LD@
 LIPO = @LIPO@
 NM = @NM@
+OBJCOPY = @OBJCOPY@
 OBJDUMP = @OBJDUMP@
 RANLIB = @RANLIB@
 READELF = @READELF@
 Makefile.in  |    1 +
 Makefile.tpl |    1 +
 2 files changed, 2 insertions(+)



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-07-14 22:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 11:56 [PATCH] Add missing OBJCOPY variable to Makefile.in JonY
2016-07-13 22:22 ` Jeff Law
2016-07-13 23:30   ` JonY
2016-07-14 22:26   ` JonY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).