From: Vladimir Makarov <vmakarov@redhat.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: patch to fix PR82353
Date: Mon, 16 Oct 2017 20:39:00 -0000 [thread overview]
Message-ID: <5794f39e-42ef-66da-e7f5-270ebc54cdf2@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
This is another version of the patch to fix
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82353
The patch was successfully bootstrapped on x86-64 with Go and Ada.
Committed as rev. 253796.
[-- Attachment #2: pr82353-2.patch --]
[-- Type: text/x-patch, Size: 2766 bytes --]
Index: ChangeLog
===================================================================
--- ChangeLog (revision 253795)
+++ ChangeLog (working copy)
@@ -1,3 +1,12 @@
+2017-10-16 Vladimir Makarov <vmakarov@redhat.com>
+
+ PR sanitizer/82353
+ * lra.c (collect_non_operand_hard_regs): Don't ignore operator
+ locations.
+ * lra-lives.c (bb_killed_pseudos, bb_gen_pseudos): Move up.
+ (make_hard_regno_born, make_hard_regno_dead): Update
+ bb_killed_pseudos and bb_gen_pseudos for fixed regs.
+
2017-10-16 Jeff Law <law@redhat.com>
* tree-ssa-dse.c (live_bytes_read): Fix thinko.
Index: lra.c
===================================================================
--- lra.c (revision 253685)
+++ lra.c (working copy)
@@ -820,7 +820,8 @@ collect_non_operand_hard_regs (rtx *x, l
const char *fmt = GET_RTX_FORMAT (code);
for (i = 0; i < data->insn_static_data->n_operands; i++)
- if (x == data->operand_loc[i])
+ if (! data->insn_static_data->operand[i].is_operator
+ && x == data->operand_loc[i])
/* It is an operand loc. Stop here. */
return list;
for (i = 0; i < data->insn_static_data->n_dups; i++)
Index: lra-lives.c
===================================================================
--- lra-lives.c (revision 253685)
+++ lra-lives.c (working copy)
@@ -220,6 +220,9 @@ lra_intersected_live_ranges_p (lra_live_
return false;
}
+/* The corresponding bitmaps of BB currently being processed. */
+static bitmap bb_killed_pseudos, bb_gen_pseudos;
+
/* The function processing birth of hard register REGNO. It updates
living hard regs, START_LIVING, and conflict hard regs for living
pseudos. Conflict hard regs for the pic pseudo is not updated if
@@ -243,6 +246,8 @@ make_hard_regno_born (int regno, bool ch
|| i != REGNO (pic_offset_table_rtx))
#endif
SET_HARD_REG_BIT (lra_reg_info[i].conflict_hard_regs, regno);
+ if (fixed_regs[regno])
+ bitmap_set_bit (bb_gen_pseudos, regno);
}
/* Process the death of hard register REGNO. This updates
@@ -255,6 +260,11 @@ make_hard_regno_dead (int regno)
return;
sparseset_set_bit (start_dying, regno);
CLEAR_HARD_REG_BIT (hard_regs_live, regno);
+ if (fixed_regs[regno])
+ {
+ bitmap_clear_bit (bb_gen_pseudos, regno);
+ bitmap_set_bit (bb_killed_pseudos, regno);
+ }
}
/* Mark pseudo REGNO as living at program point POINT, update conflicting
@@ -299,9 +309,6 @@ mark_pseudo_dead (int regno, int point)
}
}
-/* The corresponding bitmaps of BB currently being processed. */
-static bitmap bb_killed_pseudos, bb_gen_pseudos;
-
/* Mark register REGNO (pseudo or hard register) in MODE as live at
program point POINT. Update BB_GEN_PSEUDOS.
Return TRUE if the liveness tracking sets were modified, or FALSE
next reply other threads:[~2017-10-16 20:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 20:39 Vladimir Makarov [this message]
2017-12-13 12:35 ` Tom de Vries
2017-12-14 17:01 ` Vladimir Makarov
2017-12-15 11:26 ` [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs Tom de Vries
2017-12-18 16:57 ` Vladimir Makarov
2018-01-08 16:52 ` Tom de Vries
2018-02-26 9:32 ` Tom de Vries
2018-02-26 11:01 ` Matthew Fortune
2018-02-26 13:46 ` Tom de Vries
2018-02-26 14:17 ` Matthew Fortune
2018-02-28 22:18 ` Matthew Fortune
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 11:38 patch to fix PR82353 Uros Bizjak
2017-10-11 19:51 Vladimir Makarov
2017-10-11 21:17 ` Jakub Jelinek
2017-10-11 22:54 ` Vladimir Makarov
2017-10-12 17:05 ` Jakub Jelinek
2017-10-12 17:11 ` Vladimir Makarov
2017-10-12 17:34 ` Jakub Jelinek
2017-10-13 18:49 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5794f39e-42ef-66da-e7f5-270ebc54cdf2@redhat.com \
--to=vmakarov@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).