From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id C0D8D3857C51 for ; Fri, 18 Nov 2022 19:30:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0D8D3857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x836.google.com with SMTP id l15so3798421qtv.4 for ; Fri, 18 Nov 2022 11:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MiZ5gf+7+KscH3tR0W/hsyvrKc37LFMiHeA+iQE3Mr4=; b=TPtawyrrh36YrTMVItS1xdmw3Sx9jsuMrY+fnvKoLh6Dy32F6lEMfQx9L53LF6EJNq sPN7b3lBPEThEZpQmH5pqlWDw6qZ650+6sxcm7xa9T6RbyjpaJMYeIIs4nqjS2gBbg6S KgNgmYocMeW/I/3e7eUJAtJ418TFdzoq0S4O6+6JDlpxF8VBcvNPCM2m7sB4ACkNDpZR 77DP8wxzytw9rBNEWtOvATh9BsIooypXshaBdp8caC295Q+4BiVayqX5nuSpJKsDAQr1 xEo6yO0xup3OHUGbTnls47w5eawcjduAIXhjkAvr0fWHIOmBWK9b65b0JeM4Kfz3pdHx 1HIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MiZ5gf+7+KscH3tR0W/hsyvrKc37LFMiHeA+iQE3Mr4=; b=zZJmDiAjGuk06eaWfDB9jvV0r1iA+wqNEieFhGLv8f/p3BtSSg8mJbBL/hh04UVouH DDIn0sokuRjuKwIqx/jdZjSy93BqLMJvxwh/6lxjXCfL4c5cA8T+ndJ+8LxrfqBZEg1l uMZoE7G5UExhNRQPLbfrK5QWGMqWpJ38pN9shT2eWC9kMp3MtXUzdF7BZNMG4IlRDTxh Y3jn6Nkt6MsqyUHJq0f6NAt9df74FVUYdLW5Vhn0+veJZopqQPyXmhQV2hWDf3h0vDa1 ZWv8VcOpYwSj6YgY+w4aFDk6NnG4HBtK4FV6HFZpLe12wLiK6jobhN6qIxh0ghH9UAEj qEkA== X-Gm-Message-State: ANoB5pniS+w5oVq1zxaVatkXOL+A6hm7q6W3dh4WJWxLM56K7yPW9Z/R 3PAh0GSYKhfY11mo9Qp/vVs= X-Google-Smtp-Source: AA0mqf5SjntxJda5tQpNBmepSO1RBzymFwOkcgkTp0xB79XdLkzNiqAeekRJxhQKqJcJmxhe8aDEFw== X-Received: by 2002:ac8:72c4:0:b0:39a:83a1:f3aa with SMTP id o4-20020ac872c4000000b0039a83a1f3aamr8117208qtp.386.1668799837354; Fri, 18 Nov 2022 11:30:37 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id cc16-20020a05622a411000b003a606428a59sm2446078qtb.91.2022.11.18.11.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 11:30:36 -0800 (PST) Message-ID: <5799b07e-c4ae-4511-0b23-a24330802455@gmail.com> Date: Fri, 18 Nov 2022 12:30:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Optimize branches testing a bit-range or a shifted immediate Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Palmer Dabbelt , Christoph Muellner , Vineet Gupta , Jeff Law , Kito Cheng References: <20221108204625.2794920-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221108204625.2794920-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_LINKBAIT3,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 13:46, Philipp Tomsich wrote: > gcc/ChangeLog: > > * config/riscv/predicates.md (shifted_const_arith_operand): > (uimm_extra_bit_operand): > * config/riscv/riscv.md (*branch_shiftedarith_equals_zero): > (*branch_shiftedmask_equals_zero): > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/branch-1.c: New test. Nice...    It seems so obvious, but I'm not offhand aware of other ports doing this, though many could likely benefit. OK jeff