[PATCH] disable ifunc on *-musl by default

[PATCH] disable ifunc on *-musl by default

[Szabolcs Nagy]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Musl libc does not support gnu ifunc, so disable it by default.
(not disabled on s390-* since that has no musl support yet.)

gcc/
2016-07-20  Szabolcs Nagy  <szabolcs.nagy@arm.com>

	* config.gcc (*-*-*musl*): Disable gnu-indirect-function.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: noifunc2.diff --]
[-- Type: text/x-patch; name=noifunc2.diff, Size: 832 bytes --]

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 1f75f17..f3f6e14 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -1465,7 +1465,7 @@ i[34567]86-*-linux* | i[34567]86-*-kfreebsd*-gnu | i[34567]86-*-gnu* | i[34567]8
 		extra_options="${extra_options} linux-android.opt"
 		# Assume modern glibc if not targeting Android nor uclibc.
 		case ${target} in
-		*-*-*android*|*-*-*uclibc*)
+		*-*-*android*|*-*-*uclibc*|*-*-*musl*)
 		  ;;
 		*)
 		  default_gnu_indirect_function=yes
@@ -1531,7 +1531,7 @@ x86_64-*-linux* | x86_64-*-kfreebsd*-gnu)
 		extra_options="${extra_options} linux-android.opt"
 		# Assume modern glibc if not targeting Android nor uclibc.
 		case ${target} in
-		*-*-*android*|*-*-*uclibc*)
+		*-*-*android*|*-*-*uclibc*|*-*-*musl*)
 		  ;;
 		*)
 		  default_gnu_indirect_function=yes

Re: [PATCH] disable ifunc on *-musl by default

[Szabolcs Nagy]

On 20/07/16 14:37, Szabolcs Nagy wrote:
> Musl libc does not support gnu ifunc, so disable it by default.
> (not disabled on s390-* since that has no musl support yet.)
> 
> gcc/
> 2016-07-20  Szabolcs Nagy  <szabolcs.nagy@arm.com>
> 
> 	* config.gcc (*-*-*musl*): Disable gnu-indirect-function.
> 

ping

Re: [PATCH] disable ifunc on *-musl by default

[Bernd Schmidt]

On 07/20/2016 03:37 PM, Szabolcs Nagy wrote:
> Musl libc does not support gnu ifunc, so disable it by default.
> (not disabled on s390-* since that has no musl support yet.)
>
> gcc/
> 2016-07-20  Szabolcs Nagy  <szabolcs.nagy@arm.com>
>
> 	* config.gcc (*-*-*musl*): Disable gnu-indirect-function.

Ok I suppose? I'm assuming you know best.


Bernd

Re: [PATCH] disable ifunc on *-musl by default

[Szabolcs Nagy]

On 20/07/16 15:13, David Edelsohn wrote:
> On Wed, Jul 20, 2016 at 7:09 AM, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
>> On 20/07/16 14:45, David Edelsohn wrote:
>>>> Musl libc does not support gnu ifunc, so disable it by default.
>>>> (not disabled on s390-* since that has no musl support yet.)
>>>
>>> Musl libc now supports PPC64. Support for s390 is in progress.
>>>
>>
>> it seemed to me that on ppc64 ifunc is disabled by default.
>> (at least it is not enabled in config.gcc)
> 
> Ifunc is used on PPC64.
> 

only if you build gcc with --enable-gnu-indirect-function

otherwise the ifunc attribute does not work, and target
libs (e.g. libatomic on x86_64) don't use ifunc.

in glibc i think you need --enable-multiarch to use ifunc,
but it handles ifunc in user code independently of that.

i just want to make sure that --enable-gnu-indirect-function
is not the default with *-musl (since musl has no ifunc support).

Re: [PATCH] disable ifunc on *-musl by default

[David Edelsohn]

On Wed, Jul 20, 2016 at 7:09 AM, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
> On 20/07/16 14:45, David Edelsohn wrote:
>>> Musl libc does not support gnu ifunc, so disable it by default.
>>> (not disabled on s390-* since that has no musl support yet.)
>>
>> Musl libc now supports PPC64. Support for s390 is in progress.
>>
>
> it seemed to me that on ppc64 ifunc is disabled by default.
> (at least it is not enabled in config.gcc)

Ifunc is used on PPC64.

- David

Re: [PATCH] disable ifunc on *-musl by default

[Szabolcs Nagy]

On 20/07/16 14:45, David Edelsohn wrote:
>> Musl libc does not support gnu ifunc, so disable it by default.
>> (not disabled on s390-* since that has no musl support yet.)
> 
> Musl libc now supports PPC64. Support for s390 is in progress.
> 

it seemed to me that on ppc64 ifunc is disabled by default.
(at least it is not enabled in config.gcc)

Re: [PATCH] disable ifunc on *-musl by default

[David Edelsohn]

> Musl libc does not support gnu ifunc, so disable it by default.
> (not disabled on s390-* since that has no musl support yet.)

Musl libc now supports PPC64. Support for s390 is in progress.

- David