From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33074 invoked by alias); 25 Aug 2016 08:45:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32988 invoked by uid 89); 25 Aug 2016 08:45:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=BUILD_CC, build_cc, Hx-languages-length:1027 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Aug 2016 08:45:26 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp0178.outbound.protection.outlook.com [213.199.154.178]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-37-aX3xrEfCPHWf9p8Nj4OHjQ-1; Thu, 25 Aug 2016 09:45:23 +0100 Received: from [10.2.206.73] (217.140.96.140) by AM4PR0802MB2146.eurprd08.prod.outlook.com (10.172.217.8) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.13; Thu, 25 Aug 2016 08:45:21 +0000 Message-ID: <57BEB01B.2070105@arm.com> Date: Thu, 25 Aug 2016 08:45:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Joseph Myers CC: , "gcc-patches@gcc.gnu.org" , Jakub Jelinek Subject: Re: [PATCH 1/4][PR 71931] Fix libatomic tests References: <57BDEFC5.4050207@arm.com> <57BDF021.6090207@arm.com> In-Reply-To: X-ClientProxiedBy: DB3PR01CA0077.eurprd01.prod.exchangelabs.com (10.242.133.180) To AM4PR0802MB2146.eurprd08.prod.outlook.com (10.172.217.8) X-MS-Office365-Filtering-Correlation-Id: ad8f8922-09a8-4002-f8af-08d3ccc42624 X-Microsoft-Exchange-Diagnostics: 1;AM4PR0802MB2146;2:cwasYPGQ/A1DyzWqUjUzuqdcIcPz0l5llwBNFPvN8IZnO2XRCNTwEtbRum3KFsheHFA3ve+qJH5Fq1KFI5UVtp3osnq4GUB/9O2+FmMYNYRKG+hsKW5sFY2sYaaq02ZAeiLcO0RMUC9NfU7MbfuGxV4DCeKJorkGN+2D8cbagxXs3HPDbkJDfsTwp92YnK2Y;3:GfGS8zINfGnGG6DPwque0lLHM/mi7EJ4u2+Zdo8li1+nY/Uqo4WUk6mFNHXF0A9hiFRGkXebKsI5F+FUplJput/2gzgl9Vwe9+idmREG6Ld8Qj9i7QDZ4rhRY96/7whf;25:eRB21iDLRuyqKGZEl27w94g8hK5aJ37VJy7JqUJVu3m6tuDwvRXdbEwta83A8ehNMo3NyyuK+21LZ2WcYAHIp88R4nvmzskRx+TT8hq4Rk6JTF3dYzqjn0WppIT+xvhjy5FH2m3TDRldSOB2l3q3ssOabc0iPQqJdDG7AWBEjv5hGyanjvvH3DjhSaFuF64Vpd230JkZj0hOn6ZF8f/yQtlsWkjem8eAxlwCIsWDv0yUsG9AaB0k0wtG2Lla6WdXRgOLHHBkEnHlQhzij5ke8vNP1rj5oym/LHkUDBaI5eU+RO3/6dUR13k+QbACQyGzXQMRkyh8cODU2xYD3DuDxAgDeM1gLMU7xeL6dIIArrkbNxFKo719QbYnjoc/tnjqipQ1bXBQT9aK/jfmMQCY2KKcMiK+z+YOn2EL2pDVJos= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0802MB2146; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0802MB2146;31:IHKrk8tWYmBIAg/eu3aUCgGHWr9/qJkPzkaLdYbC7AoeMOjfxF5A5sacyNoF3ws/fKRpf9ok1L4HJs6soXp/qV38frGyHEhN7xb5e5Ax3CAeR5u6cLHPGGw1Rwofqa8UJzeRHtLBKBAFpSJlAIuZnjRH3Zky7mNAIvIZr0Q12D09iW3L9i5UtSQdwn8JDkwL6vTE3RnXNXJszXENRjUIT/iNu2Nc/N2jaKrQfrWsByc=;20:YUrUXaogEPiyGITK1ISEzGpQMlQm2rqcsNyuwHsCZRd8XKSBG8sMR5gn/xbMQA1WeTXhKGwSPZVuluX4RsF6cr6SyUcpO1xKgtmR8KYk3FcuDT8p7W7y9/fM+Nmia5xkZfek7pNgXiagFNCMFFPhKJKJ2I5kBF1olujNCpbmH0M=;4:06wOtqES1/pPcJLRlQK7I1UMTayqXWCZ1eJVOXFXnaGhRVnKJ/NbVVGp6AMDDLN+yV4Uqyrxm1fTzkF4bX9VBfCVhXwTjGBbRIPBB6LqeKeWBfMIt3mJ7j34OV0eanVK5zdZ4mk9tXfO4HWt0vh1PXFuaG+li9aOtTgUE4JLNMMHHiTd8ErVgvNHLhRTLNFtHsKCKEPvLIkoNlkNzOanPzqcwu/c27fqQEldX5IvSmwMUed3+6f2bJHwGdc7kh7gjM9WmdSwpKUw8qfGOlLoV+EwtIb0u8EbEQppGMfaiqBVV2G+6dzx0Pjgr60NK4dKRbS334HNu6B60FS2YPJAmDPP6jPVOYuW6TDtyy0ZqcT4J69s9OjU8wKeRIlfylKyrzh8KXJLAanvlXbcvn+1pb0OT9C7ZOYR5anwS/tD798= NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:AM4PR0802MB2146;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0802MB2146; X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(24454002)(199003)(189002)(81156014)(36756003)(230700001)(65806001)(66066001)(110136002)(106356001)(65956001)(97736004)(50466002)(77096005)(92566002)(42186005)(23746002)(5660300001)(189998001)(2950100001)(64126003)(68736007)(305945005)(83506001)(105586002)(33656002)(50986999)(7736002)(7846002)(80316001)(65816999)(4326007)(76176999)(81166006)(47776003)(87266999)(54356999)(6116002)(3846002)(4001350100001)(2906002)(86362001)(101416001)(8676002)(59896002)(19580395003)(586003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0802MB2146;H:[10.2.206.73];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0802MB2146;23:oJLIn53oFtHBsuFyU6rxnXbrVwpshxFHQ7s?= =?Windows-1252?Q?/rfIhaQAjWCj0k0halQq9ymZimo7PvXHwaJpw5gmELJeY2DQAgtnCnWC?= =?Windows-1252?Q?0RBvfVXy7yv/uPll0Yeve1HxD4f82/bxkcpNoJzWD3+ux8SDE/73QW1V?= =?Windows-1252?Q?nKQTNQNroOH6g71Ob4ewOE/ziBjC3SD2vt0nPnUF/Qs4xShoflq4Pqh5?= =?Windows-1252?Q?OYultcPS96Vxc2Ahna5hVCtFQ2vtSXcwEp9U8k75DBJ86VZUxwo6nuai?= =?Windows-1252?Q?1RSlDRog2EyCn4Ha+ZotScnlulHiKsz3kCBFfNGJMkNSSPfH46EO+kMI?= =?Windows-1252?Q?4zBcPkjUvXknqx51wutnZVteq5Jd0o9L0sqDxhamYaNUjmnabYA3CcFr?= =?Windows-1252?Q?gBxsrnqPGcB/v0u65ScoVFnXJYCwOQYSp41qRrLWJdk/g8Vn557VUHvU?= =?Windows-1252?Q?BAtpDto0QMVtH80kU+TXmt5biWDxKi7QUNGC1KFGFXadbYFG5qh/pJUk?= =?Windows-1252?Q?m2d55AS2L11uSqJFhKReC15pJrjZ/RYQk9JyFj0byjQ7qOOHUp6LSLpe?= =?Windows-1252?Q?1iAIOUyo/hDU/jhXpb0t2WEYj9FyvMCfuNGwzRWA3Ko5/UmdM5IAwDxe?= =?Windows-1252?Q?GjSgV5Qn4c7vCehXVEPSS7M1WXWPkKWn65vIoVH6+OAY2BfCJYhrPKKs?= =?Windows-1252?Q?SoQwd2rtG/POCKQoPbbVUimdOLn9Y2fD4lgQwB0Maf2SfYhSn8kEPnZI?= =?Windows-1252?Q?JQU6wBfBa+kF9nkEacrogItrI5sCagnst/GSZqkQCC8SVZKXkehlNr/4?= =?Windows-1252?Q?rbOZCc2luyiZD5asFkPcgbxG2MXe3NdWfJw2LGNyQv97Oai8oxHsYLSh?= =?Windows-1252?Q?vNTIbX2WIGEAlozeEiJ6K0cChZcqPmV3HuKl7y62i4TnYDzAH0UTEaiS?= =?Windows-1252?Q?TzNfqdhwNfiyCevm0su22JrmSmDLzwhw5L4kIsQR2pxQ+5UIfb1peMv1?= =?Windows-1252?Q?uzM2sVV4S8EugK497D1BcRFaqAQ88Y0DQejwSF/AO18Y+yJ6YynYxBJB?= =?Windows-1252?Q?dMOVEgbTu/mHPS+J1JGcCiZtXiE40P0k7Lf0QT2czlzMQAUyFdVgjJbQ?= =?Windows-1252?Q?eUFbgQRHSRhpsY7S7inbq9ikHjOT4W1j53c6w8cTPq+4/9rNqIxDz4TU?= =?Windows-1252?Q?Pd7HF4h7sZVHK/MW28pJoiaePUKiC160gp/sYmXdGbulB1CfzJjZpfiR?= =?Windows-1252?Q?4QoxCTSb+sKtd8149dv9TdzL/LS3hZ4I+Ibr4+0oqT91Y6uYJC57ZBHV?= =?Windows-1252?Q?w2aKqjqWpUvz3Kg/aZWz3aBcdjCc9v2qsmkxSriXYSNriQPHrI/3qTkX?= =?Windows-1252?Q?7xp+cmtxCHl0r?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0802MB2146;6:K0jNRAwGInQzVL7fCHG6bnN3Jxvr9iCesJ4/ptVZo+txNJjRdH73/heeKHukscd3zEzyt9j/8d6Je9E5ueo5In3e2QAzUgrKqZRPxrtzH3BWhcwhmUlXJfzERZnSSvWCiDzHCrnGLgKG3fnRLV/yzDQHJHaRktJbXrgAxLis8v9eOjPSrISCQHoveNAAkzf+a8LekJEKiz5OCyyC+tNXDnV/LeJd0ZD+Ikd2ruCARrdhYRg7qgvV07SzgRzmoCaxH9i++4eVzTOd2XS6l8L8/lP/EC0MRQxzEYKVVOHtZHa0t2hmy39iO08Yt0WIiMJGKovC2bZF+4AVX9xlyRCsew==;5:LFzhwf9vC29QtJOCQePLkeAOX1frC4Mo9PV0F+UA2s2R8ZroLG8OIOsV8QJp65Q7ZefuQFtTVnMAjbU71haPlgh5HateK9sNEvdpeu1v17IygRVeQWNMFrIKpnBbjjkAm2A+xC9ITgrIbA94QUFaCw==;24:VGl2jwKlBUkKaD9To4Pur1ZJul6xh+FibwoxIS4jWS0Myx5AP8d7Ro6OCEDM3/gTHjAUt+3BECGygFTgVDhCzTlKEPKG1NMA41kfveTgnTE=;7:ydgJa1ivu1fKzr3QhqL+xvnB7vGTJXPf0ym57Uvi1b6Gb3htZBpYbU8mw4dlnK4G4RTJHrJ8xns2TZx0kTxloOJgTwbuqrw5zR3eM6ABIaIKmpImUKFVPMtf7hhebicavguMqUfbFgQXtUhkOtGFPZBdzwCSS4ZkP1pYA3GSeeB+JkNbAU/czZ9E44IXur+nWKV+CmAs0j+XjyQM0/FKl66NOLue6EnVw0GjwF/mFulV+YstSq+QiWVlZXO+bPA0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR0802MB2146;20:SpexV33iAxLhwqpcB69gaclz6em4vtNidGU0E2htLvUO/+Cv/V91lrpCuzorZctYXA4J1pSyFGYmGZMihnnlJoAluk+45m8vl3RIU+ftCv3BwhLvIcEw3Tp0rSD5sRWr3RyBTOy1UKTVhWD6JMBSqjs25ekNPoLbyFkivDHhsF4= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 08:45:21.2563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2146 X-MC-Unique: aX3xrEfCPHWf9p8Nj4OHjQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg01785.txt.bz2 On 24/08/16 23:08, Joseph Myers wrote: > On Wed, 24 Aug 2016, Szabolcs Nagy wrote: >=20 >> diff --git a/libatomic/testsuite/lib/libatomic.exp b/libatomic/testsuite= /lib/libatomic.exp >> index cafab54..e374c64 100644 >> --- a/libatomic/testsuite/lib/libatomic.exp >> +++ b/libatomic/testsuite/lib/libatomic.exp >> @@ -47,6 +47,8 @@ load_gcc_lib timeout.exp >> load_gcc_lib timeout-dg.exp >> load_gcc_lib fortran-modules.exp >>=20=20 >> +load_file libatomic-test-support.exp >=20 > This approach looks like it would break installed testing. Such=20 > information from the build tree should only be loaded when=20 > TESTING_IN_BUILD_TREE is defined. >=20 i followed the solution in libgomp for passing offloading parameters. it seems TESTING_IN_BUILD_TREE is not set in target lib site.exp so that should be wired up somehow. i'm not sure how installed testing works, if it does not use the build tree site.exp, then i can try to add BUILD_CC to site.exp. (there is an EXTRA_DEJAGNU_SITE_CONFIG hook)