From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92561 invoked by alias); 25 Aug 2016 16:30:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92540 invoked by uid 89); 25 Aug 2016 16:30:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:725 X-HELO: mail-yw0-f179.google.com Received: from mail-yw0-f179.google.com (HELO mail-yw0-f179.google.com) (209.85.161.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Aug 2016 16:30:43 +0000 Received: by mail-yw0-f179.google.com with SMTP id j12so32716603ywb.2 for ; Thu, 25 Aug 2016 09:30:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=KWaHb1OyNu1jrqEcCEAyzoMBKbg8ysFt+po9of3oxLM=; b=GRY+M/R/GJ8h1J65k4F9ED5eqGLtIry+ujxXSLTkAcsfPudk5TMBEqogQWWpP/5C3j LSSJyBwP1mMIs8WufKbhTCYfrXXzIZ0jFZWdC/HSoTomQ05nbxjiAI7FW/7RiMnin+PH L54xSiLS8G7q6ejWePFgJhOJWqpjYJt/wGabEqpKdCP0i96BSTEER9iCGiQg+JuBqiPn vt5sYmv1Tl/7mGhNRjHRB68HkwScibGXm2RhktP7fp+obeg25J/86BeDs5Os0FuMWDML DiQBSzqR61vH6oT5Ki36ShXH0nS7JThYdPR7bxx46aDW27wEiADTHL7izaYAjmmDrh1y mh/w== X-Gm-Message-State: AEkoouuUdCe1ckfMFpLx3q34/+ZDYwks+g658TyA3R7lVRXvC6hdtt2djreZwieDGAbqJg== X-Received: by 10.13.203.18 with SMTP id n18mr7496054ywd.122.1472142642144; Thu, 25 Aug 2016 09:30:42 -0700 (PDT) Received: from [192.168.0.26] (97-122-170-38.hlrn.qwest.net. [97.122.170.38]) by smtp.gmail.com with ESMTPSA id t67sm8345345ywa.33.2016.08.25.09.30.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Aug 2016 09:30:41 -0700 (PDT) Subject: Re: [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch To: David Malcolm References: <1472141352-10884-1-git-send-email-dmalcolm@redhat.com> <1472142198-12113-1-git-send-email-dmalcolm@redhat.com> Cc: gcc-patches@gcc.gnu.org From: Martin Sebor Message-ID: <57BF1D30.5000601@gmail.com> Date: Thu, 25 Aug 2016 16:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1472142198-12113-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg01814.txt.bz2 On 08/25/2016 10:23 AM, David Malcolm wrote: > Martin: here are the fixups for your patch I needed to apply to make > it work with mine. I couldn't actually get any of your existing test > cases to emit locations within the string literals, due to them all > being embedded in macro expansions (possibly relating to PR c/77328), > so I added a simple testcase using -fdiagnostics-show-caret, which > does successfully show a range within the string. > > Posting in the hope that it's helpful; I haven't attempted a bootstrap > with it. Thanks! Let me go through it, test it and get back to you when I'm done (sometime next week after I get back from PTO). Martin