From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94651 invoked by alias); 31 Aug 2016 16:23:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 94641 invoked by uid 89); 31 Aug 2016 16:23:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=relating X-HELO: mail-yb0-f194.google.com Received: from mail-yb0-f194.google.com (HELO mail-yb0-f194.google.com) (209.85.213.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Aug 2016 16:23:35 +0000 Received: by mail-yb0-f194.google.com with SMTP id b33so1175067ybi.2 for ; Wed, 31 Aug 2016 09:23:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jyjrNHWidtemzA3wmhcIB8UdXgVEEDdSmA5jV49wuwc=; b=TUrUB42B7QukOZboXQ2E9F13lESzhBQGiWwZrI7lZlCUw1k0PIxOez0r9fdRUmrI+U bBIh4K5EkOrlkYjP2Z5rTesd/Ps23QezE8iPvqA9OAoFElHbeu9C4/EoxJdFfEzK4feR mLvaBNWR5pAFIe+y2Hh2fJ0Lf+NzKDpo/QZT+PiC/wD59y3jWj2no6aGYNcEnajfTY75 7dxB7NzY2Z5UqkAKRIshYIuzH3FuMQZ+k1d4S9GYnfe9Jbyci6npJEjh+EDJBLXt8rdy 4PLV9SHKtBI/0zBXuF9YhKxDbyzv1LS/LilblwtUfgJ3LaKkvxFH7+mNbHdWhpYKqjAA +eeg== X-Gm-Message-State: AE9vXwPE8ol+/0/IBOntyfT84jE9buZRd6t+GaIZHSbxJQ9hV29wJQONclHubCidh3btOQ== X-Received: by 10.37.56.139 with SMTP id f133mr8800418yba.106.1472660613891; Wed, 31 Aug 2016 09:23:33 -0700 (PDT) Received: from [192.168.0.26] (75-166-199-51.hlrn.qwest.net. [75.166.199.51]) by smtp.gmail.com with ESMTPSA id s126sm220199yws.13.2016.08.31.09.23.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Aug 2016 09:23:33 -0700 (PDT) Subject: Re: [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch To: David Malcolm References: <1472141352-10884-1-git-send-email-dmalcolm@redhat.com> <1472142198-12113-1-git-send-email-dmalcolm@redhat.com> <57BF1D30.5000601@gmail.com> Cc: gcc-patches@gcc.gnu.org From: Martin Sebor Message-ID: <57C70484.40608@gmail.com> Date: Wed, 31 Aug 2016 16:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <57BF1D30.5000601@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg02138.txt.bz2 On 08/25/2016 10:30 AM, Martin Sebor wrote: > On 08/25/2016 10:23 AM, David Malcolm wrote: >> Martin: here are the fixups for your patch I needed to apply to make >> it work with mine. I couldn't actually get any of your existing test >> cases to emit locations within the string literals, due to them all >> being embedded in macro expansions (possibly relating to PR c/77328), >> so I added a simple testcase using -fdiagnostics-show-caret, which >> does successfully show a range within the string. >> >> Posting in the hope that it's helpful; I haven't attempted a bootstrap >> with it. I've tried the patch but the changes don't compile because substring_loc is not declared. I see the class defined in c-family/c-common.h which I can't include here in the middle end. Am I missing some another patch? Thanks Martin