From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59472 invoked by alias); 23 Sep 2016 08:33:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59448 invoked by uid 89); 23 Sep 2016 08:33:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,KAM_LOTSOFHASH,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Sep 2016 08:33:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24AAF14F; Fri, 23 Sep 2016 01:33:25 -0700 (PDT) Received: from [10.2.206.234] (e107157-lin.cambridge.arm.com [10.2.206.234]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12A733F32C; Fri, 23 Sep 2016 01:33:22 -0700 (PDT) Subject: Re: [PATCHv2][ARM] -mpure-code option for ARM To: gcc-patches@gcc.gnu.org, Sandra Loosemore References: <57752D6E.9070006@arm.com> <47c8a674-3af0-afff-776b-9d71c0d1bb46@st.com> <5783CFD1.2070500@arm.com> <57E483AD.3020107@codesourcery.com> From: "Andre Vieira (lists)" Message-ID: <57E4E8D1.7000309@arm.com> Date: Fri, 23 Sep 2016 08:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <57E483AD.3020107@codesourcery.com> Content-Type: multipart/mixed; boundary="------------080300020700070809080209" X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01652.txt.bz2 This is a multi-part message in MIME format. --------------080300020700070809080209 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-length: 2172 On 23/09/16 02:21, Sandra Loosemore wrote: > On 09/22/2016 07:52 AM, Richard Earnshaw (lists) wrote: >> On 11/07/16 17:56, Andre Vieira (lists) wrote: >>> + >>> diff --git a/gcc/target.def b/gcc/target.def >>> index >>> a4df363698ce776b51d11c187baed2069ba88a52..a3d46fa48d919a16699c33b2b78236e62a33e025 >>> 100644 >>> --- a/gcc/target.def >>> +++ b/gcc/target.def >>> @@ -432,6 +432,19 @@ this section is associated.", >>> void, (const char *name, unsigned int flags, tree decl), >>> default_no_named_section) >>> >>> +/* Tell assembler what section attributes to assign this elf section >>> + declaration, using their numerical value. */ >>> +DEFHOOK >>> +(elf_flags_numeric, >>> + "If the target needs to represent ELF section attributes using >>> their\n\ >>> +numerical value, then this hook should be implemented to return true >>> and\n\ >>> +write the numerical value of @var{flags} in @var{num}. This >>> function is\n\ >>> +called by @code{default_elf_asm_named_section}, which prints >>> @var{num}\n\ >>> +as the value representing the ELF section attributes if this >>> function\n\ >>> +returns true.", >> >> >> I think this should read something like. >> >> This hook can be used to encode ELF section flags for which no letter >> code has been defined in the assembler. It is called by >> @code{default_asm_named_section} whenever the section flags need to be >> emitted in the assembler output. If the hook returns true, then the >> numerical value for ELF section flags should be calculated from >> @var{flags} and saved in @var{*num}; the value will be printed out >> instead of the normal sequence of letter codes. If the hook is not >> defined, or if it returns false, then @var{num} will be ignored and the >> traditional letter sequence will be emitted. > > Can we please write this in the present tense instead of the future, > assuming it describes current behavior (as modified by the patch)? > > s/will be/is/g > > -Sandra > Hi Sandra, Is this better? Cheers, Andre gcc/ChangeLog 2016-09-23 Andre Vieira * target.def(elf_flags_numeric): Change documentation to present tense. --------------080300020700070809080209 Content-Type: text/x-patch; name="0001-Language-fix-for-elf_flags_numeric-doc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Language-fix-for-elf_flags_numeric-doc.patch" Content-length: 1401 >From 459abfbbd836aa11e71dd90b9466c60b1155fba0 Mon Sep 17 00:00:00 2001 From: Andre Simoes Dias Vieira Date: Fri, 23 Sep 2016 09:16:17 +0100 Subject: [PATCH] Language fix for elf_flags_numeric doc --- gcc/target.def | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/target.def b/gcc/target.def index ac693318adaaa230ea300f10bc37282881d9da6f..4adb8aabc6548889b717abc9310e98f0e6fc161b 100644 --- a/gcc/target.def +++ b/gcc/target.def @@ -441,10 +441,10 @@ code has been defined in the assembler. It is called by\n\ @code{default_asm_named_section} whenever the section flags need to be\n\ emitted in the assembler output. If the hook returns true, then the\n\ numerical value for ELF section flags should be calculated from\n\ -@var{flags} and saved in @var{*num}; the value will be printed out\n\ -instead of the normal sequence of letter codes. If the hook is not\n\ -defined, or if it returns false, then @var{num} will be ignored and the\n\ -traditional letter sequence will be emitted.", +@var{flags} and saved in @var{*num}; the value is printed out instead of the\n\ +normal sequence of letter codes. If the hook is not defined, or if it\n\ +returns false, then @var{num} is ignored and the traditional letter sequence\n\ +is emitted.", bool, (unsigned int flags, unsigned int *num), hook_uint_uintp_false) -- 1.9.1 --------------080300020700070809080209--