From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Andrew Pinski <pinskia@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: James Greenhalgh <james.greenhalgh@arm.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH/AARCH64] Have the verbose cost model output output be controllable
Date: Fri, 07 Oct 2016 08:01:00 -0000 [thread overview]
Message-ID: <57F75656.2000407@foss.arm.com> (raw)
In-Reply-To: <CA+=Sn1mOJZya_f7YBNujizEowo8ijbBqchVj7DzfsnZEugd2RQ@mail.gmail.com>
Hi Andrew,
On 24/09/16 06:46, Andrew Pinski wrote:
> Hi,
> As reported in PR 61367, the aarch64 back-end is too verbose when it
> is dealing with the cost model. I tend to agree, no other back-end is
> this verbose. So I decided to add an option to enable this verbose
> output if requested.
>
> I did NOT document it in invoke.texi because I don't feel like this is
> an option which an user should use. But I can add it if requested.
>
> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions.
>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
> * config/aarch64/aarch64.opt (mverbose-cost-dump): New option.
> * config/aarch64/aarch64.c (aarch64_rtx_costs): Use
> flag_aarch64_verbose_cost instead of checking for details dump.
> (aarch64_rtx_costs_wrapper): Likewise.
I'm okay with the idea, but I can't approve (cc'ing people who can).
One nit:
+mverbose-cost-dump
+Common Var(flag_aarch64_verbose_cost)
+Enables verbose cost model dummping in the debug dump files.
You should add "Undocumented" to that.
I don't think the option is major enough to warrant an entry in invoke.texi.
It's only for aarch64 backend developers who know exactly what they're looking for.
Cheers,
Kyrill
next prev parent reply other threads:[~2016-10-07 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 8:52 Andrew Pinski
2016-10-06 22:12 ` Andrew Pinski
2016-10-07 8:01 ` Kyrill Tkachov [this message]
2016-11-15 16:48 ` Andrew Pinski
2016-11-15 17:01 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F75656.2000407@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).