From: Xi Ruoyao <xry111@xry111.site>
To: chenglulu <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH v1] LoongArch: Fixed a compilation failure with '%c' in inline assembly [PR107731].
Date: Wed, 23 Nov 2022 17:25:02 +0800 [thread overview]
Message-ID: <57e6c3bdcc07cf891968e1a5857b71cdd459a2a3.camel@xry111.site> (raw)
In-Reply-To: <05feb4b8-6350-7612-535e-ced437e6770d@loongson.cn>
On Wed, 2022-11-23 at 17:14 +0800, chenglulu wrote:
>
> 在 2022/11/23 16:59, Xi Ruoyao 写道:
> > On Wed, 2022-11-23 at 14:49 +0800, Lulu Cheng wrote:
> > > 'A' Print a _DB suffix if the memory model requires a
> > > release.
> > > 'b' Print the address of a memory operand, without offset.
> > > + 'c' print an integer.
> > Nit:
> > 'c' Print an integer.
> >
> > to match the format of other entries.
> >
> > > 'C' Print the integer branch condition for comparison OP.
> > > 'd' Print CONST_INT OP in decimal.
> > > 'F' Print the FPU branch condition for comparison OP.
> > And I'd consider this a new feature and delay it to GCC 14: we never
> > claimed we supported 'c' and it has not worked since the day one we
> > merged LoongArch port. Is there any emergency reason to support 'c'
> > in
> > GCC 13?
> >
> I don't think this is a new feature.
>
> There is a description of '%c' in section 17.5 of gccint.pdf, which I
> understand is a public descriptor,
>
> but right now loongarch doesn't support it.🙁
I'm not sure if gccint is designed for normal users to read, but since
we lack a documentation about those descriptors in GCC user manual, I
guess many users will indeed use gccint as a reference ...
Ok to me. But regarding the test case I suggest to keep those "%a"
tests there (so we won't inadvertently cause a regression in case some
user code already uses it for printing an integer). Unless we
deliberately want to stop people from using "%a" for this purpose.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-11-23 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 6:49 Lulu Cheng
2022-11-23 8:59 ` Xi Ruoyao
2022-11-23 9:14 ` chenglulu
2022-11-23 9:25 ` Xi Ruoyao [this message]
2022-11-23 9:30 ` chenglulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57e6c3bdcc07cf891968e1a5857b71cdd459a2a3.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).