From: Jason Merrill <jason@redhat.com>
To: Alex Coplan <alex.coplan@arm.com>, gcc-patches@gcc.gnu.org
Cc: Nathan Sidwell <nathan@acm.org>
Subject: Re: [PATCH] c++: Avoid duplicate diagnostic calling unavailable function [PR109177]
Date: Wed, 22 Mar 2023 11:10:48 -0400 [thread overview]
Message-ID: <57f3d551-bf5a-6d20-b6dc-7f11a9e6c088@redhat.com> (raw)
In-Reply-To: <ZBrnTg7r6/KAceFW@arm.com>
On 3/22/23 07:32, Alex Coplan wrote:
> Hi,
>
> As the PR shows, we currently emit duplicate diagnostics for calls to
> functions marked with __attribute__((unavailable)). This patch fixes
> that.
>
> I'm not sure whether it's considered acceptable to add the include of
> decl.h to call.cc (in order to get at deprecated_state). It would be
> useful to get some feedback on that.
That's fine.
> Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk?
OK.
> gcc/cp/ChangeLog:
>
> PR c++/109177
> * call.cc (build_over_call): Use make_temp_override to suppress
> both unavailable and deprecated warnings when calling
> build_addr_func.
>
> gcc/testsuite/ChangeLog:
>
> PR c++/109177
> * g++.dg/ext/pr109177.C: New test.
prev parent reply other threads:[~2023-03-22 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:32 Alex Coplan
2023-03-22 15:10 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57f3d551-bf5a-6d20-b6dc-7f11a9e6c088@redhat.com \
--to=jason@redhat.com \
--cc=alex.coplan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).