From: Eric Botcazou <botcazou@adacore.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: gcc-patches@gcc.gnu.org, Anders Magnusson <ragge@tethuvudet.se>
Subject: Re: [PATCH 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address
Date: Fri, 20 Nov 2020 11:55:17 +0100 [thread overview]
Message-ID: <5801113.I3zumhsiV0@fomalhaut> (raw)
In-Reply-To: <alpine.LFD.2.21.2011200228570.656242@eddie.linux-mips.org>
> First posted at: <https://gcc.gnu.org/ml/gcc/2014-06/msg00060.html>.
> gcc/
> PR target/58901
> * reload.c (reload_inner_reg_of_subreg): Also request reloading
> for pseudo registers associated with mode dependent memory
> references.
> (push_reload): Handle pseudo registers.
The handling of this family of reloads is supposed to be done by the block of
code just above though, i.e. at line 1023. Can't we add the test based on
mode_dependent_address_p to this block, e.g. after:
|| (REG_P (SUBREG_REG (in))
&& REGNO (SUBREG_REG (in)) < FIRST_PSEUDO_REGISTER
&& !REG_CAN_CHANGE_MODE_P (REGNO (SUBREG_REG (in)),
GET_MODE (SUBREG_REG
(in)), inmode))))
instead?
--
Eric Botcazou
next prev parent reply other threads:[~2020-11-20 10:55 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 3:38 [PATCH 00/31] VAX: Bring the port up to date (yes, MODE_CC conversion is included) Maciej W. Rozycki
2020-11-20 3:34 ` [PATCH 01/31] PR target/58901: reload: Handle SUBREG of MEM with a mode-dependent address Maciej W. Rozycki
2020-11-20 10:55 ` Eric Botcazou [this message]
2020-11-20 15:30 ` Maciej W. Rozycki
2020-11-24 6:19 ` [PATCH v2 " Maciej W. Rozycki
2020-11-24 11:03 ` Eric Botcazou
2020-11-26 17:22 ` Maciej W. Rozycki
2020-11-27 3:51 ` Maciej W. Rozycki
2020-11-27 10:52 ` Ulrich Weigand
2020-11-27 19:22 ` Maciej W. Rozycki
2020-11-27 20:47 ` Maciej W. Rozycki
2020-11-27 20:50 ` [PATCH v3 " Maciej W. Rozycki
2020-11-30 18:51 ` Jeff Law
2020-11-29 17:31 ` [PATCH v2 " Jeff Law
2020-11-20 3:34 ` [PATCH 02/31] VAX: Remove `c' operand format specifier overload Maciej W. Rozycki
2020-11-20 23:16 ` Jeff Law
2020-11-24 1:12 ` Segher Boessenkool
2020-11-20 3:34 ` [PATCH 03/31] VAX: Define LEGITIMATE_PIC_OPERAND_P Maciej W. Rozycki
2020-11-21 3:17 ` Jeff Law
2020-11-20 3:34 ` [PATCH 04/31] VAX/testsuite: Run target testing over all the usual optimization levels Maciej W. Rozycki
2020-11-20 23:17 ` Jeff Law
2020-11-20 3:34 ` [PATCH 05/31] VAX: Rationalize expression and address costs Maciej W. Rozycki
2020-11-21 3:48 ` Jeff Law
2020-11-20 3:34 ` [PATCH 06/31] VAX: Correct fatal issues with the `ffs' builtin Maciej W. Rozycki
2020-11-20 23:19 ` Jeff Law
2020-11-20 3:34 ` [PATCH 07/31] RTL: Also support HOST_WIDE_INT with int iterators Maciej W. Rozycki
2020-11-21 4:19 ` Jeff Law
2020-11-20 3:34 ` [PATCH 08/31] jump: Also handle jumps wrapped in UNSPEC or UNSPEC_VOLATILE Maciej W. Rozycki
2020-11-21 4:25 ` Jeff Law
2020-12-03 3:50 ` [PATCH v2 " Maciej W. Rozycki
2020-12-03 22:20 ` Jeff Law
2020-11-20 3:34 ` [PATCH 09/31] VAX: Use a mode iterator to produce individual interlocked branches Maciej W. Rozycki
2020-11-20 23:20 ` Jeff Law
2020-11-20 3:34 ` [PATCH 10/31] VAX: Use an int " Maciej W. Rozycki
2020-11-20 23:20 ` Jeff Law
2020-11-20 3:35 ` [PATCH 11/31] VAX: Correct `sync_lock_test_and_set' and `sync_lock_release' builtins Maciej W. Rozycki
2020-11-21 4:26 ` Jeff Law
2020-11-20 3:35 ` [PATCH 12/31] VAX: Actually enable `builtins.md' now that it is fully functional Maciej W. Rozycki
2020-11-20 23:21 ` Jeff Law
2020-11-20 3:35 ` [PATCH 13/31] VAX: Add a test for the SImode `ffs' operation Maciej W. Rozycki
2020-11-20 23:22 ` Jeff Law
2020-11-20 3:35 ` [PATCH 14/31] VAX: Add tests for `sync_lock_test_and_set' and `sync_lock_release' Maciej W. Rozycki
2020-11-20 23:22 ` Jeff Law
2020-11-20 3:35 ` [PATCH 15/31] VAX: Provide the `ctz' operation Maciej W. Rozycki
2020-11-20 23:23 ` Jeff Law
2020-11-20 3:35 ` [PATCH 16/31] VAX: Also provide QImode and HImode `ctz' and `ffs' operations Maciej W. Rozycki
2020-11-20 23:24 ` Jeff Law
2020-11-20 3:35 ` [PATCH 17/31] VAX: Actually produce QImode and HImode `ctz' operations Maciej W. Rozycki
2020-11-20 23:24 ` Jeff Law
2020-11-20 3:35 ` [PATCH 18/31] VAX: Add a test for the `cpymemhi' instruction Maciej W. Rozycki
2020-11-20 23:25 ` Jeff Law
2020-11-20 3:35 ` [PATCH 19/31] VAX: Add the `movmemhi' instruction Maciej W. Rozycki
2020-11-20 23:25 ` Jeff Law
2020-11-20 3:35 ` [PATCH 20/31] VAX: Fix predicates and constraints for EXTV/EXTZV/INSV insns Maciej W. Rozycki
2020-11-21 17:01 ` Jeff Law
2020-11-20 3:35 ` [PATCH 21/31] VAX: Remove EXTV/EXTZV/INSV instruction use from aligned case insns Maciej W. Rozycki
2020-11-21 17:25 ` Jeff Law
2020-11-20 3:35 ` [PATCH 22/31] VAX: Ensure PIC mode address is adjustable with aligned bitfield insns Maciej W. Rozycki
2020-11-21 17:03 ` Jeff Law
2020-11-20 3:36 ` [PATCH 23/31] VAX: Make `extv' an expander matching the remaining bitfield operations Maciej W. Rozycki
2020-11-21 17:26 ` Jeff Law
2020-11-20 3:36 ` [PATCH 24/31] VAX: Fix predicates and constraints for bitfield comparison insns Maciej W. Rozycki
2020-11-21 17:27 ` Jeff Law
2020-11-20 3:36 ` [PATCH 25/31] VAX: Fix predicates for widening multiply and multiply-add insns Maciej W. Rozycki
2020-11-21 4:05 ` Jeff Law
2020-11-30 16:02 ` Maciej W. Rozycki
2020-11-30 18:29 ` Jeff Law
2020-11-20 3:36 ` [PATCH 26/31] VAX: Correct issues with commented-out insns Maciej W. Rozycki
2020-11-21 4:05 ` Jeff Law
2020-11-20 3:36 ` [PATCH 27/31] VAX: Make the `divmoddisi4' and `*amulsi4' comment notation consistent Maciej W. Rozycki
2020-11-21 4:06 ` Jeff Law
2020-11-24 1:37 ` Segher Boessenkool
2020-11-20 3:36 ` [PATCH 28/31] RTL: Add `const_double_zero' syntactic rtx Maciej W. Rozycki
2020-11-21 17:29 ` Jeff Law
2020-11-20 3:36 ` [PATCH 29/31] PDP11: Use `const_double_zero' to express double zero constant Maciej W. Rozycki
2020-11-21 4:07 ` Jeff Law
2020-12-15 8:26 ` Martin Liška
2020-12-15 14:06 ` Maciej W. Rozycki
2020-12-15 18:02 ` Paul Koning
2020-12-15 18:38 ` Maciej W. Rozycki
2020-11-20 3:36 ` [PATCH 30/31] PR target/95294: VAX: Convert backend to MODE_CC representation Maciej W. Rozycki
2020-11-22 3:27 ` Jeff Law
2020-12-09 16:09 ` Maciej W. Rozycki
2020-11-20 3:37 ` [PATCH 31/31] PR target/95294: VAX: Add test cases for " Maciej W. Rozycki
2020-11-21 4:08 ` Jeff Law
2020-12-05 18:40 ` Maciej W. Rozycki
2020-11-20 7:58 ` [PATCH 00/31] VAX: Bring the port up to date (yes, MODE_CC conversion is included) Anders Magnusson
2020-11-23 20:31 ` Maciej W. Rozycki
2020-11-21 21:02 ` Toon Moene
2020-11-23 21:51 ` Maciej W. Rozycki
2020-11-23 22:12 ` Thomas Koenig
2020-11-24 4:28 ` Maciej W. Rozycki
2020-11-24 5:27 ` Maciej W. Rozycki
2020-11-24 6:04 ` Maciej W. Rozycki
2020-11-24 6:16 ` Thomas Koenig
2020-11-25 19:22 ` Maciej W. Rozycki
2020-11-25 18:26 ` Maciej W. Rozycki
2020-11-25 22:20 ` Joseph Myers
2020-11-26 18:01 ` Maciej W. Rozycki
2020-11-26 18:08 ` Martin Husemann
2020-12-08 14:38 ` Maciej W. Rozycki
2020-12-08 15:22 ` Martin Husemann
2020-11-25 22:26 ` coypu
2020-11-26 17:59 ` Maciej W. Rozycki
2020-11-26 19:35 ` Maciej W. Rozycki
2020-11-23 15:48 ` Paul Koning
2020-11-25 17:07 ` Maciej W. Rozycki
2020-11-28 18:48 ` Paul Koning
2020-12-09 14:06 ` Maciej W. Rozycki
2020-12-10 1:33 ` Paul Koning
2020-12-11 14:54 ` Maciej W. Rozycki
2020-12-11 21:50 ` Paul Koning
2020-11-25 18:36 ` Maciej W. Rozycki
2020-11-26 14:46 ` Ian Lance Taylor
2020-11-26 18:07 ` Maciej W. Rozycki
2020-11-29 17:56 ` Martin Sebor
2020-12-07 14:25 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5801113.I3zumhsiV0@fomalhaut \
--to=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@linux-mips.org \
--cc=ragge@tethuvudet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).