From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33243 invoked by alias); 17 Oct 2016 16:05:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33228 invoked by uid 89); 17 Oct 2016 16:05:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=withheaders, with-headers X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 16:04:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 643E629; Mon, 17 Oct 2016 09:04:56 -0700 (PDT) Received: from [10.2.206.246] (e107157-lin.cambridge.arm.com [10.2.206.246]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16C293F32C for ; Mon, 17 Oct 2016 09:04:55 -0700 (PDT) Subject: Re: [GCC-6][RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc To: gcc-patches@gcc.gnu.org References: <20160527145135.7E3C0FD3E@oc7340732750.ibm.com> <57D2C817.3080107@arm.com> From: "Andre Vieira (lists)" Message-ID: <5804F6A6.9050809@arm.com> Date: Mon, 17 Oct 2016 16:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <57D2C817.3080107@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg01319.txt.bz2 On 09/09/16 15:32, Andre Vieira (lists) wrote: > On 27/05/16 15:51, Ulrich Weigand wrote: >> Andre Vieira (lists) wrote: >>> On 07/04/16 10:30, Andre Vieira (lists) wrote: >>>> On 17/03/16 16:33, Andre Vieira (lists) wrote: >>>>> On 23/10/15 12:31, Bernd Schmidt wrote: >>>>>> On 10/12/2015 11:58 AM, Ulrich Weigand wrote: >>>>>>> >>>>>>> Index: gcc/configure.ac >>>>>>> =================================================================== >>>>>>> --- gcc/configure.ac (revision 228530) >>>>>>> +++ gcc/configure.ac (working copy) >>>>>>> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t >>>>>>> fi >>>>>>> >>>>>>> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then >>>>>>> - if test "x$with_headers" != x; then >>>>>>> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then >>>>>>> target_header_dir=$with_headers >>>>>>> elif test "x$with_sysroot" = x; then >>>>>>> >>>>>>> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include" >>>>>>> >>>>>> >>>>>> I'm missing the beginning of this conversation, but this looks like a >>>>>> reasonable change (avoiding target_header_dir=yes for --with-headers). >>>>>> So, approved. >>>>>> >>>>>> >>>>>> Bernd >>>>>> >>>>> Hi there, >>>>> >>>>> I was wondering why this never made it to trunk. I am currently running >>>>> into an issue that this patch would fix. >> >> Seems I never actually checked this in, even though it was approved. >> Thanks for the reminder, I've now checked the patch in. >> >> Bye, >> Ulrich >> > > Is it OK to backport this fix to GCC-6? It applies cleanly, builds and > no regressions for arm-none-eabi. > > Regards, > Andre > Ping.