public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: sgk@troutmask.apl.washington.edu,
	Thomas Koenig via Fortran <fortran@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix fc-prototypes usage with C_INT64_T and non LP64 Targets.
Date: Sat, 1 Apr 2023 10:24:55 +0200	[thread overview]
Message-ID: <58105836-809d-6874-e7f3-71e75229ede7@netcologne.de> (raw)
In-Reply-To: <ZCXdc51oF/fkeTMR@troutmask.apl.washington.edu>

Hi Steve,

>> Hi Andrew,
>>
>>> "long long". This was just an oversight and a missing check.
>>>
>>> Committed as obvious after a bootstrap/test on x86_64-linux-gnu.
>>
>> Thanks!
>>
>> I think this one is obvious enough that it deserves a backport.
>> I've cherry-picked this for gcc12, will do gcc11 tomorrow.
>>
> 
> The patch is incomplete.
> 
> module foo
>   use, intrinsic :: iso_c_binding
>   implicit none
>   public :: bar
>   type, bind(c) :: bar
>    real(10) a
>   end type
> end module
> 
> This yields
> 
> typedef struct bar {
> long_double a /* WARNING: Converting 'REAL(10)' to interoperable type */;
> } bar;
> 
> That should be 'long double'.

Fixed as obvious in 69044e11ac5 .

I will backport soon.

Thanks for the heads-up!

Best regards

	Thomas


      reply	other threads:[~2023-04-01  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  3:47 Andrew Pinski
2023-03-30 17:39 ` Thomas Koenig
2023-03-30 19:05   ` Steve Kargl
2023-04-01  8:24     ` Thomas Koenig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58105836-809d-6874-e7f3-71e75229ede7@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=apinski@marvell.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).