From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 81CEA3858D37 for ; Wed, 5 Oct 2022 01:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 81CEA3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1664933047; bh=2CNg9aRP8LXvvGfhSw6u5u0Hu8aBNMAvwXDpNSGhSx8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=EA23DLVn5uNqlrsqpWOssoZmw8Nb6rksfi6bt23VK5Qy8xt1WoxcWN7Cy1kQ0eTPu jObb7RwudelpVodJFOhXTKQFeXTtVZ1J2jKz7k6511FXy+te/DO6rQZ0TXG8T86JFd oy1bh/e9jpKvHQwMxlDzcQMsupZC375np2SPbwz8= Received: from [IPv6:240e:358:1191:4a00:dc73:854d:832e:3] (unknown [IPv6:240e:358:1191:4a00:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 6DBAC6687C; Tue, 4 Oct 2022 21:24:04 -0400 (EDT) Message-ID: <5821cc8835d5db2f185df37c5c31865015e6d350.camel@xry111.site> Subject: Re: Adding a new thread model to GCC From: Xi Ruoyao To: LIU Hao Cc: gcc-patches@gcc.gnu.org Date: Wed, 05 Oct 2022 09:23:55 +0800 In-Reply-To: References: <0f1f223a-3756-1da3-bd1d-b87edd34e1f9@126.com> <7116A6F3-3968-4720-A65C-FFB05BFE181D@gmail.com> <7c519f0b-2a6d-e9bf-993a-2eff2cdad418@126.com> <0F33BB41-41EC-4068-84F1-9AD6DCCF190A@gmail.com> <8ccc48f13c385c6c3583cc9e63a09457163dcd23.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_PDS_OTHER_BAD_TLD autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2022-10-04 at 21:45 +0800, LIU Hao wrote: > =E5=9C=A8 2022-10-04 21:13, Xi Ruoyao =E5=86=99=E9=81=93: > >=20 > > In GCC development we usually include the configure regeneration in the > > patch because the scripts are also version controlled. > >=20 >=20 > There is a reason for not doing that: Generated contents can't be reviewe= d. >=20 > In mingw-w64 we do the opposite: The person who commits a patch is respon= sible for update configure,=20 > Makefile.in, etc. The patch itself doesn't include generated contents. The reviewer can simply skip the changes in configure. But including the configure allows the potential testers to test the change without autoconf-2.69 installed. Maybe we can make a compromise: put the line "configure: Regenerate." in the ChangeLog, but do not actually include the change. Now if the committer forgot to regenerate it, the git hook will reject the push immediately. (Just my 2 cents.) --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University