From: Sandra Loosemore <sandra@codesourcery.com>
To: Martin Sebor <msebor@gmail.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: PING [PATCH] enable -fprintf-return-value by default
Date: Fri, 18 Nov 2016 05:35:00 -0000 [thread overview]
Message-ID: <582E92FA.8070800@codesourcery.com> (raw)
In-Reply-To: <ff8d99a0-b0ab-3104-9d0b-5e2b4ae4ae8a@gmail.com>
On 11/16/2016 09:49 AM, Martin Sebor wrote:
> I'm looking for an approval of the attached patch.
>
> I've adjusted the documentation based on Sandra's input (i.e.,
> documented the negative of the option rather than the positive;
> thank you for the review, btw.)
>
> On 11/08/2016 08:13 PM, Martin Sebor wrote:
>> The -fprintf-return-value optimization has been disabled since
>> the last time it caused a bootstrap failure on powerpc64le. With
>> the underlying problems fixed GCC has bootstrapped fine on all of
>> powerpc64, powerpc64le and x86_64 and tested with no regressions.
>> I'd like to re-enable the option. The attached patch does that.
>
> [snip]
>
> Index: gcc/doc/invoke.texi
> ===================================================================
> --- gcc/doc/invoke.texi (revision 242500)
> +++ gcc/doc/invoke.texi (working copy)
> @@ -384,7 +384,7 @@ Objective-C and Objective-C++ Dialects}.
> -fno-toplevel-reorder -fno-trapping-math -fno-zero-initialized-in-bss @gol
> -fomit-frame-pointer -foptimize-sibling-calls @gol
> -fpartial-inlining -fpeel-loops -fpredictive-commoning @gol
> --fprefetch-loop-arrays -fprintf-return-value @gol
> +-fprefetch-loop-arrays -fno-printf-return-value @gol
> -fprofile-correction @gol
> -fprofile-use -fprofile-use=@var{path} -fprofile-values @gol
> -fprofile-reorder-functions @gol
Please keep this list alphabetized -- the other "-fno-*" options are
sorted as such. The documentation parts of the patch are OK with that
fixed, but I can't approve changing the default for the option.
-Sandra
next prev parent reply other threads:[~2016-11-18 5:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 3:13 Martin Sebor
2016-11-09 17:05 ` Sandra Loosemore
2016-11-16 16:49 ` PING " Martin Sebor
2016-11-18 5:35 ` Sandra Loosemore [this message]
2016-11-18 16:01 ` Martin Sebor
2016-11-18 17:39 ` Sandra Loosemore
2016-11-18 18:52 ` Martin Sebor
2016-11-18 19:05 ` Jeff Law
2016-11-18 20:08 ` documenting command-line options (was Re: PING [PATCH] enable -fprintf-return-value by default) Sandra Loosemore
2016-11-18 18:32 ` [PATCH] enable -fprintf-return-value by default Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582E92FA.8070800@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).