From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 6CD613858C1F for ; Wed, 7 Jun 2023 22:18:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CD613858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-652426346bbso4083680b3a.3 for ; Wed, 07 Jun 2023 15:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686176304; x=1688768304; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2DdHFLVTj0s+vj0do6Fc28Dz/wAcaCr5iniassC8lTM=; b=bQD5ZxIls2vxb+lgm9TP5Lh04iknvH9oJsd66Xi+fiDYgYHciAAn1oiGqaxiIbDVeg zYpF2SaD6G/hbYSSrRAyAXQcpJVALai5F1SE0HkUUY+cFQMzGPVbQmQu4ilarqV6PLPI w2jmbJ13pU8+FYwzEeLnUb+y5F5oDDja0aGjby72FhvSWG9zambh8n/PlYCY0intnH6e DQFZCvvhr6qCMVv4CseAMuhlW6PyAeoG0ilyr617uOf1TO/eaG4Ec8NZj6XUTaLmV2NA qv+tUzbVkvX2YdZRiQe3uHuqLq7uZoR+SatUGNAOcno96GsHn7cUHijkhmWP67EdnlhC Nkzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686176304; x=1688768304; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2DdHFLVTj0s+vj0do6Fc28Dz/wAcaCr5iniassC8lTM=; b=D+BkgyK7597MOXJATj28M7GM+860iKJ2AzlvWE85FSEK8oqvWP7elp1JQjRfbUctxw xPWn9Y/8R5v/bzIXv+qoOM2VUsp2ILrNdqrQvzYxzypoyNeIamV/do35DP8wJrhI/Tki r9TtjgS4a3HmP4cYL592S7gM+URmcmJlbiXN2RXKVoJeXrgudJ6d1n+0i28txjERf6FM ND/0XkaS+8/RCaqbvWcy2aPhktvdFO2JNgzIO1d1mwx/V4UfkB/qrgpKsd7TYMlX/3KB zDtuhTzs22L32igfXWoyFMPb9dku9A/cGTS9FQIYBeVIrJr+fKqgUNl5cfaR4JJBtxPV OFHQ== X-Gm-Message-State: AC+VfDxYj5u3Dn1s6qc+MsQv3k9qHcpOxz/3KDyHHgvLQF/82uqD5bMt 1luBynjmv4bmhESimToZBPA= X-Google-Smtp-Source: ACHHUZ6Me6RmhE/O+fw+zsYumX0r6HyUZY0E7UK1hm9y0uooCb9GkcdyqyMQyv9c79mMALUUMMwCRg== X-Received: by 2002:a17:902:6b0a:b0:1b1:bcc1:bcdb with SMTP id o10-20020a1709026b0a00b001b1bcc1bcdbmr3170075plk.53.1686176304269; Wed, 07 Jun 2023 15:18:24 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id jd5-20020a170903260500b001b243a5a5e1sm2765593plb.298.2023.06.07.15.18.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 15:18:23 -0700 (PDT) Message-ID: <5836d561-2986-484c-8d9a-744c948e8602@gmail.com> Date: Wed, 7 Jun 2023 16:18:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/2] cprop_hardreg: Enable propagation of the stack pointer if possible. Content-Language: en-US To: Manolis Tsamis , gcc-patches@gcc.gnu.org Cc: Richard Biener , Palmer Dabbelt , Philipp Tomsich , Kito Cheng References: <20230525123550.1072506-1-manolis.tsamis@vrull.eu> <20230525123550.1072506-3-manolis.tsamis@vrull.eu> From: Jeff Law In-Reply-To: <20230525123550.1072506-3-manolis.tsamis@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/25/23 06:35, Manolis Tsamis wrote: > Propagation of the stack pointer in cprop_hardreg is currenty forbidden > in all cases, due to maybe_mode_change returning NULL. Relax this > restriction and allow propagation when no mode change is requested. > > gcc/ChangeLog: > > * regcprop.cc (maybe_mode_change): Enable stack pointer propagation. Thanks for the clarification. This is OK for the trunk. It looks generic enough to have value going forward now rather than waiting. jeff