From: Sandra Loosemore <sandra@codesourcery.com>
To: Daniel Santos <daniel.santos@pobox.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/9] Add option -moutline-msabi-xlogues
Date: Fri, 25 Nov 2016 23:51:00 -0000 [thread overview]
Message-ID: <5838CE73.50008@codesourcery.com> (raw)
In-Reply-To: <20161123051918.22517-3-daniel.santos@pobox.com>
On 11/22/2016 10:19 PM, Daniel Santos wrote:
> diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt
> index 9eef558..f556978 100644
> --- a/gcc/config/i386/i386.opt
> +++ b/gcc/config/i386/i386.opt
> @@ -528,6 +528,11 @@ Enum(calling_abi) String(sysv) Value(SYSV_ABI)
> EnumValue
> Enum(calling_abi) String(ms) Value(MS_ABI)
>
> +moutline-msabi-xlogues
> +Target Report Mask(OUTLINE_MSABI_XLOGUES) Save
> +Reduces function size by using out-of-line stubs to save & restore registers
> +clobberd by differences in Microsoft and System V ABIs.
> +
Just as a suggestion (I'm not an i386 maintainer), I'd recommend
spelling the name of this option -mno-inline-msabi-xlogues instead of
-moutline-msabi-xlogues, and making the default -minline-msabi-xlogues.
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 8e2f466..4706085 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -25004,6 +25004,15 @@ You can control this behavior for specific functions by
> using the function attributes @code{ms_abi} and @code{sysv_abi}.
> @xref{Function Attributes}.
>
> +@item -moutline-msabi-xlogues
> +@itemx -mno-outline-msabi-xlogues
By convention, we only list the option form that is not the default....
> +@opindex moutline-msabi-xlogues
...but we should have index entries for both.
> +Due to differences in 64-bit ABIs, any Microsoft ABI function that calls a
> +SysV ABI function must consider RSI, RDI and XMM6-15 as clobbered, emitting
> +fairly lengthy prologues & epilogues. This option generates prologues &
> +epilogues that instead call stubs in libgcc to perform these saves & restores,
> +thus reducing function size at the cost of a few extra instructions.
Please use the word "and" in all three locations here, instead of "&".
-Sandra
next prev parent reply other threads:[~2016-11-25 23:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 5:11 [PATCH v2 0/9] Add optimization -moutline-msabi-xlougues (for Wine 64) Daniel Santos
2016-11-23 5:16 ` [PATCH 9/9] Add remainder of moutline-msabi-xlogues implementation Daniel Santos
2016-11-23 5:16 ` [PATCH 8/9] Add msabi pro/epilogue stubs to libgcc Daniel Santos
2016-11-23 5:16 ` [PATCH 3/9] Add option -moutline-msabi-xlogues Daniel Santos
2016-11-25 23:51 ` Sandra Loosemore [this message]
2016-11-26 1:27 ` Daniel Santos
2016-11-23 5:16 ` [PATCH 6/9] Modify ix86_compute_frame_layout for foutline-msabi-xlogues Daniel Santos
2016-11-23 5:16 ` [PATCH 1/9] Change type of x86_64_ms_sysv_extra_clobbered_registers Daniel Santos
2016-11-23 5:16 ` [PATCH 4/9] Adds class xlouge_layout and new fields to struct machine_function Daniel Santos
2016-11-23 5:16 ` [PATCH 5/9] Modify ix86_save_reg to optionally omit stub-managed registers Daniel Santos
2016-11-23 5:16 ` [PATCH 7/9] Add patterns and predicates foutline-msabi-xlouges Daniel Santos
2016-11-23 5:16 ` [PATCH 2/9] Minor refactor in ix86_compute_frame_layout Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5838CE73.50008@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=daniel.santos@pobox.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).