From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id A6BC33858C60 for ; Wed, 29 Sep 2021 15:30:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6BC33858C60 Received: by mail-pg1-x535.google.com with SMTP id 17so3113424pgp.4 for ; Wed, 29 Sep 2021 08:30:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NOulaGIStMN1JmkJRElN3MsYBCn210iL3cegG8heaLU=; b=N9nWzBUH5VT4dmZlTwsqpTISAANGOcu429FiscgcJTqUiqcHSsBJS9bXuG144fcwvt iAmYHXsHeYOJ3SVr5Yyjx+Nuz2+H4opHbWVMXROM0Yvsu/M6NiaJdBo0/AeP4HANRrI4 I4KwoIh57QuhD8A9kvaXczGrjYAcF5OnbAxUoAu2xiuZAiDnEPFvmSK2xB64Mlj8a0q9 Pz8kOgplKRFs8V3AQ9C+aX+f0VKjnow4fKjyEUJHybMXrGsqse4XSmPs99uniK8hucQk SgHIA2WrgEqcynhhJFzC3R/+qYNtrkbHEKcY2v8SGUg2zJeef/AttPwrrLDWO+puwRbM gr7w== X-Gm-Message-State: AOAM532vPvH3XYqpR8TE7F3y+l2UhuTFdjfpXc4TZ4JF75tR+SbAba9t QqPDZsMYaVnNe/Rq+F5XJrAnWox2Lvk= X-Google-Smtp-Source: ABdhPJyXz77XWghRxMgpWtMVE0jZmPpfNkQ/228wjM+2qpBEn6LbRqicrTN7ZUx/Fyguy2zp6unQpw== X-Received: by 2002:a63:a74e:: with SMTP id w14mr532631pgo.104.1632929424311; Wed, 29 Sep 2021 08:30:24 -0700 (PDT) Received: from [192.168.1.24] (65-130-91-168.slkc.qwest.net. [65.130.91.168]) by smtp.gmail.com with ESMTPSA id c18sm44304pge.69.2021.09.29.08.30.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 08:30:24 -0700 (PDT) Subject: Re: [PATCH] Use a separate TV_* timer for the VRP threader. To: Aldy Hernandez Cc: Andrew MacLeod , GCC patches References: <20210929152607.1270206-1-aldyh@redhat.com> From: Jeff Law Message-ID: <5846635e-bf99-317e-4ae8-abc87d02ba96@gmail.com> Date: Wed, 29 Sep 2021 09:30:22 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210929152607.1270206-1-aldyh@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 15:30:26 -0000 On 9/29/2021 9:26 AM, Aldy Hernandez wrote: > There seems to be a memory consumption issue on 32 bit hosts after the > hybrid threader patchset. I'm having a hard time reproducing, and in > the process I've noticed that the threader is using the TV_TREE_VRP > timer. Having a distinct one could help diagnose this and other > issues going forward. > > Jeff, if you think this could help, I'd like to push this to trunk, but > if not, I'm perfectly happy attaching it to the 2 PRs for now. :) > > gcc/ChangeLog: > > * timevar.def (TV_TREE_VRP_THREADER): New. > * tree-vrp.c: Use TV_TREE_VRP_THREADER for VRP threader pass. OK. And just to be clear, I'm talking about slowing down on refactoring and the like.  Bugfixes, dumping improvements and the like can and should go forward. Jeff