From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38406 invoked by alias); 9 Dec 2016 18:20:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38311 invoked by uid 89); 9 Dec 2016 18:20:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Sandra, thoroughly, H*Ad:U*sandra, H*F:U*sandra X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Dec 2016 18:20:48 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cFPmm-000303-UW from Sandra_Loosemore@mentor.com ; Fri, 09 Dec 2016 10:20:44 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 9 Dec 2016 10:20:41 -0800 Subject: Re: [0/67] Add wrapper classes for machine_modes To: , References: <87h96dp8u6.fsf@e105548-lin.cambridge.arm.com> From: Sandra Loosemore Message-ID: <584AF5F8.6090408@codesourcery.com> Date: Fri, 09 Dec 2016 18:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87h96dp8u6.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-SW-Source: 2016-12/txt/msg00906.txt.bz2 On 12/09/2016 05:48 AM, Richard Sandiford wrote: > This series includes most of the changes in group C from: > > https://gcc.gnu.org/ml/gcc/2016-11/msg00033.html > > The idea is to add wrapper classes around machine_mode_enum > for specific groups of modes, such as scalar integers, scalar floats, > complex values, etc. [snip] > > Sorry that this is so late, been distracted by other things. Even if > we're too far into stage 3 for SVE itself to go in, I was hoping this > part (which was kind-of posted during stage 1) could go in independently. I have no power to approve or reject this patch series.... but, just as an engineering process matter, I don't think this belongs in Stage 3: "During this two-month period, the only (non-documentation) changes that may be made are changes that fix bugs or new ports which do not require changes to other parts of the compiler. New functionality may not be introduced during this period." I don't think a 67-part patch series whose existence was revealed only 3 days before the close of stage 1 and were not actually posted qualifies for the "Patches posted early enough during Stage 1 and not yet fully reviewed may still get in early in Stage 3." exception either. Richard, I appreciate that you are very methodical in your work and careful to test it thoroughly. But IMO a patch series this invasive is likely to disrupt other people who are trying to fix bugs at this time to improve the 7.0 release quality. -Sandra