From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 719273858D28 for ; Wed, 20 Mar 2024 21:53:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 719273858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 719273858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710971611; cv=none; b=m1RtH9yX6R4sloYhhPZYEWFgNVwhlQIQ2nFpcXPTPSQixG7KV8HD7ZfWZfDgGcmDKE2zw9H11KIZFDBOTS8yd4a/Pvjqp20vUGhpJhTOEdORrvDEGkGomaJl/vFyBI2CgqHeDo0BGJzTSD/ap57dlpy6q1WdeGreuXflhF0ZO3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710971611; c=relaxed/simple; bh=LnXxjlBtuJ3cxnBhUVGqpIfw0YWM2l9vPYfP6VUreLw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=v1jEJk6v7/P5MfpP54mOUskNa+HEmd+g/fNl9X3ZtRwN2tOd0L+8+hHUFJFZYlEpKi2x/HJxccR02uVMWaxZ32ZBoHJOfll2/g7uNQDRk5raG85njBKDwTguHR6waByzElTUtjBVP0N3j2rkxgW6Kx/XJ3xgX5D0MvrhlygT8pg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a4702457ccbso38913966b.3 for ; Wed, 20 Mar 2024 14:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710971607; x=1711576407; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8nRb1fJ7Vo6ydMk5GvNWh6IUajErfvaWr9VUjCahIKU=; b=Beu5qVJ3RzYVjg22WtwG/u1qj2Dy2uRN/bZROVrah+kB/dBHwkvRX5J/WbgRn0TdkE NwvNfVnOQeH/SZwT9pD2YPUn5CzMUBYBM2zgxGCY9nKRre1bDB73suw0Cu0Lznu5jRkI 4TzfNGWeSSQ8Vf5Y2P/cse09rteRQT8SLkcGYHyAyW+kvrAzuI2Qhrg1z1478JvMIVNe S8RpZZ4ea271hQhOtXVtFWUUnE0E//UCEELll35qSOOvkN+ENbQ12xP6HGms4TZZb0F0 w90rVo3mzpaOs413FEfyPKGZBWpyUYQ/Znz6/a/4d4wVz/corkUaMk+wzB/ytIbV+j8z sOxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710971607; x=1711576407; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8nRb1fJ7Vo6ydMk5GvNWh6IUajErfvaWr9VUjCahIKU=; b=Ri/xu/2bSrlPsdOu/f+g1LTDNTUTcmmv6HsZNuaDUTiaiaIQLvSlbt/5WQRIQV3TD7 DqNuw21tlOfM9hEL6Lrfwa2Vh31M81tSkE/8w3u4/Y7oVIDK2pl84ar2ljcuTaGkYFqX bJGyiOgDxRVIT1/daiMwG9FQBwmOgw8GvYI8aKyVwMdtbINJjl6lcocTDQSUesAOVWj9 VuM/pjs+obIkTbLaW4bKgeDO5AIcA8RQCTD/IJRaEyVB2bAWfTXwC7K2AgpE4Q9MeD0B UE7iMXRT8Pbk6IwRGUU0bJVA0PfhvkHYeCRkuf/PDVKEa4tt+OeOsqncwaImFwIDjl5A wc6g== X-Gm-Message-State: AOJu0YwlgNlGn8vfrtaLQ5l/4D+wBxJ/t4wtPKqoCdZ18xCNK3nRfAtq r0QMOMtH5Ca2C5KpW/c/7fe6mzEQdnMDgufiQPSNdFcIkKaDL4Yx+kelfCIC X-Google-Smtp-Source: AGHT+IGQZxVqxgP3OJMza6xGWLS0DE/gYQiPhIFMnwhdoVkeKRhea/sLQwIfpTnN2DM6GTH093IFSg== X-Received: by 2002:a17:907:77d4:b0:a45:f965:9963 with SMTP id kz20-20020a17090777d400b00a45f9659963mr4130236ejc.59.1710971607341; Wed, 20 Mar 2024 14:53:27 -0700 (PDT) Received: from ?IPv6:::1? ([2001:4bb8:109:d49d:78c9:ab6d:dad7:8cb6]) by smtp.gmail.com with ESMTPSA id vi2-20020a170907d40200b00a45c8b6e965sm7729914ejc.3.2024.03.20.14.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 14:53:26 -0700 (PDT) Date: Wed, 20 Mar 2024 22:53:18 +0100 From: rep.dot.nop@gmail.com To: gcc-patches@gcc.gnu.org, Christophe Lyon , Evgeny Karpov CC: "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" , "Richard Earnshaw (lists)" , "Andrew Pinski (QUIC)" , Maxim Kuvyrkov , Radek Barton Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_08/13=5D_aarch64=3A_Add_Cyg?= =?US-ASCII?Q?win_and_MinGW_environments_for_AArch64?= In-Reply-To: References: Message-ID: <585C5D2D-724C-4E6A-8BAC-3DF4303F11E9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19 March 2024 14:40:57 CET, Christophe Lyon wrote: >On Mon, 18 Mar 2024 at 22:35, Evgeny Karpov wrote: >> >> Monday, March 18, 2024 2:27 PM >> Christophe Lyon wrote: >> >> > > +/* Disable SEH and declare the required SEH-related macros that ar= e >> > > +still needed for compilation=2E */ #undef TARGET_SEH #define >> > > +TARGET_SEH 0 >> > > + >> > > +#define SSE_REGNO_P(N) 0 >> > > +#define GENERAL_REGNO_P(N) 0 >> > I think you forgot to add a comment to explain the above two lines=2E >> > (it was requested during v1 review) >> > >> > Thanks, >> > >> > Christophe >> >> Hi Christophe, >> >> Thank you for the review! >> The comment regarding SEH and SEH-related macros has been added two lin= es above=2E >> It may not be obvious, but these macros are needed to emit SEH data in = mingw/winnt=2Ecc=2E >> This group is separated by an empty line; however, it still relates to = SEH-related macros=2E >> >Thanks for the clarification, I thought that comment only applied to >the two lines about TARGET_SEH=2E So, for avoidance of doubt, please drop the vertical space before SSE_REGN= O_P to be gentle to the casual/inattentive reader? Or add /* SEH-related */ after the vertical space, to make it clear? thanks