public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Richard Biener <richard.guenther@gmail.com>,
	Tom de Vries <Tom_deVries@mentor.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite
Date: Fri, 24 Mar 2017 17:45:00 -0000	[thread overview]
Message-ID: <587C88D3-2CEA-4E54-899E-ADFE8FBB6DC4@comcast.net> (raw)
In-Reply-To: <yddpoh6bzm9.fsf@CeBiTec.Uni-Bielefeld.DE>

On Mar 24, 2017, at 5:58 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
> -      { /* { dg-warning "statement may fall through" "" { target c } 23 } */
> -	int a[i]; /* { dg-warning "statement may fall through" "" { target c++ } 24 } */
> +      { /* { dg-warning "statement may fall through" "" { target c } 24 } */
> +	int a[i]; /* { dg-warning "statement may fall through" "" { target c++ } 25 } */

Any reason to not use relative line numbers?  See testsuite/gcc.dg/dg-test-1.c for a template for how to do it.  I think they should work and be better.  Indeed, all line numbers should be relative, generally speaking.

  reply	other threads:[~2017-03-24 17:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 15:46 Tom de Vries
2017-03-23 16:24 ` Thomas Schwinge
2017-03-23 16:51   ` Tom de Vries
2017-03-23 17:45 ` Mike Stump
2017-03-24  7:46   ` Tom de Vries
2017-03-24 12:43     ` Rainer Orth
2017-03-24 12:44       ` Richard Biener
2017-03-24 12:53         ` Rainer Orth
2017-03-24 13:04           ` Rainer Orth
2017-03-24 17:45             ` Mike Stump [this message]
2017-03-27 14:14               ` Tom de Vries
     [not found]                 ` <d453445e-54be-d3b5-cc27-d73bdbcc855d@mentor.com>
2017-04-26 12:40                   ` Tom de Vries
2017-04-26 12:50                     ` Jakub Jelinek
2017-04-27  9:03                       ` Tom de Vries
2017-04-28  8:23                         ` Tom de Vries
2017-04-28 14:31                         ` Tom de Vries
2017-04-28  1:35                       ` Tom de Vries
2017-04-28 16:28                         ` Jeff Law
2017-03-27 13:11       ` Tom de Vries
2017-03-28  8:51 ` Thomas Schwinge
2017-03-28  8:57   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=587C88D3-2CEA-4E54-899E-ADFE8FBB6DC4@comcast.net \
    --to=mikestump@comcast.net \
    --cc=Tom_deVries@mentor.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).