public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Martin Sebor <msebor@gmail.com>,
	 Gcc Patch List <gcc-patches@gcc.gnu.org>,
	Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] adding missing LTO to some warning options (PR 78606)
Date: Tue, 17 Jan 2017 12:04:00 -0000	[thread overview]
Message-ID: <587E0848.1000300@foss.arm.com> (raw)
In-Reply-To: <06c24069-90af-5778-52a2-c9167eb109ab@gmail.com>

Hi Martin,

On 10/01/17 22:16, Martin Sebor wrote:
> The -Walloca-larger-than, -Wformat-length, and -Wformat-truncation
> options do not mention LTO among the supported languages and so are
> disabled when -flto is used, causing false negatives.
>
> The attached patch adds the missing LTO to the three options. This
> makes -Walloca-larger-than work with LTO but not the other two
> options, implying that something else is preventing the gimple-ssa-
> sprintf pass from running when -flto is enabled.  I haven't had
> the cycles to look into what that might be yet.  Since the root
> causes are independent I'd like to commit this patch first and
> deal with the  -Wformat-{length,truncation} problem separately,
> under a new bug (or give someone with a better understanding of
> LTO the opportunity to do it).
>

I see the new test FAILing on arm and aarch64 targets.
FAIL: gcc.dg/pr78768.c execution test

Thanks,
Kyrill

> Thanks
> Martin

  parent reply	other threads:[~2017-01-17 12:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 22:16 Martin Sebor
2017-01-11  8:21 ` Richard Biener
2017-01-13 18:49 ` Andreas Schwab
2017-01-17 12:04 ` Kyrill Tkachov [this message]
2017-01-17 16:45   ` Martin Sebor
2017-04-30 23:39 ` Tom de Vries
2017-05-01 18:05   ` Martin Sebor
2017-05-02 10:22     ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=587E0848.1000300@foss.arm.com \
    --to=kyrylo.tkachov@foss.arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=msebor@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).