From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125784 invoked by alias); 17 Jan 2017 12:04:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125759 invoked by uid 89); 17 Jan 2017 12:04:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=opportunity, among X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jan 2017 12:04:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE405707; Tue, 17 Jan 2017 04:04:26 -0800 (PST) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C2133F24D; Tue, 17 Jan 2017 04:04:25 -0800 (PST) Message-ID: <587E0848.1000300@foss.arm.com> Date: Tue, 17 Jan 2017 12:04:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Martin Sebor , Gcc Patch List , Richard Biener Subject: Re: [PATCH] adding missing LTO to some warning options (PR 78606) References: <06c24069-90af-5778-52a2-c9167eb109ab@gmail.com> In-Reply-To: <06c24069-90af-5778-52a2-c9167eb109ab@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg01187.txt.bz2 Hi Martin, On 10/01/17 22:16, Martin Sebor wrote: > The -Walloca-larger-than, -Wformat-length, and -Wformat-truncation > options do not mention LTO among the supported languages and so are > disabled when -flto is used, causing false negatives. > > The attached patch adds the missing LTO to the three options. This > makes -Walloca-larger-than work with LTO but not the other two > options, implying that something else is preventing the gimple-ssa- > sprintf pass from running when -flto is enabled. I haven't had > the cycles to look into what that might be yet. Since the root > causes are independent I'd like to commit this patch first and > deal with the -Wformat-{length,truncation} problem separately, > under a new bug (or give someone with a better understanding of > LTO the opportunity to do it). > I see the new test FAILing on arm and aarch64 targets. FAIL: gcc.dg/pr78768.c execution test Thanks, Kyrill > Thanks > Martin