From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5BD703858292 for ; Tue, 5 Jul 2022 20:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BD703858292 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-533-woYZXCy-MwaA0QcVoxisxg-1; Tue, 05 Jul 2022 16:50:46 -0400 X-MC-Unique: woYZXCy-MwaA0QcVoxisxg-1 Received: by mail-qt1-f197.google.com with SMTP id u2-20020ac80502000000b002f94701339eso10445496qtg.13 for ; Tue, 05 Jul 2022 13:50:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=ujHV/qeU4x1X1g/GjtJ8dazIJGlsBWFd6Ajw2CoIB/Q=; b=Lkd/QjxPJm7SpPM4pW8K0ND2WHK8yeLzvnY9CGYJHZc250SQyuxKeosGu7w31B5Wtd uvMeWJ9q643R5z0uhDdDCvlXDu+j5MRIeAWCrXF7khBMbcaufUX02QKF9UXobBQRZutu 0o7f8fX+YpEXaX6I4DIdSry2SznSLVNjE+DKxN4KcyxQyiC6A8pwkyt/WZnWq8W3ZqvQ 8cVJ0mb8F5gOxQDazYG+Y6KBev5raKem6nghp+tHgzxp+FI9ZaGjB9+aqWB695skqwWr 8AlKsPUElHpKaiH1X1NsgdZt2CV0n7E2e3zpIaziC6lukCa8lSNvkPU6WJvmLwpx5YV7 lj/g== X-Gm-Message-State: AJIora/vBelhyycYf9gwFy+GrmcQdRdTGDgf4XRy6dLC9rd7RTLsOEsL H/aOQl9dnIl96G+pYy3y9fNVfgCycgRKhJTzWXp2Y296QR/sFCvUBcZY+zDhw3m1KTKHEWxBYe7 Wcjl04nXbpVWYPwj7ug== X-Received: by 2002:ac8:5744:0:b0:31d:4baf:f12a with SMTP id 4-20020ac85744000000b0031d4baff12amr11179454qtx.451.1657054245592; Tue, 05 Jul 2022 13:50:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u2Lfe6YUafdUZZ6k8Iq3zRigUB8ms66jzcHmraIJKT7/F33/4otZBGZaH48QbCRxw/8RRrmg== X-Received: by 2002:ac8:5744:0:b0:31d:4baf:f12a with SMTP id 4-20020ac85744000000b0031d4baff12amr11179441qtx.451.1657054245340; Tue, 05 Jul 2022 13:50:45 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id de16-20020a05620a371000b006b46997c0a9sm5041726qkb.72.2022.07.05.13.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 13:50:44 -0700 (PDT) Message-ID: <5888488873bd4d780786031a0aeae904e64fd54b.camel@redhat.com> Subject: Re: [PATCH 1/2] analyzer: show close event for use_after_close diagnostic From: David Malcolm To: Mir Immad , gcc-patches@gcc.gnu.org Date: Tue, 05 Jul 2022 16:50:43 -0400 In-Reply-To: References: User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 20:50:49 -0000 On Tue, 2022-07-05 at 23:07 +0530, Mir Immad wrote: [...snip...] >  gcc/analyzer/sm-fd.cc                | 13 +++++++++++-- >  gcc/testsuite/gcc.dg/analyzer/fd-4.c |  4 ++-- >  2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc > index 4058ac53308..a85c95cc502 100644 > --- a/gcc/analyzer/sm-fd.cc > +++ b/gcc/analyzer/sm-fd.cc > @@ -454,7 +454,10 @@ public: >        return label_text::borrow ("opened here"); > >      if (change.m_new_state == m_sm.m_closed) > +    { > +      m_first_close_event = change.m_event_id; >         return change.formatted_print ("closed here"); > +    } Looks like the indentation isn't quite right here, or did the patch get mangled during the emailing process? [...snip...] Otherwise, the patch looks good. Thanks Dave