public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>,Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix free_lang_data on asm stmts (PR lto/91572)
Date: Sun, 01 Sep 2019 12:30:00 -0000	[thread overview]
Message-ID: <58A31C6E-354F-4D7A-82D3-8165B50BBBE9@gmail.com> (raw)
In-Reply-To: <20190901115514.GI2120@tucnak>

On September 1, 2019 1:55:14 PM GMT+02:00, Jakub Jelinek <jakub@redhat.com> wrote:
>On Sat, Aug 31, 2019 at 03:02:18PM +0200, Richard Biener wrote:
>> Ok, but I wonder if we can stream the constraint strings in a simpler
>way - surely the type doesn't really matter?
>> Why are they not identifier nodes? 
>
>I guess they have type because they are parsed like any other string
>literals during parsing and once we parse them that way, it isn't worth
>changing them to something else like an identifier.

Hmm, so we accept wide-char literals as well here? 

>Would it be enough to just clear their type during free lang data or
>something similar?

I guess so. Maybe do that during gimplification already? Wonder how we pretty print asms then when we mangle their types. Note the original patch is OK as-is I just wondered why we bother to even keep the asm constrains as something different than a char *. 

Richard. 

>
>	Jakub

  reply	other threads:[~2019-09-01 12:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 12:04 Jakub Jelinek
2019-08-31 15:42 ` Richard Biener
2019-09-01 11:55   ` Jakub Jelinek
2019-09-01 12:30     ` Richard Biener [this message]
2019-09-01 16:28       ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58A31C6E-354F-4D7A-82D3-8165B50BBBE9@gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).