From: Michael Eager <eager@eagercon.com>
To: Jakub Jelinek <jakub@redhat.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/6] microblaze: Fixes for RTL checking
Date: Tue, 21 Feb 2017 20:37:00 -0000 [thread overview]
Message-ID: <58ACA485.4030105@eagercon.com> (raw)
In-Reply-To: <20170221201555.GW1849@tucnak>
On 02/21/2017 12:15 PM, Jakub Jelinek wrote:
> On Tue, Feb 21, 2017 at 02:48:15PM +0000, Segher Boessenkool wrote:
>> - /* Shift by zero -- copy regs if necessary. */
>> + /* Shift by zero -- copy regs. */
>> if ((GET_CODE (operands[2]) == CONST_INT) && (INTVAL (operands[2]) == 0))
>
> You could have changed this line to
> if (operands[2] == const0_rtx)
> as well.
And this would not change the generated code.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2017-02-21 20:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 14:48 [PATCH 0/6] Fallout from " Segher Boessenkool
2017-02-21 14:48 ` [PATCH 2/6] cris: Fix for " Segher Boessenkool
2017-02-21 15:03 ` Hans-Peter Nilsson
2017-02-21 14:49 ` [PATCH 6/6] sh: Fixes " Segher Boessenkool
2017-02-21 15:49 ` Oleg Endo
2017-02-21 16:32 ` Segher Boessenkool
2017-02-21 14:49 ` [PATCH 3/6] microblaze: " Segher Boessenkool
2017-02-21 19:28 ` Jeff Law
2017-02-21 20:11 ` Michael Eager
2017-02-21 20:33 ` Segher Boessenkool
2017-02-21 21:07 ` Michael Eager
2017-02-24 23:12 ` Segher Boessenkool
2017-02-21 20:19 ` Jakub Jelinek
2017-02-21 20:37 ` Michael Eager [this message]
2017-02-21 20:41 ` Jakub Jelinek
2017-02-21 21:23 ` Segher Boessenkool
2017-02-21 14:49 ` [PATCH 1/6] c6x: Fix " Segher Boessenkool
2017-02-21 15:09 ` Bernd Schmidt
2017-02-21 14:49 ` [PATCH 4/6] nios2: Fixes " Segher Boessenkool
2017-02-21 19:33 ` Jeff Law
2017-02-21 19:53 ` Sandra Loosemore
2017-02-24 22:45 ` Sandra Loosemore
2017-02-21 15:01 ` [PATCH 5/6] pa: " Segher Boessenkool
2017-02-21 19:12 ` Jeff Law
2017-02-21 15:16 ` [PATCH] arc: " Segher Boessenkool
2017-02-21 19:27 ` Jeff Law
2017-02-24 19:20 ` Claudiu Zissulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ACA485.4030105@eagercon.com \
--to=eager@eagercon.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).