From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30160 invoked by alias); 21 Feb 2017 20:35:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30129 invoked by uid 89); 21 Feb 2017 20:35:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Alto, palo, Palo, Park X-HELO: homiemail-a46.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a46.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Feb 2017 20:35:22 +0000 Received: from homiemail-a46.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a46.g.dreamhost.com (Postfix) with ESMTP id 91EB55A0E; Tue, 21 Feb 2017 12:35:18 -0800 (PST) Received: from vm-fedora21.eagercon.com (c-71-202-23-94.hsd1.ca.comcast.net [71.202.23.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a46.g.dreamhost.com (Postfix) with ESMTPSA id 608DC5A0B; Tue, 21 Feb 2017 12:35:18 -0800 (PST) Subject: Re: [PATCH 3/6] microblaze: Fixes for RTL checking To: Jakub Jelinek , Segher Boessenkool References: <0b3332af5c3662c0efdf2d930c06457b0fd3cd13.1487685472.git.segher@kernel.crashing.org> <20170221201555.GW1849@tucnak> Cc: gcc-patches@gcc.gnu.org From: Michael Eager Message-ID: <58ACA485.4030105@eagercon.com> Date: Tue, 21 Feb 2017 20:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20170221201555.GW1849@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg01349.txt.bz2 On 02/21/2017 12:15 PM, Jakub Jelinek wrote: > On Tue, Feb 21, 2017 at 02:48:15PM +0000, Segher Boessenkool wrote: >> - /* Shift by zero -- copy regs if necessary. */ >> + /* Shift by zero -- copy regs. */ >> if ((GET_CODE (operands[2]) == CONST_INT) && (INTVAL (operands[2]) == 0)) > > You could have changed this line to > if (operands[2] == const0_rtx) > as well. And this would not change the generated code. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077