From: IainS <developer@sandoe-acoustics.co.uk>
To: Jack Howarth <howarth@bromo.med.uc.edu>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH]: Pass -no_pie on SYSTEMSPEC for darwin11
Date: Sat, 18 Jun 2011 08:57:00 -0000 [thread overview]
Message-ID: <58DBE07A-B575-49A7-9C00-9B080F9946FF@sandoe-acoustics.co.uk> (raw)
In-Reply-To: <20110618025723.GA29567@bromo.med.uc.edu>
Hi Jack,
On 18 Jun 2011, at 03:57, Jack Howarth wrote:
> On Fri, Jun 17, 2011 at 12:04:34PM +0100, IainS wrote:
>> Hi Jack,
>> ===
>> ****
>> kludge to suppress pie for for dylibs (use in place of the darwin9.h
>> hunk from the attachment on PR49371).
>
> Iain,
> This change should be unncessary since -pie on the linker only
> operates
> on executables (hence the name PIE).
On darwin < 11 .. which don't default to linking pie:
As stated, it's a kludge to allow fpie to be put as a test-suite
option...
... since the options are passed verbatim to library builds, all the
dylib builds fail otherwise ...
if there is an alternate way of filtering 'fpie/fPIE' out of dylib
builds, that could be more globally applied the to the test suite,
that would be a good fix to make.
(the kludge is expedient to test the hypothesis that pie works with
libjava on darwin 9 & 10 -- FAOD: I am not suggesting it for trunk)...
Iain
>> Index: gcc/config/darwin9.h
>> ===================================================================
>> --- gcc/config/darwin9.h (revision 175110)
>> +++ gcc/config/darwin9.h (working copy)
>> @@ -35,6 +35,12 @@ along with GCC; see the file COPYING3. If not see
>> /* Tell collect2 to run dsymutil for us as necessary. */
>> #define COLLECT_RUN_DSYMUTIL 1
>>
>> +#undef PIE_SPEC
>> +#define PIE_SPEC \
>> + "%{fpie|pie|fPIE: %{!Zdynamiclib: \
>> + %{mdynamic-no-pic: %n'-mdynamic-no-pic' overrides '-pie', '-
>> fpie'
>> or '-fPIE'; \
>> + :-pie}}}"
>> +
>> #undef ASM_OUTPUT_ALIGNED_COMMON
>> #define ASM_OUTPUT_ALIGNED_COMMON(FILE, NAME, SIZE,
>> ALIGN) \
>> do
>> { \
next prev parent reply other threads:[~2011-06-18 7:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 4:32 Jack Howarth
2011-06-17 11:21 ` IainS
2011-06-17 13:57 ` Jack Howarth
2011-06-17 15:34 ` Jack Howarth
2011-06-17 15:55 ` Jack Howarth
2011-06-18 5:54 ` Jack Howarth
2011-06-18 8:57 ` IainS [this message]
2011-06-17 17:49 ` Mike Stump
2011-06-17 20:10 ` Jack Howarth
2011-06-18 8:32 ` IainS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DBE07A-B575-49A7-9C00-9B080F9946FF@sandoe-acoustics.co.uk \
--to=developer@sandoe-acoustics.co.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=howarth@bromo.med.uc.edu \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).