From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1740 invoked by alias); 10 Apr 2017 14:01:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1304 invoked by uid 89); 10 Apr 2017 14:01:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=states X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 14:01:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47B03344; Mon, 10 Apr 2017 07:01:42 -0700 (PDT) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6150B3F575; Mon, 10 Apr 2017 07:01:41 -0700 (PDT) Message-ID: <58EB9043.8060104@foss.arm.com> Date: Mon, 10 Apr 2017 14:01:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Prakhar Bahuguna , gcc-patches@gcc.gnu.org CC: nd@arm.com, Richard.Earnshaw@arm.com, Ramana.Radhakrishnan@arm.com Subject: Re: [PATCH, GCC/ARM, Stage 1] Rename FPSCR builtins to correct names References: <20170322104630.z7g7nk6sv2xdzhad@e107464-lin.cambridge.arm.com> In-Reply-To: <20170322104630.z7g7nk6sv2xdzhad@e107464-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00449.txt.bz2 Hi Prakhar, Sorry for the delay, On 22/03/17 10:46, Prakhar Bahuguna wrote: > The GCC documentation in section 6.60.8 ARM Floating Point Status and Control > Intrinsics states that the FPSCR register can be read and written to using the > intrinsics __builtin_arm_get_fpscr and __builtin_arm_set_fpscr. However, these > are misnamed within GCC itself and these intrinsic names are not recognised. > This patch corrects the intrinsic names to match the documentation, and adds > tests to verify these intrinsics generate the correct instructions. > > Testing done: Ran regression tests on arm-none-eabi for Cortex-M4. > > 2017-03-09 Prakhar Bahuguna > > gcc/ChangeLog: > > * gcc/config/arm/arm-builtins.c (arm_init_builtins): Rename > __builtin_arm_ldfscr to __builtin_arm_get_fpscr, and rename > __builtin_arm_stfscr to __builtin_arm_set_fpscr. > * gcc/testsuite/gcc.target/arm/fpscr.c: New file. > > Okay for stage 1? I see that the mistake was in not addressing one of the review comments in: https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01832.html properly in the patch that added these functions :( This is ok for stage 1 if a bootstrap and test on arm-none-linux-gnueabihf works fine I don't think we want to maintain the __builtin_arm_[ld,st]fscr names for backwards compatibility as they were not documented and are __builtin_arm* functions that we don't guarantee to maintain. Thanks, Kyrill > -- > > Prakhar Bahuguna