From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-451917-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 129404 invoked by alias); 24 Apr 2017 09:38:03 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 129356 invoked by uid 89); 24 Apr 2017 09:38:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Apr 2017 09:37:59 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86E252B;	Mon, 24 Apr 2017 02:37:59 -0700 (PDT)
Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCBBC3F23B;	Mon, 24 Apr 2017 02:37:58 -0700 (PDT)
Message-ID: <58FDC775.4080003@foss.arm.com>
Date: Mon, 24 Apr 2017 09:40:00 -0000
From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: GCC Patches <gcc-patches@gcc.gnu.org>
CC: Marcus Shawcroft <marcus.shawcroft@arm.com>,  Richard Earnshaw <Richard.Earnshaw@arm.com>, James Greenhalgh <james.greenhalgh@arm.com>
Subject: Re: [PATCH][AArch64] Allow const0_rtx operand for atomic compare-exchange patterns
References: <58B56D3E.3090704@foss.arm.com>
In-Reply-To: <58B56D3E.3090704@foss.arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-04/txt/msg01016.txt.bz2

Pinging this back into context so that I don't forget about it...

https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01648.html

Thanks,
Kyrill

On 28/02/17 12:29, Kyrill Tkachov wrote:
> Hi all,
>
> For the testcase in this patch we currently generate:
> foo:
>         mov     w1, 0
>         ldaxr   w2, [x0]
>         cmp     w2, 3
>         bne     .L2
>         stxr    w3, w1, [x0]
>         cmp     w3, 0
> .L2:
>         cset    w0, eq
>         ret
>
> Note that the STXR could have been storing the WZR register instead of moving zero into w1.
> This is due to overly strict predicates and constraints in the store exclusive pattern and the
> atomic compare exchange expanders and splitters.
> This simple patch fixes that in the patterns concerned and with it we can generate:
> foo:
>         ldaxr   w1, [x0]
>         cmp     w1, 3
>         bne     .L2
>         stxr    w2, wzr, [x0]
>         cmp     w2, 0
> .L2:
>         cset    w0, eq
>         ret
>
>
> Bootstrapped and tested on aarch64-none-linux-gnu.
> Ok for GCC 8?
>
> Thanks,
> Kyrill
>
> 2017-02-28  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>     * config/aarch64/atomics.md (atomic_compare_and_swap<mode> expander):
>     Use aarch64_reg_or_zero predicate for operand 4.
>     (aarch64_compare_and_swap<mode> define_insn_and_split):
>     Use aarch64_reg_or_zero predicate for operand 3.  Add 'Z' constraint.
>     (aarch64_store_exclusive<mode>): Likewise for operand 2.
>
> 2017-02-28  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>     * gcc.target/aarch64/atomic_cmp_exchange_zero_reg_1.c: New test.