From: "Martin Liška" <mliska@suse.cz>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
binutils@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro
Date: Wed, 1 Apr 2020 09:41:09 +0200 [thread overview]
Message-ID: <58a785c1-08fc-a491-e19d-2b42e0a9817b@suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.21.2003301906260.2689954@eddie.linux-mips.org>
On 3/31/20 3:27 PM, Maciej W. Rozycki wrote:
> Correct an issue with GCC commit 906b3eb9df6c ("Improve endianess
> detection.") and fix a typo in the __BYTE_ORDER fallback macro check
> that causes compilation errors like:
>
> .../include/plugin-api.h:162:2: error: #error "Could not detect architecture endianess"
>
> on systems that do not provide the __BYTE_ORDER__ macro.
Hello.
Nice catch!
>
> include/
> PR lto/94249
> * plugin-api.h: Fix a typo in the __BYTE_ORDER macro check.
> ---
> On Tue, 24 Mar 2020, Martin Liška wrote:
>
>>>> +/* Detect endianess based on _BYTE_ORDER. */
>>>> +#if _BYTE_ORDER == _LITTLE_ENDIAN
>>>
>>> So most likely _BYTE_ORDER and _LITTLE_ENDIAN macros will not be defined.
>>> Which means this will be handled as #if 0 == 0 and override the
>>>> +#define PLUGIN_LITTLE_ENDIAN 1
>>>
>>> will define also PLUGIN_LITTLE_ENDIAN.
>>
>> Ok, for being sure, I've wrapped all equality comparison with corresponding
>> check of the LHS is defined.
>
> This change, when merged into binutils, caused BFD to fail building in
> one of my configurations:
>
> In file included from .../bfd/elflink.c:31:
> .../bfd/../include/plugin-api.h:162:2: error: #error "Could not detect architecture endianess"
> make[4]: *** [elflink.lo] Error 1
>
> This is due to a missing underscore in the:
>
> #ifdef _BYTE_ORDER
>
> check.
>
> OK to apply this hopefully obvious fix to GCC and then merge to binutils?
I've just installed the patch.
@H.J. Can you please pull it to bintuils?
>
> NB if posting as an attachment please try matching the message subject
> with the change heading as otherwise it takes a lot of effort to track the
> patch submission corresponding to a given commit.
I see your point, but note that sometimes a direction of a patch changes during
the mailing list discussion. And so that we end up with a commit message that
has a different name.
Anyway, thank you for your help.
Martin
>
> Maciej
> ---
> include/plugin-api.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> binutils-include-plugin-api-byte-order.diff
> Index: binutils/include/plugin-api.h
> ===================================================================
> --- binutils.orig/include/plugin-api.h
> +++ binutils/include/plugin-api.h
> @@ -51,7 +51,7 @@
> /* Older GCC releases (<4.6.0) can make detection from glibc macros. */
> #if defined(__GLIBC__) || defined(__GNU_LIBRARY__) || defined(__ANDROID__)
> #include <endian.h>
> -#ifdef _BYTE_ORDER
> +#ifdef __BYTE_ORDER
> #if __BYTE_ORDER == __LITTLE_ENDIAN
> #define PLUGIN_LITTLE_ENDIAN 1
> #elif __BYTE_ORDER == __BIG_ENDIAN
>
next prev parent reply other threads:[~2020-04-01 7:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 9:25 [PATCH] Check endianess detection Martin Liška
2020-03-23 9:43 ` Jakub Jelinek
2020-03-23 10:00 ` Martin Liška
2020-03-23 10:10 ` Jakub Jelinek
2020-03-23 10:28 ` Martin Liška
2020-03-23 10:35 ` Jakub Jelinek
2020-03-23 12:43 ` Martin Liška
2020-03-23 15:06 ` Martin Liška
2020-03-23 15:39 ` Richard Biener
2020-03-23 16:06 ` H.J. Lu
2020-03-23 17:17 ` Martin Liška
2020-03-23 17:40 ` H.J. Lu
2020-03-24 8:19 ` Martin Liška
2020-03-24 8:31 ` Jakub Jelinek
2020-03-24 8:49 ` Martin Liška
2020-03-24 9:18 ` Jakub Jelinek
2020-03-24 10:32 ` Martin Liška
2020-03-24 10:39 ` Jakub Jelinek
2020-03-31 13:27 ` [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro Maciej W. Rozycki
2020-04-01 5:01 ` Hans-Peter Nilsson
2020-04-01 7:43 ` Martin Liška
2020-04-01 23:57 ` Hans-Peter Nilsson
2020-04-01 7:17 ` Richard Biener
2020-04-01 7:41 ` Martin Liška [this message]
2020-04-01 9:55 ` Maciej W. Rozycki
2020-04-01 10:01 ` Martin Liška
2020-04-01 15:59 ` Maciej W. Rozycki
2020-04-01 16:54 ` Martin Liška
2020-04-01 17:28 ` Maciej W. Rozycki
2020-04-01 10:04 ` Maciej W. Rozycki
2020-04-01 10:09 ` Martin Liška
2020-03-23 15:16 ` [PATCH] Check endianess detection Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58a785c1-08fc-a491-e19d-2b42e0a9817b@suse.cz \
--to=mliska@suse.cz \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).