From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105875 invoked by alias); 7 Dec 2018 15:49:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105558 invoked by uid 89); 7 Dec 2018 15:48:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=measure, H*i:sk:axBJTbj, H*f:sk:axBJTbj, H*i:_cPkw4Up X-HELO: mail-qt1-f193.google.com Received: from mail-qt1-f193.google.com (HELO mail-qt1-f193.google.com) (209.85.160.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Dec 2018 15:48:52 +0000 Received: by mail-qt1-f193.google.com with SMTP id n21so4927290qtl.6 for ; Fri, 07 Dec 2018 07:48:48 -0800 (PST) Return-Path: Received: from [192.168.1.149] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id y2sm2547205qtb.88.2018.12.07.07.48.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 07:48:45 -0800 (PST) Subject: Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes To: Richard Biener Cc: Nick Clifton , Pedro Alves , Ian Lance Taylor , Jakub Jelinek , matz@gcc.gnu.org, sgayou@redhat.com, tom@tromey.com, GCC Patches , Binutils References: <87muprdko7.fsf@redhat.com> <20181130084211.GX12380@tucnak> <173817ca-0aa0-e1a2-6725-37e079ead545@redhat.com> <20181130140330.GA12380@tucnak> <460cb971-0e21-1e3e-4920-8b3ee7290cf7@redhat.com> <736e8303-b724-f96d-54f5-46bff99fa34d@redhat.com> <57d33aa7-4e37-a09c-4bdc-974b5f654d33@redhat.com> <2928eac9-9363-ddb8-21eb-df878d2d4837@redhat.com> From: Jason Merrill Message-ID: <58e3cfe9-bd33-b72d-3826-436c7b63f0d7@redhat.com> Date: Fri, 07 Dec 2018 15:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00473.txt.bz2 On 12/7/18 6:36 AM, Richard Biener wrote: > On Thu, Dec 6, 2018 at 10:22 PM Jason Merrill wrote: >> >> On Thu, Dec 6, 2018 at 11:14 AM Jason Merrill wrote: >>> >>> Looks good to me. Independently, do you see a reason not to disable the >>> old demangler entirely? >> >> Like so. Does anyone object to this? These mangling schemes haven't >> been relevant in decades. > > Why #ifdef the code? Just rip it out? I was thinking as an intermediate measure in case some user wanted it for some reason, but I'd be fine with that as well. Jason