From: Christophe Lyon <christophe.lyon@arm.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [testsuite][arm] Fix cmse-15.c expected output
Date: Thu, 29 Sep 2022 16:30:58 +0200 [thread overview]
Message-ID: <58f000c4-1e22-e3e3-8265-710bb393492f@arm.com> (raw)
In-Reply-To: <20220923084330.4131742-1-torbjorn.svensson@foss.st.com>
Hi Torbjörn,
On 9/23/22 10:43, Torbjörn SVENSSON via Gcc-patches wrote:
> The cmse-15.c testcase fails at -Os because ICF means that we
> generate
> secure3:
> b secure1
>
> which is OK, but does not match the currently expected
> secure3:
> ...
> bx r[0-3]
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/arm/cmse/cmse-15.c: Align with -Os improvements.
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/gcc.target/arm/cmse/cmse-15.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c
> index b0fefe561a1..5188f1d697f 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c
> @@ -144,6 +144,8 @@ int secure2 (s_bar_ptr s_bar_p)
> ** bx r[0-3]
> ** |
> ** blx r[0-3]
> +** |
> +** b secure1
> ** )
> ** ...
> */
Yes, that looks OK to me, similar to a patch I made some time ago to the
very same file, when ICF became smarter. It seems it is now able to
notice that
return (*s_bar_p) ();
in secure3 () is equivalent to the same call in secure1 ().
LGTM, but I'm not a maintainer.
Thanks,
Christophe
next prev parent reply other threads:[~2022-09-29 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 8:43 Torbjörn SVENSSON
2022-09-29 14:30 ` Christophe Lyon [this message]
2022-10-03 14:36 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58f000c4-1e22-e3e3-8265-710bb393492f@arm.com \
--to=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).