From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A9E37384B013 for ; Wed, 8 May 2024 06:48:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9E37384B013 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A9E37384B013 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715150918; cv=none; b=JpRUBIZzwEG4JTp7RiKlhJaDIZUHbFpSR0xopgOshLHgXoi5geKlmBJ8POtLzwsX128smQOhPlJzsA0Z+QJaBd1HoQZobqGeeuUfsGSvKQEn3Qu28sGJR/20yMcerok1tTYcPOUpf3LgB7sz9nPzt3TW4CPKEE1MS/QleLo4i/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715150918; c=relaxed/simple; bh=IQ4XI+xxGhFm4sO1SId5598BivhpV8N81yUC9jlP3ho=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=fO6sqICB1tK8v6sRA8OVRdSSCp1QN0EV4roUx+bnZ1zl6539mdXuVQfEI7Okdp6HTLAgFwF8Eq6nX6vDsvaevVDkXkiJ5O9A/H9ew2l/x1x0lLjB6QJRoVDH61RsHaqSQch/aojHstPYXw4RgtwYq66o/lNiIx7vtknnJfz0SLQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4485MLQm023732; Wed, 8 May 2024 06:48:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : to : cc : from : subject : content-type : content-transfer-encoding; s=pp1; bh=B+gfp7At2ei5+i/WJVx6/ejxrW5ZexncdGTWKF3YWGU=; b=tM+QJWwD8X5snNUDgZ5g2+9Y2THRdlw02GuvuDaGlM3fxju65aER/Yt+f+072EolOCp0 6r+XuG8fg77Y9ygnUpG6u5frLCWcThK72780HE9nZ6tZSisOpV1i0iJhDPDKhHZfTbyY 0ccNn5yEiuwBIgGYlvc5DZGx+m5fh/Iz0FCcEwxLAJfFjnZiei5Vjr8VUyZkUi6zUisu r38rb/qG+2PPROypn6dQo0Bdk3t1c6Pqjm/lIGAMVG/xSCJBN/1QfBYQ/fUJGZl3HPXG XDtXxPqQu+PopoxPGLlpUz3p7KdoEEaAISicvWCXqaqjx8dlBihLDDI7FwQpznh4n/AH tQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y02par75d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 May 2024 06:48:35 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4486mZDk024749; Wed, 8 May 2024 06:48:35 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y02par75a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 May 2024 06:48:35 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4484XshY009354; Wed, 8 May 2024 06:36:42 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xyshuk4k8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 May 2024 06:36:41 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4486ac4P52691200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 May 2024 06:36:40 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 599582004B; Wed, 8 May 2024 06:36:38 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B435720049; Wed, 8 May 2024 06:36:36 +0000 (GMT) Received: from [9.200.57.36] (unknown [9.200.57.36]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 8 May 2024 06:36:36 +0000 (GMT) Message-ID: <59115d84-bb26-0ff0-d3ad-8006c220e283@linux.ibm.com> Date: Wed, 8 May 2024 14:36:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: GCC Patches Cc: Segher Boessenkool , David Edelsohn , Peter Bergner From: "Kewen.Lin" Subject: [PATCH] testsuite, rs6000: Remove powerpc_popcntb_ok Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: GQXcucNkUyH-CYJGsusn_pmA-x27b7nj X-Proofpoint-GUID: KpVdKNoa5ZOzMqaa4xwvOWa9knu24cWA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-08_02,2024-05-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405080049 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TVD_SUBJ_WIPE_DEBT,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, There are three uses of effective target powerpc_popcntb_ok, they are all for compiling, but powerpc_popcntb_ok checks for executable generation, which is too heavy. This patch is to remove powerpc_popcntb_ok and adjust its three uses accordingly. Regtested on powerpc64-linux-gnu P8/P9 and powerpc64le-linux-gnu P9 and P10. I'm going to push this soon if no objections. BR, Kewen ----- gcc/testsuite/ChangeLog: * lib/target-supports.exp (check_effective_target_powerpc_popcntb_ok): Remove. * gcc.target/powerpc/cmpb-2.c: Adjust with dg-skip-if as powerpc_popcntb_ok gets removed. * gcc.target/powerpc/cmpb-3.c: Likewise. * gcc.target/powerpc/cmpb32-2.c: Likewise. --- gcc/testsuite/gcc.target/powerpc/cmpb-2.c | 3 ++- gcc/testsuite/gcc.target/powerpc/cmpb-3.c | 3 ++- gcc/testsuite/gcc.target/powerpc/cmpb32-2.c | 3 ++- gcc/testsuite/lib/target-supports.exp | 20 -------------------- 4 files changed, 6 insertions(+), 23 deletions(-) diff --git a/gcc/testsuite/gcc.target/powerpc/cmpb-2.c b/gcc/testsuite/gcc.target/powerpc/cmpb-2.c index 02b84d0731d..44a554bee4a 100644 --- a/gcc/testsuite/gcc.target/powerpc/cmpb-2.c +++ b/gcc/testsuite/gcc.target/powerpc/cmpb-2.c @@ -1,6 +1,7 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ +/* Skip powerpc*-*-darwin* powerpc-*-eabi as dropped popcntb_ok. */ +/* { dg-skip-if "" { powerpc*-*-darwin* powerpc-*-eabi } } */ /* { dg-require-effective-target lp64 } */ -/* { dg-require-effective-target powerpc_popcntb_ok } */ /* { dg-options "-mdejagnu-cpu=power5" } */ void abort (); diff --git a/gcc/testsuite/gcc.target/powerpc/cmpb-3.c b/gcc/testsuite/gcc.target/powerpc/cmpb-3.c index 75641bdb22c..43de37a571d 100644 --- a/gcc/testsuite/gcc.target/powerpc/cmpb-3.c +++ b/gcc/testsuite/gcc.target/powerpc/cmpb-3.c @@ -1,6 +1,7 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ +/* Skip powerpc*-*-darwin* powerpc-*-eabi as dropped popcntb_ok. */ +/* { dg-skip-if "" { powerpc*-*-darwin* powerpc-*-eabi } } */ /* { dg-require-effective-target ilp32 } */ -/* { dg-require-effective-target powerpc_popcntb_ok } */ /* { dg-options "-mdejagnu-cpu=power6" } */ void abort (); diff --git a/gcc/testsuite/gcc.target/powerpc/cmpb32-2.c b/gcc/testsuite/gcc.target/powerpc/cmpb32-2.c index d4264ab6e7d..0713c44fcff 100644 --- a/gcc/testsuite/gcc.target/powerpc/cmpb32-2.c +++ b/gcc/testsuite/gcc.target/powerpc/cmpb32-2.c @@ -1,5 +1,6 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ -/* { dg-require-effective-target powerpc_popcntb_ok } */ +/* Skip powerpc*-*-darwin* powerpc-*-eabi as dropped popcntb_ok. */ +/* { dg-skip-if "" { powerpc*-*-darwin* powerpc-*-eabi } } */ /* { dg-options "-mdejagnu-cpu=power5" } */ void abort (); diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 16dc2766850..5f34f02c387 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -3952,26 +3952,6 @@ proc check_effective_target_unsigned_char {} { }] } -proc check_effective_target_powerpc_popcntb_ok { } { - return [check_cached_effective_target powerpc_popcntb_ok { - - # Disable on Darwin. - if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] || [istarget *-*-darwin*]} { - expr 0 - } else { - check_runtime_nocache powerpc_popcntb_ok { - volatile int r; - volatile int a = 0x12345678; - int main() - { - asm volatile ("popcntb %0,%1" : "=r" (r) : "r" (a)); - return 0; - } - } "-mcpu=power5" - } - }] -} - # Return 1 if the target supports executing DFP hardware instructions, # 0 otherwise. Cache the result. -- 2.39.1