From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84367 invoked by alias); 26 Jun 2017 09:13:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84034 invoked by uid 89); 26 Jun 2017 09:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=multilib, cell X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 09:13:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACD9280D; Mon, 26 Jun 2017 02:13:23 -0700 (PDT) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A7843F581; Mon, 26 Jun 2017 02:13:22 -0700 (PDT) Message-ID: <5950D031.60500@foss.arm.com> Date: Mon, 26 Jun 2017 09:13:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christophe Lyon , "gcc-patches@gcc.gnu.org" Subject: Re: [Patch, ARM, testsuite] Add -mfloat-abi=hard to arm_neon_ok References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg01890.txt.bz2 Hi Christophe, On 07/06/17 10:13, Christophe Lyon wrote: > Hi, > > > On 2 June 2017 at 16:19, Christophe Lyon wrote: >> Hi, >> >> I have recently updated the dejagnu version I use for >> cross-testing arm and aarch64 toolchains to 1.6+. One of the side >> effects was mentioned by Jonathan in >> https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01267.html. Since I >> use multilibs to test many configurations, I noticed several >> changes in the results I get. >> >> In particular, on arm-none-linux-gnueabihf with -march=armv5t, >> all the tests that require arm_neon_ok fail to compile because >> they now use -march=armv5t -mfpu=neon -mfloat-abi=softfp >> -march=armv7-a, which leads to a failure to include >> gnu/stubs-soft.h (not present since the target is >> 'hf'). Previously, -march=armv5t was appended, making the tests >> unsupported because -mfpu=neon conflicts with -march=armv5t. Now, >> arm_neon_ok succeeds because it only checks if some preprocessor >> defines are present. >> >> This patch fixes that by including arm_neon.h in arm_neon_ok, such >> that it fails for unsupported cases. However, since most of these >> tests should pass instead of becoming unsupported, I have added flag >> combinations with -mfloat-abi=hard. >> >> However, this is not sufficient to make the >> gcc.target/arm/lto/pr65837* tests pass: they do not require >> arm_neon_ok, and when I tried to add it, they still failed >> because these lto tests do not support dg-add-options. My >> proposal is to add a new >> check_effective_target_arm_neon_ok_no_float_abi function which >> tries to use neon without trying to change the -mfloat-abi >> setting (that is, the same as arm_neon_ok, with only "" >> and "-mfpu=neon" in the list of flags) . This makes these two lto >> tests unsupported for non-hf targets (again because >> gnu/stubs-soft.h is not present). >> >> To make them pass on "hf" targets: >> - I added -mfpu=neon to dg-lto-options in pr65837-attr_0.c, >> because the fpu attributes in arm_neon.h only work if >> -mfpu=neon is enabled >> - I removed dg-suppress-ld-options {-mfpu=neon} from pr65837_0.c, >> -mfpu=neon is needed for the test to compile with toolchains >> where the default fpu is not neon (eg vfpv3-d16-fp16) >> >> On arm-none-linux-gnueabihf --with-cpu=cortex-a9 --with-fpu=vfp >> and multilib test flag=-march=armv5t, this patch brings: >> - 2 UNRESOLVED -> FAIL (gcc.dg/vect/vect-align-1.c) >> - 14 UNRESOLVED -> XPASS (in gcc.dg/vect/) >> - 2765 new PASS >> - 3639 FAIL -> PASS >> - 1826 UNRESOLVED -> PASS >> - 102 UNRESOLVED -> XFAIL >> >> as visible in the red cell at >> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/248552-gnu-stubs9.patch/report-build-info.html >> (the build-failed line can be ignored, it was caused by a server >> problem) >> >> Sorry, the explanation is almost longer than the patch :-) >> >> Is it OK for trunk? >> (Just realizing that I forgot to document the new functions :( ) >> > Here is an updated version with a bit of documentation for the new > effective target. > arm_neon_ok_no_float_abi now only tries to add -mfpu=neon, not "" > since we always > add -mfpu=neon in the lto tests anyway. > > OK? > This is ok. Sorry for the delay. Kyrill >> Thanks, >> >> Christophe