* [PATCH, GCC/ARM, gcc-5-branch] Fix gcc.target/arm/fpscr.c
@ 2017-06-26 11:32 Thomas Preudhomme
2017-06-28 11:35 ` [PATCH, GCC/ARM, gcc-5-branch, ping] " Thomas Preudhomme
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Preudhomme @ 2017-06-26 11:32 UTC (permalink / raw)
To: Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
Hi,
As raised by Christophe Lyon, fpscr.c FAILs because arm_fp_ok and arm_fp
are not defined in GCC 5. This commit changes the test to use the same
recipe as gcc.target/arm/cmp-2.c
ChangeLog entry is as follows:
*** gcc/testsuite/ChangeLog ***
2017-06-26 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gcc.target/arm/fpscr.c: Require arm_vfp_ok instead of arm_fp_ok and
add -mfpu=vfp -mfloat-abi=softfp instead of fp_ok options.
Ok for GCC 5?
Best regards,
Thomas
[-- Attachment #2: fix_fpscr_testcase_gcc5.patch --]
[-- Type: text/x-patch, Size: 640 bytes --]
diff --git a/gcc/testsuite/gcc.target/arm/fpscr.c b/gcc/testsuite/gcc.target/arm/fpscr.c
index 7b4d71d72d8964f6da0d0604bf59aeb4a895df43..cafba4e8d67545bd210477230b9682fe86620e23 100644
--- a/gcc/testsuite/gcc.target/arm/fpscr.c
+++ b/gcc/testsuite/gcc.target/arm/fpscr.c
@@ -1,9 +1,9 @@
/* Test the fpscr builtins. */
/* { dg-do compile } */
-/* { dg-require-effective-target arm_fp_ok } */
+/* { dg-require-effective-target arm_vfp_ok } */
/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
-/* { dg-add-options arm_fp } */
+/* { dg-options "-mfpu=vfp -mfloat-abi=softfp" } */
void
test_fpscr ()
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, GCC/ARM, gcc-5-branch, ping] Fix gcc.target/arm/fpscr.c
2017-06-26 11:32 [PATCH, GCC/ARM, gcc-5-branch] Fix gcc.target/arm/fpscr.c Thomas Preudhomme
@ 2017-06-28 11:35 ` Thomas Preudhomme
2017-06-30 15:41 ` [PATCH, GCC/ARM, gcc-5-branch, ping2] " Thomas Preudhomme
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Preudhomme @ 2017-06-28 11:35 UTC (permalink / raw)
To: Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
Ping?
Best regards,
Thomas
On 26/06/17 12:32, Thomas Preudhomme wrote:
> Hi,
>
> As raised by Christophe Lyon, fpscr.c FAILs because arm_fp_ok and arm_fp
> are not defined in GCC 5. This commit changes the test to use the same
> recipe as gcc.target/arm/cmp-2.c
>
> ChangeLog entry is as follows:
>
>
> *** gcc/testsuite/ChangeLog ***
>
> 2017-06-26 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * gcc.target/arm/fpscr.c: Require arm_vfp_ok instead of arm_fp_ok and
> add -mfpu=vfp -mfloat-abi=softfp instead of fp_ok options.
>
>
> Ok for GCC 5?
>
> Best regards,
>
> Thomas
[-- Attachment #2: fix_fpscr_testcase_gcc5.patch --]
[-- Type: text/x-patch, Size: 640 bytes --]
diff --git a/gcc/testsuite/gcc.target/arm/fpscr.c b/gcc/testsuite/gcc.target/arm/fpscr.c
index 7b4d71d72d8964f6da0d0604bf59aeb4a895df43..cafba4e8d67545bd210477230b9682fe86620e23 100644
--- a/gcc/testsuite/gcc.target/arm/fpscr.c
+++ b/gcc/testsuite/gcc.target/arm/fpscr.c
@@ -1,9 +1,9 @@
/* Test the fpscr builtins. */
/* { dg-do compile } */
-/* { dg-require-effective-target arm_fp_ok } */
+/* { dg-require-effective-target arm_vfp_ok } */
/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
-/* { dg-add-options arm_fp } */
+/* { dg-options "-mfpu=vfp -mfloat-abi=softfp" } */
void
test_fpscr ()
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, GCC/ARM, gcc-5-branch, ping2] Fix gcc.target/arm/fpscr.c
2017-06-28 11:35 ` [PATCH, GCC/ARM, gcc-5-branch, ping] " Thomas Preudhomme
@ 2017-06-30 15:41 ` Thomas Preudhomme
2017-06-30 15:42 ` Kyrill Tkachov
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Preudhomme @ 2017-06-30 15:41 UTC (permalink / raw)
To: Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
Ping?
Best regards,
Thomas
On 28/06/17 12:35, Thomas Preudhomme wrote:
> Ping?
>
> Best regards,
>
> Thomas
>
> On 26/06/17 12:32, Thomas Preudhomme wrote:
>> Hi,
>>
>> As raised by Christophe Lyon, fpscr.c FAILs because arm_fp_ok and arm_fp
>> are not defined in GCC 5. This commit changes the test to use the same
>> recipe as gcc.target/arm/cmp-2.c
>>
>> ChangeLog entry is as follows:
>>
>>
>> *** gcc/testsuite/ChangeLog ***
>>
>> 2017-06-26 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>
>> * gcc.target/arm/fpscr.c: Require arm_vfp_ok instead of arm_fp_ok and
>> add -mfpu=vfp -mfloat-abi=softfp instead of fp_ok options.
>>
>>
>> Ok for GCC 5?
>>
>> Best regards,
>>
>> Thomas
[-- Attachment #2: fix_fpscr_testcase_gcc5.patch --]
[-- Type: text/x-patch, Size: 640 bytes --]
diff --git a/gcc/testsuite/gcc.target/arm/fpscr.c b/gcc/testsuite/gcc.target/arm/fpscr.c
index 7b4d71d72d8964f6da0d0604bf59aeb4a895df43..cafba4e8d67545bd210477230b9682fe86620e23 100644
--- a/gcc/testsuite/gcc.target/arm/fpscr.c
+++ b/gcc/testsuite/gcc.target/arm/fpscr.c
@@ -1,9 +1,9 @@
/* Test the fpscr builtins. */
/* { dg-do compile } */
-/* { dg-require-effective-target arm_fp_ok } */
+/* { dg-require-effective-target arm_vfp_ok } */
/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
-/* { dg-add-options arm_fp } */
+/* { dg-options "-mfpu=vfp -mfloat-abi=softfp" } */
void
test_fpscr ()
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, GCC/ARM, gcc-5-branch, ping2] Fix gcc.target/arm/fpscr.c
2017-06-30 15:41 ` [PATCH, GCC/ARM, gcc-5-branch, ping2] " Thomas Preudhomme
@ 2017-06-30 15:42 ` Kyrill Tkachov
0 siblings, 0 replies; 4+ messages in thread
From: Kyrill Tkachov @ 2017-06-30 15:42 UTC (permalink / raw)
To: Thomas Preudhomme, Ramana Radhakrishnan, Richard Earnshaw, gcc-patches
On 30/06/17 16:41, Thomas Preudhomme wrote:
> Ping?
>
> Best regards,
>
> Thomas
>
> On 28/06/17 12:35, Thomas Preudhomme wrote:
>> Ping?
>>
>> Best regards,
>>
>> Thomas
>>
>> On 26/06/17 12:32, Thomas Preudhomme wrote:
>>> Hi,
>>>
>>> As raised by Christophe Lyon, fpscr.c FAILs because arm_fp_ok and arm_fp
>>> are not defined in GCC 5. This commit changes the test to use the same
>>> recipe as gcc.target/arm/cmp-2.c
>>>
>>> ChangeLog entry is as follows:
>>>
>>>
>>> *** gcc/testsuite/ChangeLog ***
>>>
>>> 2017-06-26 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> * gcc.target/arm/fpscr.c: Require arm_vfp_ok instead of arm_fp_ok and
>>> add -mfpu=vfp -mfloat-abi=softfp instead of fp_ok options.
>>>
>>>
>>> Ok for GCC 5?
>>>
Ok.
Thanks,
Kyrill
>>> Best regards,
>>>
>>> Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-30 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-26 11:32 [PATCH, GCC/ARM, gcc-5-branch] Fix gcc.target/arm/fpscr.c Thomas Preudhomme
2017-06-28 11:35 ` [PATCH, GCC/ARM, gcc-5-branch, ping] " Thomas Preudhomme
2017-06-30 15:41 ` [PATCH, GCC/ARM, gcc-5-branch, ping2] " Thomas Preudhomme
2017-06-30 15:42 ` Kyrill Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).