From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id A50E23858415 for ; Fri, 1 Dec 2023 15:08:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A50E23858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A50E23858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701443288; cv=none; b=V7TIUEEgFxCx8lvzzxwI0b0XurVzuZ7Ppk2yIsbS8Ow0E0pmGrdrUpPcP8Dv52lgOPJGYPswk0cYSp9/01nnRQndcaiBoZ1N3GeIeeREjJddbAtAONP1cKgOtMJbdZ9FjFJJoouOXiiRdiiss0ZM7v0S9n/E1S1BCUnrFCvcZu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701443288; c=relaxed/simple; bh=x242tbvmtNhE+x95dzoiyI3VmOTWzaQFpFypzL1thCA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dCHI7CFCOeoAv7MUwoUcyvIl8p02QITjThgjkqUAppImgZJT/6fQkeEuW6qg1Kd+WCccKOLHrekwr5bgEQOXJm0M3FOzR35YebZ7CmJJkCHVRBNa/qQryu2W+Nqjie5mm/hcGNLs6Vm6jWOP3G/dRi1BSQWDXPDSo1yroHeaD1M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d03fb57b69so5624185ad.1 for ; Fri, 01 Dec 2023 07:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701443285; x=1702048085; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EFQVPGtW1trn+wggVY254PbZOxhDZiWKztcH1G8VfP8=; b=SbGah1h8Aowly1mzIlDpBHaNPKiRZifGWtkebWlNJMPo6DeUPsz9J6bYpL6SqOiCJw wy68L74/MuYWIwbeM0xTfOLaB/UqedTzUGLMbT7esoooTmLLxuXxK3RjEkAie0+Zihc9 iXIvsCeYI36fS2eOzZxpf9IClMglAv+P8VMD+/47CTZRtOlRuWyIHWWmxeL7RdkbIl7h Ycjt2UjFvFyC74gZZm5JCgWlJdo7MHN+Yi+xTwk5lxiZYFxpyIkV6XDeErgulV7RzMpk 32Wyi5R9+RiQKTgxLmF1iXz2ZCI078sI1F9qrrXDJRh5HNtSKC7cjYAaemr1U9hHzlYo rlvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443285; x=1702048085; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EFQVPGtW1trn+wggVY254PbZOxhDZiWKztcH1G8VfP8=; b=oz1ymAOB8suhpQn7IFg4jW5Q3wjNPN2WC3T8j22YEKS1gNZfuOvhveogUCHBf3XXSj WnCUhU2wgBKIgfDSICzpKqw6p6r7deaVK60jm+zgxq+EsOJY26CxOZWAUEdAQmxW9uf/ zFpG3eBb0A49DmadkcvpiGp36ivZ+qVzWy6MQ4oHyDGEot+Te4Saz5CzsDiTHaRgfXIz 6aTm112RTLuaK6ibh0yeCUqGa/NC9+XK7YZiPE7S0JAvEvAxIS1V1lNU5BJ0SbRyfZLD qypogul3KduxnjbIO0Ulgzo04TUgY4NIK5qHXDSvd9hdARUZQZCT+Ky3aZn6VDxHVbq5 DKMQ== X-Gm-Message-State: AOJu0YyC5JdH/+fu4uXWkIWQEDdT1DXDsAi3UWtnW7DrdZ8swZrGDL9m zvBHULx5oxx4sDWcGahiAQRSwG3Ie2TSTw== X-Google-Smtp-Source: AGHT+IHJlr+SVl3MZPKuWaivtfviD1WljL4qn5CDjv7U+w1IJ3tSlcT+HUe6ycOKQfeEETw1yflDEw== X-Received: by 2002:a17:902:ee82:b0:1cf:96a0:e4eb with SMTP id a2-20020a170902ee8200b001cf96a0e4ebmr25125394pld.37.1701443285609; Fri, 01 Dec 2023 07:08:05 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id o16-20020a170902779000b001ce67fab3a2sm3402127pll.261.2023.12.01.07.08.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Dec 2023 07:08:05 -0800 (PST) Message-ID: <595dabd1-77cd-41ee-af4c-567350c54437@gmail.com> Date: Fri, 1 Dec 2023 08:07:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] extend.texi: Fix up defbuiltin* with spaces in return type Content-Language: en-US To: Jakub Jelinek , Gerald Pfeifer , Joseph Myers , Sandra Loosemore Cc: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/23 03:26, Jakub Jelinek wrote: > Hi! > > In https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#index-_005f_005fbuiltin_005fstdc_005fbit_005ffloor > I've noticed that while e.g. __builtin_stdc_bit_floor builtin is properly > rendered in bold and bigger size, for the __builtin_stdc_bit_width builtin > it is not the builtin name which is marked like that, but the keyword int > before it. Also, seems such builtins are missing from the index. > > I've read the texinfo docs and they seem to suggest in > https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Line-Macros.html > that return types of functions with spaces in the return type should be > wrapped with {}s and we already use that e.g. in > @defbuiltin{{void *} __builtin_thread_pointer (void)} > > The following patch adjusts builtins I found which contained one or two > spaces in the return type name (plus two spots which used 2 spaces after > single keyword return type instead of 1 which triggered my search regex as > well). > > Tested on x86_64-linux, ok for trunk? > > 2023-12-01 Jakub Jelinek > > * doc/extend.texi (__builtin_addc, __builtin_addcl, __builtin_addcll, > __builtin_subc, __builtin_subcl, __builtin_subcll, > __builtin_stdc_bit_width, __builtin_stdc_count_ones, > __builtin_stdc_count_zeros, __builtin_stdc_first_leading_one, > __builtin_stdc_first_leading_zero, __builtin_stdc_first_trailing_one, > __builtin_stdc_first_trailing_zero, __builtin_stdc_has_single_bit, > __builtin_stdc_leading_ones, __builtin_stdc_leading_zeros, > __builtin_stdc_trailing_ones, __builtin_stdc_trailing_zeros, > __builtin_nvptx_brev, __builtin_nvptx_brevll, __builtin_darn, > __builtin_darn_raw, __builtin_ia32_vec_ext_v2di, > __builtin_ia32_crc32qi, __builtin_ia32_crc32hi, > __builtin_ia32_crc32si, __builtin_ia32_crc32di): Put {}s around > return type with spaces in it. > (__builtin_rx_mvfachi, __builtin_rx_mvfacmi): Remove superfluous > whitespace. OK jeff