From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10739 invoked by alias); 11 Jul 2017 14:25:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10134 invoked by uid 89); 11 Jul 2017 14:25:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailout3.w1.samsung.com Received: from mailout3.w1.samsung.com (HELO mailout3.w1.samsung.com) (210.118.77.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Jul 2017 14:25:34 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OSX00LRXK2FVE80@mailout3.w1.samsung.com> for gcc-patches@gcc.gnu.org; Tue, 11 Jul 2017 15:25:27 +0100 (BST) Received: from eusmges3.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170711142526eucas1p21336626361bafe914c6c9029750e8b99~QTM7D2N830752007520eucas1p2b; Tue, 11 Jul 2017 14:25:26 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3.samsung.com (EUCPMTA) with SMTP id AC.EF.17464.6DFD4695; Tue, 11 Jul 2017 15:25:26 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170711142525eucas1p29da103eb639eeecb892026198879cb47~QTM6OvbEt0902509025eucas1p2_; Tue, 11 Jul 2017 14:25:25 +0000 (GMT) Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D9.0D.20206.5DFD4695; Tue, 11 Jul 2017 15:25:25 +0100 (BST) Received: from [106.109.129.18] by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OSX000M7K2DET90@eusync2.samsung.com>; Tue, 11 Jul 2017 15:25:25 +0100 (BST) Subject: =?UTF-8?Q?Re:_[PING^3][RFC=2c_PATCH][ASAN]_Implement_dynamic_alloca?= =?UTF-8?Q?s/VLAs_sanitization.=e2=80=8b?= To: Andreas Schwab Cc: GCC Patches , Jakub Jelinek , Marek Polacek , Yuri Gribov From: Maxim Ostapenko Message-id: <5964DFD2.9040501@samsung.com> Date: Tue, 11 Jul 2017 14:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: Content-type: multipart/mixed; boundary=------------010803090700020406000401 X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170711142525eucas1p29da103eb639eeecb892026198879cb47 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFrc2ltIE9zdGFwZW5rbxtTUlItU1cgVG9vbHMgTGFiGw==?= =?UTF-8?B?7IK87ISx7KCE7J6QG0VuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?TWF4aW0gT3N0YXBlbmtvG1NSUi1TVyBUb29scyBMYWIbU2Ft?= =?UTF-8?B?c3VuZ8KgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1Nw==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170517122413eucas1p12f3a6e4e478c7fc2fddf513d2e3ea199 X-RootMTR: 20170517122413eucas1p12f3a6e4e478c7fc2fddf513d2e3ea199 References: <591C40E9.7030307@samsung.com> <59365A82.2070806@samsung.com> <593FD67C.5040607@samsung.com> <87k23ihijg.fsf@linux-m68k.org> <596330E6.6070200@samsung.com> X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00528.txt.bz2 This is a multi-part message in MIME format. --------------010803090700020406000401 Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: 7bit Content-length: 1813 On 11/07/17 16:51, Andreas Schwab wrote: > On Jul 10 2017, Maxim Ostapenko wrote: > >> diff --git a/gcc/asan.c b/gcc/asan.c >> index 95004d7..89c2731 100644 >> --- a/gcc/asan.c >> +++ b/gcc/asan.c >> @@ -1567,9 +1567,10 @@ asan_emit_allocas_unpoison (rtx top, rtx bot, rtx_insn *before) >> else >> start_sequence (); >> rtx ret = init_one_libfunc ("__asan_allocas_unpoison"); >> + top = convert_memory_address (ptr_mode, top); >> + bot = convert_memory_address (ptr_mode, bot); >> ret = emit_library_call_value (ret, NULL_RTX, LCT_NORMAL, ptr_mode, 2, top, >> - TYPE_MODE (pointer_sized_int_node), bot, >> - TYPE_MODE (pointer_sized_int_node)); >> + ptr_mode, bot, ptr_mode); > There is another similar occurence: > > /opt/gcc/gcc-20170711/gcc/testsuite/gcc.dg/asan/pr80168.c:7:1: internal compiler error: in emit_library_call_value_1, at calls.c:4555 > 0x701577 emit_library_call_value_1 > ../../gcc/calls.c:4554 > 0x7068d7 emit_library_call_value(rtx_def*, rtx_def*, libcall_type, machine_mode, int, ...) > ../../gcc/calls.c:5159 > 0x6f2307 expand_asan_emit_allocas_unpoison > ../../gcc/builtins.c:4978 > 0x6f2307 expand_builtin(tree_node*, rtx_def*, rtx_def*, machine_mode, int) > ../../gcc/builtins.c:6787 > 0x81fa6f expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool) > ../../gcc/expr.c:10841 > 0x716517 expand_expr > ../../gcc/expr.h:276 > 0x716517 expand_call_stmt > ../../gcc/cfgexpand.c:2664 > 0x716517 expand_gimple_stmt_1 > ../../gcc/cfgexpand.c:3583 > 0x716517 expand_gimple_stmt > ../../gcc/cfgexpand.c:3749 > 0x719077 expand_gimple_basic_block > ../../gcc/cfgexpand.c:5753 > 0x71dfc7 execute > ../../gcc/cfgexpand.c:6360 Oh, I see. Does attached patch fix the issue? -Maxim > > Andreas. > --------------010803090700020406000401 Content-Type: text/x-diff; name="alloca-aarch64-ilp32-2.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="alloca-aarch64-ilp32-2.diff" Content-length: 1957 Z2NjL0NoYW5nZUxvZzoNCg0KMjAxNy0wNy0xMSAgTWF4aW0gT3N0YXBlbmtv ICA8bS5vc3RhcGVua29Ac2Ftc3VuZy5jb20+DQoNCgkqIGFzYW4uYyAoYXNh bl9lbWl0X2FsbG9jYXNfdW5wb2lzb24pOiBVc2UgcHRyX21vZGUgZm9yIGFy Z3VtZW50cw0KCWR1cmluZyBleHBhbnNpb24uDQoJKiBidWlsdGlucy5jIChl eHBhbmRfYXNhbl9lbWl0X2FsbG9jYXNfdW5wb2lzb24pOiBMaWtld2lzZS4N Cg0KZGlmZiAtLWdpdCBhL2djYy9hc2FuLmMgYi9nY2MvYXNhbi5jDQppbmRl eCA5NTAwNGQ3Li44OWMyNzMxIDEwMDY0NA0KLS0tIGEvZ2NjL2FzYW4uYw0K KysrIGIvZ2NjL2FzYW4uYw0KQEAgLTE1NjcsOSArMTU2NywxMCBAQCBhc2Fu X2VtaXRfYWxsb2Nhc191bnBvaXNvbiAocnR4IHRvcCwgcnR4IGJvdCwgcnR4 X2luc24gKmJlZm9yZSkNCiAgIGVsc2UNCiAgICAgc3RhcnRfc2VxdWVuY2Ug KCk7DQogICBydHggcmV0ID0gaW5pdF9vbmVfbGliZnVuYyAoIl9fYXNhbl9h bGxvY2FzX3VucG9pc29uIik7DQorICB0b3AgPSBjb252ZXJ0X21lbW9yeV9h ZGRyZXNzIChwdHJfbW9kZSwgdG9wKTsNCisgIGJvdCA9IGNvbnZlcnRfbWVt b3J5X2FkZHJlc3MgKHB0cl9tb2RlLCBib3QpOw0KICAgcmV0ID0gZW1pdF9s aWJyYXJ5X2NhbGxfdmFsdWUgKHJldCwgTlVMTF9SVFgsIExDVF9OT1JNQUws IHB0cl9tb2RlLCAyLCB0b3AsDQotCQkJCSBUWVBFX01PREUgKHBvaW50ZXJf c2l6ZWRfaW50X25vZGUpLCBib3QsDQotCQkJCSBUWVBFX01PREUgKHBvaW50 ZXJfc2l6ZWRfaW50X25vZGUpKTsNCisJCQkJIHB0cl9tb2RlLCBib3QsIHB0 cl9tb2RlKTsNCiANCiAgIGRvX3BlbmRpbmdfc3RhY2tfYWRqdXN0ICgpOw0K ICAgcnR4X2luc24gKmluc25zID0gZ2V0X2luc25zICgpOw0KZGlmZiAtLWdp dCBhL2djYy9idWlsdGlucy5jIGIvZ2NjL2J1aWx0aW5zLmMNCmluZGV4IDYw ODk5M2EuLjY0Mzc5NzkgMTAwNjQ0DQotLS0gYS9nY2MvYnVpbHRpbnMuYw0K KysrIGIvZ2NjL2J1aWx0aW5zLmMNCkBAIC00OTc2LDkgKzQ5NzYsNyBAQCBl eHBhbmRfYXNhbl9lbWl0X2FsbG9jYXNfdW5wb2lzb24gKHRyZWUgZXhwKQ0K IAkJCSBFWFBBTkRfTk9STUFMKTsNCiAgIHJ0eCByZXQgPSBpbml0X29uZV9s aWJmdW5jICgiX19hc2FuX2FsbG9jYXNfdW5wb2lzb24iKTsNCiAgIHJldCA9 IGVtaXRfbGlicmFyeV9jYWxsX3ZhbHVlIChyZXQsIE5VTExfUlRYLCBMQ1Rf Tk9STUFMLCBwdHJfbW9kZSwgMiwgdG9wLA0KLQkJCQkgVFlQRV9NT0RFIChw b2ludGVyX3NpemVkX2ludF9ub2RlKSwNCi0JCQkJIHZpcnR1YWxfc3RhY2tf ZHluYW1pY19ydHgsDQotCQkJCSBUWVBFX01PREUgKHBvaW50ZXJfc2l6ZWRf aW50X25vZGUpKTsNCisJCQkJIHB0cl9tb2RlLCB2aXJ0dWFsX3N0YWNrX2R5 bmFtaWNfcnR4LCBwdHJfbW9kZSk7DQogICByZXR1cm4gcmV0Ow0KIH0NCiAN Cg== --------------010803090700020406000401--