From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96258 invoked by alias); 15 Aug 2017 16:10:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96096 invoked by uid 89); 15 Aug 2017 16:09:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Sandra, sandra X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Aug 2017 16:09:43 +0000 Received: from svr-orw-mbx-04.mgc.mentorg.com ([147.34.90.204]) by relay1.mentorg.com with esmtp id 1dhePU-0000ff-Ea from Sandra_Loosemore@mentor.com ; Tue, 15 Aug 2017 09:09:40 -0700 Received: from [127.0.0.1] (147.34.91.1) by SVR-ORW-MBX-04.mgc.mentorg.com (147.34.90.204) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 15 Aug 2017 09:09:37 -0700 Subject: Re: [PATCH 2/7] [ARC] Use -G option to control sdata behavior To: Andrew Burgess , Claudiu Zissulescu References: <1500885779-12930-1-git-send-email-claziss@synopsys.com> <1500885779-12930-3-git-send-email-claziss@synopsys.com> <20170815133005.GC1465@embecosm.com> CC: , From: Sandra Loosemore Message-ID: <59931CC1.6060409@codesourcery.com> Date: Tue, 15 Aug 2017 16:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170815133005.GC1465@embecosm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) To SVR-ORW-MBX-04.mgc.mentorg.com (147.34.90.204) X-SW-Source: 2017-08/txt/msg00949.txt.bz2 On 08/15/2017 07:30 AM, Andrew Burgess wrote: > * Claudiu Zissulescu [2017-07-24 10:42:54 +0200]: > >> From: claziss >> >> Add support for -G option to ARC backend. >> >> gcc/ >> 2017-04-24 Claudiu Zissulescu >> >> * config.gcc: Use g.opt for arc. >> * config/arc/arc.c (LEGITIMATE_SCALED_ADDRESS_P): Deleted, >> functionality moved to ... >> (legitimate_scaled_address_p): New function, ...here. >> (LEGITIMATE_SMALL_DATA_OFFSET_P): New define. >> (LEGITIMATE_SMALL_DATA_ADDRESS_P): Use the above define. >> (legitimate_offset_address_p): Delete TARGET_NO_SDATA_SET >> condition. >> (arc_override_options): Handle G option. >> (arc_output_pic_addr_const): Correct function definition. >> (arc_legitimate_address_p): Use legitimate_scaled_address_p. >> (arc_decl_anon_ns_mem_p): Delete. >> (arc_in_small_data_p): Overhaul this function to take into >> consideration the value given via G option. >> (arc_rewrite_small_data_1): Renamed and corrected old >> arc_rewrite_small_data function. >> (arc_rewrite_small_data): New function. >> (small_data_pattern): Don't use pic_offset_table_rtx. >> * config/arc/arc.h (CC1_SPEC): Recognize G option. >> * config/arc/simdext.md (movmisalignv2hi): Use >> prepare_move_operands function. >> (mov*): Likewise. >> (movmisalign*): Likewise. >> >> gcc/testsuite/ >> 2017-04-24 Claudiu Zissulescu >> >> * gcc.target/arc/sdata-5.c: New test. >> * gcc.target/arc/arc700-stld-hazard.c: Update test options. > > From looking at other targets, I think that we need to add > documentation for -G into the ARC Options section of of > gcc/doc/invoke.texi. Yes. It would probably be better to treat -G as a target-independent option enabled by some target hook and consolidate the documentation as well, but since it's not done that way at present there needs to be an entry for -G in the ARC options table. -Sandra