From: Eric Botcazou <botcazou@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>,
Eric Botcazou <botcazou@adacore.com>,
richard.sandiford@arm.com
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] pro_and_epilogue: Call df_note_add_problem () if SHRINK_WRAPPING_ENABLED [PR112760]
Date: Sat, 02 Dec 2023 13:15:42 +0100 [thread overview]
Message-ID: <5994420.lOV4Wx5bFT@fomalhaut> (raw)
In-Reply-To: <mptbkb8c1cr.fsf@arm.com>
> So sorry to be awkward, but I don't think this is the way to go. I think
> we'll just end up playing whack-a-mole and adding df_note_add_problem to
> lots of passes.
We have doing that for the past 15 years though, so what has changed?
> (FTR, I'm not saying passes have to avoid false negatives, just false
> positives. If a pass updates an instruction with a REG_UNUSED note,
> and the pass is no longer sure whether the register is unused or not,
> the pass can just delete the note.)
Reintroducing the manual management of such notes would be a step backward.
--
Eric Botcazou
next prev parent reply other threads:[~2023-12-02 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 10:44 Jakub Jelinek
2023-12-02 11:04 ` Richard Sandiford
2023-12-02 12:15 ` Eric Botcazou [this message]
2023-12-02 13:15 ` Richard Sandiford
2023-12-02 19:30 ` Richard Biener
2023-12-02 22:45 ` Jakub Jelinek
2023-12-04 10:59 ` Richard Sandiford
2023-12-04 17:30 ` [PATCH] Maintain a validity flag for REG_UNUSED notes [PR112760] (was Re: [PATCH] pro_and_epilogue: Call df_note_add_problem () if SHRINK_WRAPPING_ENABLED [PR112760]) Richard Sandiford
2023-12-04 19:34 ` Jakub Jelinek
2023-12-04 2:56 ` [PATCH] pro_and_epilogue: Call df_note_add_problem () if SHRINK_WRAPPING_ENABLED [PR112760] Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5994420.lOV4Wx5bFT@fomalhaut \
--to=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).