From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 25F863858D28 for ; Sat, 6 May 2023 18:39:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25F863858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-518d325b8a2so2693349a12.0 for ; Sat, 06 May 2023 11:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683398345; x=1685990345; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q3ONEC5aozSwAUqaZysGC1rRnfItK7A0aaLmJ9/2GFo=; b=TZH9QX7Qs7P+ip90o/nyf4H8DcJlteZRC758WEt8/eS9XPI2FI6YxoFNV97zLf0Ayc SkA/LZp2CMugqSFegLE/6pvb3VS7upOLZqnMMcKG9PXW6ChVQz1fp1uqnnZfhHg6gVeh R/6QMmG6xT78RKqSnRwQKcWjDjaQV5ii/4wI2YBLoNRBspyEyUx3vi3ueQJncXBcWM22 qGWPXk72cTMifGG//D9Ci9hXrsIDPlti6uzrhoRzGzmXnwhWmhlqTyjm5N0ofMPGS/k9 VWnR5Di+conNkOe/dtIpy+28VtQyfCvh4R9Vifn3p/bnhmVn3mcrPhPg+PpyG28tc3YW 4yCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683398345; x=1685990345; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q3ONEC5aozSwAUqaZysGC1rRnfItK7A0aaLmJ9/2GFo=; b=e29Nf9brCn6QBqRPBzILYtXE8fLKYEECG9pal6pJ1ik7MgMSeaTSv6tVwukFC8nyco SxbByTfWq4BzpkJEqnTQMwsLSeU9YFnS85xg/HNoolRs5HSW4aQPzQHOfk3XRsAckmic 67cUdaXOfeuATXQZw8pNSor4OaJLp2Z0TmMlKut5Yilwdva0O4jJyoRm2khfSZ8Z9zY+ Jw00uKLTugno0ANJTt2XQq699SNjMosMIadQkYpY4DHE+yEzPwh85REhH6g2OjOaf4cx W4ikGOSBMU3gwamc+bG5wLlugFWUF3FLs35AZCRB53rHMSVW1NWSP1eHoNQSmqHwsy8B Srbw== X-Gm-Message-State: AC+VfDx5+2ljsIZhBWdG2ML0+8AeTnJ6l2XDWb5pW8OsHMf8HokR67GW 2sV5sXAXHEHiARiLLJ1DbYajqVWXulA= X-Google-Smtp-Source: ACHHUZ7VRYHk8SEF0fN9tRtzKa36Du9/wwxQmBM30DzS6Q1xFSOZYuMTULGnAh82HgazIeGWtp0vnQ== X-Received: by 2002:a17:903:280b:b0:1ab:15c2:e2e9 with SMTP id kp11-20020a170903280b00b001ab15c2e2e9mr5016665plb.7.1683398345030; Sat, 06 May 2023 11:39:05 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id r11-20020a170902c60b00b001a6a6169d45sm3980521plr.168.2023.05.06.11.39.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 11:39:04 -0700 (PDT) Message-ID: <5997eed7-451a-36f3-f183-5a348afb3214@gmail.com> Date: Sat, 6 May 2023 12:39:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v6 7/9] RISC-V: autovec: Verify that GET_MODE_NUNITS is a multiple of 2. Content-Language: en-US To: Michael Collison , gcc-patches@gcc.gnu.org References: <20230505154607.1155567-1-collison@rivosinc.com> <20230505154607.1155567-8-collison@rivosinc.com> From: Jeff Law In-Reply-To: <20230505154607.1155567-8-collison@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/5/23 09:46, Michael Collison wrote: > While working on autovectorizing for the RISCV port I encountered an issue > where can_duplicate_and_interleave_p assumes that GET_MODE_NUNITS is a > evenly divisible by two. The RISC-V target has vector modes (e.g. VNx1DImode), > where GET_MODE_NUNITS is equal to one. > > Tested on RISCV and x86_64-linux-gnu. Okay? > > 2023-03-09 Michael Collison > > * tree-vect-slp.cc (can_duplicate_and_interleave_p): > Check that GET_MODE_NUNITS is a multiple of 2. I've pushed this to the trunk given it was acked by Richard S and he explicitly indicated it need not wait for all the patches in this kit. jeff