From: Iain Sandoe <iain@sandoe.co.uk>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] testsuite, JIT, Darwin: Adjust asm tests for Mach-O.
Date: Wed, 18 Aug 2021 20:45:22 +0100 [thread overview]
Message-ID: <59A121F3-F675-4056-A66C-644BD917F24C@sandoe.co.uk> (raw)
Hi,
This provides adjusted assembler fragments that are suitable
for x86_64 Mach-O.
** as an aside, I wonder if it would be possible to configure some
conditional on __ELF__, __MACH__, and CPU arch to pull in some
object-cpu.inc so that we can generalize this for all hosts.
this version tested on x86_64-darwin, x86_64-linux,
OK for master?
thanks
Iain
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
gcc/testsuite/ChangeLog:
* jit.dg/test-asm.c: Provide Mach-O fragment.
* jit.dg/test-asm.cc: Likewise.
---
gcc/testsuite/jit.dg/test-asm.c | 13 +++++++++++++
gcc/testsuite/jit.dg/test-asm.cc | 12 ++++++++++++
2 files changed, 25 insertions(+)
diff --git a/gcc/testsuite/jit.dg/test-asm.c b/gcc/testsuite/jit.dg/test-asm.c
index 35a9f9d8605..43255dc7561 100644
--- a/gcc/testsuite/jit.dg/test-asm.c
+++ b/gcc/testsuite/jit.dg/test-asm.c
@@ -438,6 +438,18 @@ verify_code_4 (gcc_jit_context *ctxt, gcc_jit_result *result)
static void
create_test_i386_basic_asm_5 (gcc_jit_context *ctxt)
{
+#if __APPLE__
+ /* Darwin's assemblers do not support push/pop section, do not use .type
+ and external symbols should use __USER_LABEL_PREFIX__. */
+ gcc_jit_context_add_top_level_asm (ctxt, NULL,
+ "\t.text\n"
+ "\t.globl _add_asm\n"
+ "_add_asm:\n"
+ "\tmovq %rdi, %rax\n"
+ "\tadd %rsi, %rax\n"
+ "\tret\n"
+ "\t# some asm here\n");
+#else
/* Quote from here in docs/topics/asm.rst: example 5: jit. */
gcc_jit_context_add_top_level_asm (ctxt, NULL,
"\t.pushsection .text\n"
@@ -450,6 +462,7 @@ create_test_i386_basic_asm_5 (gcc_jit_context *ctxt)
"\t# some asm here\n"
"\t.popsection\n");
/* Quote up to here in docs/topics/asm.rst: example 5: jit. */
+#endif
}
static void
diff --git a/gcc/testsuite/jit.dg/test-asm.cc b/gcc/testsuite/jit.dg/test-asm.cc
index be487e3fb69..a3b45dacf07 100644
--- a/gcc/testsuite/jit.dg/test-asm.cc
+++ b/gcc/testsuite/jit.dg/test-asm.cc
@@ -400,6 +400,17 @@ static void
create_test_i386_basic_asm_5 (gcc_jit_context *c_ctxt)
{
gccjit::context ctxt (c_ctxt);
+#if __APPLE__
+ /* Darwin's assemblers do not support push/pop section, do not use .type
+ and external symbols should use __USER_LABEL_PREFIX__. */
+ ctxt.add_top_level_asm ("\t.text\n"
+ "\t.globl _add_asm\n"
+ "_add_asm:\n"
+ "\tmovq %rdi, %rax\n"
+ "\tadd %rsi, %rax\n"
+ "\tret\n"
+ "\t# some asm here\n");
+#else
/* Quote from here in docs/cp/topics/asm.rst: example 5: jit. */
ctxt.add_top_level_asm ("\t.pushsection .text\n"
"\t.globl add_asm\n"
@@ -411,6 +422,7 @@ create_test_i386_basic_asm_5 (gcc_jit_context *c_ctxt)
"\t# some asm here\n"
"\t.popsection\n");
/* Quote up to here in docs/cp/topics/asm.rst: example 5: jit. */
+#endif
}
static void
--
2.24.3 (Apple Git-128)
next reply other threads:[~2021-08-18 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 19:45 Iain Sandoe [this message]
2021-08-18 22:44 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A121F3-F675-4056-A66C-644BD917F24C@sandoe.co.uk \
--to=iain@sandoe.co.uk \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).