From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 455 invoked by alias); 13 Sep 2017 09:20:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 446 invoked by uid 89); 13 Sep 2017 09:20:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Best X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Sep 2017 09:20:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF40E1529; Wed, 13 Sep 2017 02:20:22 -0700 (PDT) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F19D3F483; Wed, 13 Sep 2017 02:20:21 -0700 (PDT) Message-ID: <59B8F854.8080202@foss.arm.com> Date: Wed, 13 Sep 2017 09:20:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Thomas Preudhomme , Ramana Radhakrishnan , Richard Earnshaw , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, GCC/testsuite/ARM, ping3] Fix coprocessor intrinsic test failures on ARMv8-A References: <4ab8c299-8b7e-6baf-d3ca-6021c0888ba8@foss.arm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00770.txt.bz2 On 05/09/17 10:04, Thomas Preudhomme wrote: > Ping? > > Best regards, > > Thomas > > On 23/08/17 11:59, Thomas Preudhomme wrote: >> Ping? >> >> Best regards, >> >> Thomas >> >> On 17/07/17 09:51, Thomas Preudhomme wrote: >>> Ping? >>> >>> Best regards, >>> >>> Thomas >>> >>> On 12/07/17 14:31, Thomas Preudhomme wrote: >>>> Coprocessor intrinsic tests in gcc.target/arm/acle test whether >>>> __ARM_FEATURE_COPROC has the right bit defined before calling the >>>> intrinsic. This allows to test both the correct setting of that macro >>>> and the availability and correct working of the intrinsic. However the >>>> __ARM_FEATURE_COPROC macro is no longer defined for ARMv8-A since >>>> r249399. >>>> >>>> This patch changes the testcases to skip that test for ARMv8-A and >>>> ARMv8-R targets. It also fixes some irregularity in the coprocessor >>>> effective targets: >>>> - add ldcl and stcl to the list of instructions listed as guarded by >>>> arm_coproc1_ok >>>> - enable tests guarded by arm_coproc2_ok, arm_coproc3_ok and >>>> arm_coproc4_ok for Thumb-2 capable targets but disable for Thumb-1 >>>> targets. >>>> Ok. Thanks, Kyrill >>>> ChangeLog entry is as follows: >>>> >>>> *** gcc/testsuite/ChangeLog *** >>>> >>>> 2017-07-04 Thomas Preud'homme >>>> >>>> * gcc.target/arm/acle/cdp.c: Skip __ARM_FEATURE_COPROC check for >>>> ARMv8-A and ARMv8-R. >>>> * gcc.target/arm/acle/cdp2.c: Likewise. >>>> * gcc.target/arm/acle/ldc.c: Likewise. >>>> * gcc.target/arm/acle/ldc2.c: Likewise. >>>> * gcc.target/arm/acle/ldc2l.c: Likewise. >>>> * gcc.target/arm/acle/ldcl.c: Likewise. >>>> * gcc.target/arm/acle/mcr.c: Likewise. >>>> * gcc.target/arm/acle/mcr2.c: Likewise. >>>> * gcc.target/arm/acle/mcrr.c: Likewise. >>>> * gcc.target/arm/acle/mcrr2.c: Likewise. >>>> * gcc.target/arm/acle/mrc.c: Likewise. >>>> * gcc.target/arm/acle/mrc2.c: Likewise. >>>> * gcc.target/arm/acle/mrrc.c: Likewise. >>>> * gcc.target/arm/acle/mrrc2.c: Likewise. >>>> * gcc.target/arm/acle/stc.c: Likewise. >>>> * gcc.target/arm/acle/stc2.c: Likewise. >>>> * gcc.target/arm/acle/stc2l.c: Likewise. >>>> * gcc.target/arm/acle/stcl.c: Likewise. >>>> * lib/target-supports.exp: >>>> (check_effective_target_arm_coproc1_ok_nocache): Mention ldcl >>>> and stcl in the comment. >>>> (check_effective_target_arm_coproc2_ok_nocache): Allow Thumb-2 >>>> targets >>>> and disable Thumb-1 targets. >>>> (check_effective_target_arm_coproc3_ok_nocache): Likewise. >>>> (check_effective_target_arm_coproc4_ok_nocache): Likewise. >>>> >>>> Tested by running all tests in gcc.target/arm/acle before and after >>>> this >>>> patch for ARMv6-M, ARMv7-M, ARMv7E-M, ARMv3, ARMv4 (ARM state), ARMv4T >>>> (Thumb state), ARMv5 (ARM state), ARMv5TE (ARM state), ARMv6 (ARM >>>> state), ARMv6T2 (Thumb state) and and ARMv8-A (both state). The only >>>> changes are for ARMv8-A where tests FAILing are now PASSing again. >>>> >>>> Is this ok for trunk? >>>> >>>> Best regards, >>>> >>>> Thomas