From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17717 invoked by alias); 20 Sep 2017 08:54:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17706 invoked by uid 89); 20 Sep 2017 08:54:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*UA:38.0, H*u:38.0, HContent-transfer-encoding:7bit, Hx-spam-relays-external:sk:2017092 X-HELO: mailout1.w1.samsung.com Received: from mailout1.w1.samsung.com (HELO mailout1.w1.samsung.com) (210.118.77.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 08:54:09 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20170920085404euoutp01461d11991b01dad748cf1e639b6fcfea~mBe3gLTO40496704967euoutp01f; Wed, 20 Sep 2017 08:54:04 +0000 (GMT) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170920085403eucas1p219428957ed7e75f1f4559795cb6f6861~mBe24L9CQ2368923689eucas1p2f; Wed, 20 Sep 2017 08:54:03 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges5.samsung.com (EUCPMTA) with SMTP id C7.14.12743.BAC22C95; Wed, 20 Sep 2017 09:54:03 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170920085403eucas1p1eb5ee91e12bec30ad8d62de74acf26a8~mBe2RxpMo2958229582eucas1p1x; Wed, 20 Sep 2017 08:54:03 +0000 (GMT) Received: from eusync4.samsung.com ( [203.254.199.214]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D5.A3.20118.BAC22C95; Wed, 20 Sep 2017 09:54:03 +0100 (BST) Received: from [106.109.129.18] by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OWK00I0HM22R370@eusync4.samsung.com>; Wed, 20 Sep 2017 09:54:03 +0100 (BST) Subject: Re: [PATCH][PR sanitizer/77631] Support separate debug info in libbacktrace To: Ian Lance Taylor , Denis Khalikov Cc: GCC Patches From: Maxim Ostapenko Message-id: <59C22CA7.8010307@samsung.com> Date: Wed, 20 Sep 2017 08:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit X-CMS-MailID: 20170920085403eucas1p1eb5ee91e12bec30ad8d62de74acf26a8 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFrc2ltIE9zdGFwZW5rbxtTUlItU1cgVG9vbHMgTGFiGw==?= =?UTF-8?B?7IK87ISx7KCE7J6QG0VuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?TWF4aW0gT3N0YXBlbmtvG1NSUi1TVyBUb29scyBMYWIbU2Ft?= =?UTF-8?B?c3VuZ8KgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1Nw==?= CMS-TYPE: 201P X-CMS-RootMailID: 20170616153942eucas1p1945271f893265484bbb3991a368bcd92 X-RootMTR: 20170616153942eucas1p1945271f893265484bbb3991a368bcd92 References: <2b505c8c-a836-6079-f744-3e9f8acf9356@partner.samsung.com> <9396366a-47ab-899c-cbcb-e79af1338869@partner.samsung.com> <9173486c-bb02-139e-30c6-d67879502df5@partner.samsung.com> X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg01330.txt.bz2 Hi Ian, On 12/09/17 17:05, Ian Lance Taylor via gcc-patches wrote: > On Mon, Sep 11, 2017 at 3:06 AM, Denis Khalikov > wrote: >> Thanks for answer. >> I understood all points which you mentioned, but can't >> find last one >>> It seems to work >>> out the file name a second time, even though the file name must >>> already be known. >> Can you please show me where I've missed that, if you have a time for that. > It's quite possible that I misunderstand the patch. I was looking at > the call to a copy of get_exec_filename in fileline_initialize. > >> Anyway, your patch works for me. > Thanks for testing. I will commit it later, probably today. As far as I can see, this patch wasn't committed to trunk so far. Did you meet some issues with current implementation? Do we need to perform more testing here? Thanks, -Maxim > > Ian > > >> On 09/11/2017 12:11 AM, Ian Lance Taylor wrote: >>> On Sat, Jul 29, 2017 at 1:42 PM, Denis Khalikov >>> wrote: >>>> >>>> Hello Ian, >>>> thanks for review. >>>> I've updated the patch, can you please take a look. >>> >>> Apologies again for the length of time it took to reply. I've had a >>> hard time understanding the patch. It's quite likely that I don't >>> understand how it works, but it seems to pass the same file descriptor >>> to process_elf_header twice. It seems to look for debug files with >>> the buildid in places where they will not be found. It seems to work >>> out the file name a second time, even though the file name must >>> already be known. I eventually just wrote my own implementation. >>> >>> Could you try this patch and see if it works for your cases? The >>> patch is against current mainline. Thanks. >>> >>> Ian >>> > >