From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: sellcey@cavium.com, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: nd@arm.com
Subject: Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64
Date: Mon, 02 Oct 2017 14:38:00 -0000 [thread overview]
Message-ID: <59D24F48.4060906@arm.com> (raw)
In-Reply-To: <1506716977.15649.41.camel@cavium.com>
On 29/09/17 21:29, Steve Ellcey wrote:
> On Thu, 2017-09-28 at 12:31 +0100, Szabolcs Nagy wrote:
>>
>> i think this should be improved, see below.
>
> Those were all good suggestions, here is a new patch that incorporates
> the changes. I fixed the IFUNC_OPTIONS argument,
> renamed ARCH_AARCH64_LINUX_LSE, got rid of the auxv references, and
> changed HWCAP_TYPE to IFUNC_RESOLVER_ARGS.
>
> Here is the new patch, tested with no regressions.
>
looks good to me, but i cannot approve.
(this will make libatomic depend on ifuncs on aarch64*-linux-gnu.)
> Steve Ellcey
> sellcey@cavium.com
>
>
> 2017-09-29 Steve Ellcey <sellcey@cavium.com>
>
> * Makefile.am (ARCH_AARCH64_LINUX): Add IFUNC_OPTIONS and
> libatomic_la_LIBADD.
> * config/linux/aarch64/host-config.h: New file.
> * configure.ac (IFUNC_RESOLVER_ARGS): Define.
> (ARCH_AARCH64_LINUX): New conditional for IFUNC builds.
> * configure.tgt (aarch64): Set ARCH and try_ifunc.
> (aarch64*-*-linux*) Update config_path.
> (aarch64*-*-linux*) Set IFUNC_RESOLVER_ARGS.
> * libatomic_i.h (GEN_SELECTOR): Add IFUNC_RESOLVER_ARGS argument.
> * Makefile.in: Regenerate.
> * auto-config.h.in: Regenerate.
> * configure: Regenerate.
>
next prev parent reply other threads:[~2017-10-02 14:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 20:44 Steve Ellcey
2017-08-07 20:46 ` Steve Ellcey
2017-08-25 4:56 ` Steve Ellcey
2017-08-25 16:43 ` Szabolcs Nagy
2017-08-28 18:40 ` Steve Ellcey
2017-08-29 11:42 ` Szabolcs Nagy
2017-08-30 18:39 ` Steve Ellcey
2017-08-31 18:55 ` Steve Ellcey
2017-09-27 20:35 ` Steve Ellcey
2017-09-28 11:31 ` Szabolcs Nagy
2017-09-29 20:29 ` Steve Ellcey
2017-10-02 14:38 ` Szabolcs Nagy [this message]
2017-10-03 18:57 ` Steve Ellcey
2017-10-24 18:17 ` Steve Ellcey
2017-11-20 18:27 ` Steve Ellcey
2017-11-20 18:29 ` James Greenhalgh
2017-11-20 19:50 ` Steve Ellcey
2017-11-21 17:36 ` James Greenhalgh
2017-11-29 8:09 ` Steve Ellcey
2017-12-05 0:51 ` Steve Ellcey
2017-12-07 9:56 ` James Greenhalgh
2017-12-07 15:58 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59D24F48.4060906@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=sellcey@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).