From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103133 invoked by alias); 2 Oct 2017 14:38:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102687 invoked by uid 89); 2 Oct 2017 14:38:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40040.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Oct 2017 14:38:07 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Received: from [10.2.206.69] (217.140.96.140) by DB6PR0802MB2486.eurprd08.prod.outlook.com (2603:10a6:4:a0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 2 Oct 2017 14:38:03 +0000 Message-ID: <59D24F48.4060906@arm.com> Date: Mon, 02 Oct 2017 14:38:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: sellcey@cavium.com, gcc-patches CC: nd@arm.com Subject: Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64 References: <1502138666.3962.95.camel@cavium.com> <59A03627.4060106@arm.com> <1503944731.28672.134.camel@cavium.com> <59A54F1C.3010806@arm.com> <1504200277.3182.22.camel@cavium.com> <59CCDD8A.9020703@arm.com> <1506716977.15649.41.camel@cavium.com> In-Reply-To: <1506716977.15649.41.camel@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR07CA0124.eurprd07.prod.outlook.com (2603:10a6:207:7::34) To DB6PR0802MB2486.eurprd08.prod.outlook.com (2603:10a6:4:a0::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30996c57-6e30-4f1f-8e96-08d509a3307c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6PR0802MB2486; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2486;3:1dk1yCctTb7L7J9qXmcaDY0UcRjDlmPXZDa7hHfyxiLk1x6EGoVunK7Px0aLtCDxt9Er9EOfV9Zlug9i/xytb3GMijwxtQP5WepFzp/YjZG1WOiIlSWK2YsRwiiqszPFlhOhzuZTaIbb09EiJ8Js0ZdKOCCFvWWEDTBxe7B5QlW9yxlU2HgqeiJJAmFaiXHsf0XHi5OkuwbsBM80elvEIvtu/a0GDVuVh97ly7JLJEG7s9vks5RRvL1pXSKbm+Ea;25:lbGwnorI/29hGC1dq9x+POnt1JE4S1u85MQrLkyyoT+OLj75dC5PVwmGR4c0PFZ4NDQyxa0/cm2xVsY0p5gBwQl5z+9VxjFLO3dsfiHRioqmJ/Z8PqzP86ObXuaYZAU75b06VoOH07LH/caI2Y6VfW9hTaC1zcth8gtF7OANg7bmecBX0E3t9GIE3IEbiz4SuF8NSV4U1Id5KIJkhCWHagTCcLUxaqg6irF6YRvRC0t6Toi2wA+ruTUJs/P9tRmlYaCQH2FXKtvV9R82RouS/jkPbsGzl0T+uNaolUgO3tIgQ+PhtZieAKatYn1jjxYMCyDXfCZMcA5yOh2Ome0XKg==;31:AtihTzgH/ScSkc8w8CmUBbRuOprRRyHa82olO3gzZO0o0lZy+cZQpF5iCwOgLp2UPak+GZy/WDoM2KvR419UPF3dkyxueiZvkeds2EV0bDEVgp/LAq7LcZBUkni4Y9+e0f0yaXBa9ekniNGjnaTUKEQq1EAfOBq0bJhJegO5Wsmk1TWLFgYTdG7J9Pn4BgS/7BTsGKbEo6JgXbSWDhZzCJQzefqz3XnPOnU7EWw3DzI= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2486: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2486;20:xo8svCBLzR/gCgDT06i6792RAxIjTrTEzXiTsvKLFgQX2+rJMDC6ujodHprHu8ZzH4zMKORgf5gjdwjPd/Cs5tjT4H3Is+AHKfs545wl6E7MVYcbfAhOiNs0Lr1GA/mmu4D6D2R6nXIWOHad2DPwbfzZx6aE7/MVZZtW1hh5wPo=;4:rTQyqvo2XMFJQ4Eoy+EbIGl9Z+N/W9mvtO6amDBmGpBUOXQBHgIplujVPfEcnvgNfvsQGqOlY49+39sB/gtJZLZ3ZVhVZzcsZzIqADDf7Fax4mWS9l5DQ/l9VKaWNep99fWkCT+hQro5C8w+wbDc65ZPQbomipKkjkHrnlCNkw68Tm/0yabrDvvycknBI3/tgw7ORoXQ410vo2siZSQ1QysMc0EKN3uBgKcMQbb9SeOSme8b7oLMkroPCol+dLIK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR0802MB2486;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR0802MB2486; X-Forefront-PRVS: 0448A97BF2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(199003)(189002)(377424004)(24454002)(3846002)(33656002)(64126003)(86362001)(6116002)(50466002)(25786009)(105586002)(101416001)(106356001)(80316001)(81156014)(8676002)(81166006)(65806001)(65956001)(66066001)(305945005)(47776003)(50986999)(87266999)(76176999)(54356999)(65816999)(6246003)(59896002)(53936002)(93886005)(77096006)(16576012)(68736007)(4326008)(23676002)(36756003)(8936002)(7736002)(316002)(6486002)(189998001)(2950100002)(72206003)(58126008)(16526017)(83506001)(6916009)(53546010)(5660300001)(97736004)(229853002)(230700001)(478600001)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2486;H:[10.2.206.69];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDJNQjI0ODY7MjM6dlNtODJwNVgxWnQ5TFB5dG1EZVFkRSt2?= =?utf-8?B?SzlIWFBacnQyVC9UVysvZGNWbTRhRDBZUWNSd3JqMXE0UWxoMmFIUlI1SlZR?= =?utf-8?B?eVk1OWtIYkFoZFlvUmE2K3J3Q1pGenlDZzRuUnh4UTBKSjFiMlN3WFJrMFZX?= =?utf-8?B?VUo3RUJpMnhjZ0Y3NTMySU9xV1B0ZzVLbzQwUGFHRFFvZnd5RTgzQWxkL1V0?= =?utf-8?B?OHpJTmE5RmZ1aVQwUHlwQ1VqbVZNU0ViaUlKdnFhWVJuY2FFejBWeDZPeHlO?= =?utf-8?B?aWxkOWY0enlLUlI1L1pPclJMMFhzUUF0eFB1UDJwS1NBR1ZQK2dVTE1DVHpS?= =?utf-8?B?ZTJrbDNBcDNsQnJ4UEZSVjRwemVxbVQrVUFTK01UOVNuY1FzTjhUNHZlNlRy?= =?utf-8?B?ZU0rVTdnQUJjM1NiYnFoZjBvSDZBMytkY2VkQmRQQWxTaHJKQ2M2cFFTUFlE?= =?utf-8?B?NTc3VS9uSVZIZ2paWFVIQ0NBSWVqWlNIUiswMjJra25ZVGRsNWxBV05PMEdB?= =?utf-8?B?ZDNrM3lndkFQc1ZJRWJaMzF4RHBaNUZnTWUzQmZYTUQ2MitNanBhRm9ma2M0?= =?utf-8?B?cGhTU1J2QzlxazV5anpaSzRxRlB3dnBzT25sUmFHK3VnZHdKdFg4cXBDUTBI?= =?utf-8?B?YjEyeEhQcEZnTVJRUTREdlZwcmxsNlVOTkJmTnZUa0Z5Yjd5b2w0dUlqRWZC?= =?utf-8?B?Q3dBUGR3SkQzcE9xN3BQM1BuQVpoem1SalVENHcvSU1IbGxFdUI0R2pRQTF4?= =?utf-8?B?QThZZW5ncURPak1ISWlIOUxUZ3RXL1hsZVczOEZ4WUc0VHM4QjF0VzVWL1hB?= =?utf-8?B?d1ZsVnJQcXJrcnB3bDVXMm5DYmFMd2pDV2hJa0FvVFE5Nk1aZTFPR0pSQ01j?= =?utf-8?B?dHFYQTF4WTdHRm1RcDBtV01wVW5TRDZGUVgrUUZpdUwzTDVOZTQyb2gvWlNY?= =?utf-8?B?MFlobjloN2htZHowNnV1dC9LWDRFTSs3L2ova3FUcmkxRFJobnFTdG5CdDNI?= =?utf-8?B?MTBmL2FFUytxSG1EQ2lLZUF4ak93KzZESUo4bUhZblRZZnBrLzViV0JzU1Rv?= =?utf-8?B?MTNjd2pkVG5KUnJoWmZZanVqYVRWUjZEMkxHeXZwR3NmaXJuTktjTjROcWl2?= =?utf-8?B?ZGFnWHQ2azNIMmhEcGhqeVlSNE1FM1hmNDN5NzdxbGpUVFk4N0ZWU1JDT0gy?= =?utf-8?B?NDJQeXl6TFl1bHlPQVFVRTZMV3Z1cE1WU2JnTVdNMGxOeFgvTXExWUxMTitC?= =?utf-8?B?eUxGUmYrL3hLZVBta29jZk0rdDRQNTBWV002Tys0Nzh0UWRZd3JVMm1TNWMw?= =?utf-8?B?SFdRSXBoZXE5aER5Y0lmOXFRandPZThGcktlQVkyVERSUW90Q3hxeFJ5d21r?= =?utf-8?B?cG0yR252ejNMNTd6d3MvakRpQ0JJMnpGYXZ1bll3aHFrMjdYVDFjUnAwcTRQ?= =?utf-8?B?VkFWZGVXVUZUM24vRjJUYStveVlMd3lLR3BxQ0F5ZDZnQjhwUVhkanJtUkgv?= =?utf-8?B?ZnJwV3RnTXVnSEo4L2RaUUNxNWNlcWZNVFgzR3VWTVlCVnZUQVJvTjdwdnRi?= =?utf-8?B?ZUVzVkJKSHJlK0ZCTXNqM3JQMW1EZ0JRN2ZPSGp6SUtYbjM3cExQMWZldDBq?= =?utf-8?B?ZlljREZqRkNxajVqY1hERjBIbE9JSEpsaS9VenYrUjdEOEJGTERhT1JKRnFk?= =?utf-8?B?TXk2azhOT08yeDc4R1FqQ0FYV3Bma1pud1NtK1Bxdmh1eUNNL0tKV3hiWkEw?= =?utf-8?B?N1R1c0NUbkRiNkRMb0FTYkxwTVRTdVViNGZtMVNMbWNKUzdnMGxXWENnSXZY?= =?utf-8?B?Z20wTFh2LzVnYjdnemJaUG10QXB1ZmoxYkwybTY1dGRVNDJJYktmY2NXWTY0?= =?utf-8?Q?DcGI0C0piDSdNGFS/FY5z++s/wuW+2S1Mf?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2486;6:fQDk2g1idMJgcCoD2NOrsWiXWkV5JwQVB0rP5Pq2dha6j6ca1u/4OicYCBoqXR87iPJirZjfYetJuEfmZs2UbJvGXj8WbxsxJIkEYLZFHM1fdLqJWP0FPjmUyBDL7Xh2q9RvypsJthBhQ+FMaTechCUyWl9yvjWOkSjhZ7xgMaH9mEIf0jTQ0H38IHm2XMJNEAdcoc1AiF7dr7qs1u1+betJpbM1tJSVDz8HrzatjZFEaXQQe5DM96q2CY26jkxSKQJTVfXwwBscrkYCgcWFsjmXSt1sKUjqQw81Ls5+pr9J3jaRAyHfoqZWeuy0BR2uXMhTgxxzk0RWJxnGtsPvdg==;5:h0i7id/oNBOsyZOJ5Dy7931483+dmYum4PnK5fVMNg37kEjtKOozAVS5BN7PyowpXqsmdVTf9t5bvXKmovWEa03iBg53DgTByHoa6E9dxIiH39j1iFkQpE4Xd2pVbLboKC3auYCoN3dF56AlZEIXmg==;24:ToPsiXTuHi6A2lKGBqmra1rP3hE7Q4423EjKG8qdew2nPCxDAIqYYIXbL9VeIVJrqg9yPxSNJCExcWtr8p46DVr92Idtb0nhRnL5KGVdviA=;7:SOVzs9q47mtlVL9EWJ+hmP6iQevYlaq+KmXfM9po1bGy9ZQ5NGvJq3Bzvw4ieTVzlUuo4AmzTbzX83c3qHixSbZWH8n/mGyAPBm5Rip1125eN2/JheVVzImTYzIa8nT2oJr+8MRFG8ieGQnbHCNIU3OV321jCgVoC2YDBQeHeG439ag/795ndL/fka952LLH9YoPdeS7Y54ktlXwXw4qOiumSwmcyWTocVpk51HdfMo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 14:38:03.6675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2486 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00062.txt.bz2 On 29/09/17 21:29, Steve Ellcey wrote: > On Thu, 2017-09-28 at 12:31 +0100, Szabolcs Nagy wrote: >> >> i think this should be improved, see below. > > Those were all good suggestions, here is a new patch that incorporates > the changes. I fixed the IFUNC_OPTIONS argument, > renamed ARCH_AARCH64_LINUX_LSE, got rid of the auxv references, and > changed HWCAP_TYPE to IFUNC_RESOLVER_ARGS. > > Here is the new patch, tested with no regressions. > looks good to me, but i cannot approve. (this will make libatomic depend on ifuncs on aarch64*-linux-gnu.) > Steve Ellcey > sellcey@cavium.com > > > 2017-09-29 Steve Ellcey > > * Makefile.am (ARCH_AARCH64_LINUX): Add IFUNC_OPTIONS and > libatomic_la_LIBADD. > * config/linux/aarch64/host-config.h: New file. > * configure.ac (IFUNC_RESOLVER_ARGS): Define. > (ARCH_AARCH64_LINUX): New conditional for IFUNC builds. > * configure.tgt (aarch64): Set ARCH and try_ifunc. > (aarch64*-*-linux*) Update config_path. > (aarch64*-*-linux*) Set IFUNC_RESOLVER_ARGS. > * libatomic_i.h (GEN_SELECTOR): Add IFUNC_RESOLVER_ARGS argument. > * Makefile.in: Regenerate. > * auto-config.h.in: Regenerate. > * configure: Regenerate. >