From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112910 invoked by alias); 26 Oct 2017 09:01:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112867 invoked by uid 89); 26 Oct 2017 09:01:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=4.1 required=5.0 tests=BAYES_00,HTML_MESSAGE,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=marcus, H*c:alternative X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Oct 2017 09:01:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 314FC15AD; Thu, 26 Oct 2017 02:01:43 -0700 (PDT) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EAB613F25D; Thu, 26 Oct 2017 02:01:41 -0700 (PDT) Message-ID: <59F1A474.6030006@foss.arm.com> Date: Thu, 26 Oct 2017 09:05:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Tamar Christina , Christophe Lyon CC: "gcc-patches@gcc.gnu.org" , nd , James Greenhalgh , Richard Earnshaw , Marcus Shawcroft Subject: Re: [PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)] References: <20170901132425.GA32479@arm.com> , In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg01901.txt.bz2 Hi Tamar, On 06/10/17 13:45, Tamar Christina wrote: > Hi All, > > this is a minor respin of the patch with the comments addressed. Note > this patch is now 7/8 in the series. > > > Regtested on arm-none-eabi, armeb-none-eabi, > aarch64-none-elf and aarch64_be-none-elf with no issues found. > > Ok for trunk? > > gcc/testsuite > 2017-10-06 Tamar Christina > > * lib/target-supports.exp > (check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache): New. > (check_effective_target_arm_v8_2a_dotprod_neon_ok): New. > (add_options_for_arm_v8_2a_dotprod_neon): New. > (check_effective_target_arm_v8_2a_dotprod_neon_hw): New. > (check_effective_target_vect_sdot_qi): New. > (check_effective_target_vect_udot_qi): New. > * gcc.target/arm/simd/vdot-exec.c: New. > * gcc.target/aarch64/advsimd-intrinsics/vdot-exec.c: New. > * gcc/doc/sourcebuild.texi: Document arm_v8_2a_dotprod_neon. > ________________________________________ > From: Tamar Christina > Sent: Monday, September 4, 2017 2:01:40 PM > To: Christophe Lyon > Cc: gcc-patches@gcc.gnu.org; nd; James Greenhalgh; Richard Earnshaw; > Marcus Shawcroft > Subject: RE: [PATCH][GCC][ARM][AArch64] Testsuite framework changes > and execution tests [Patch (8/8)] > > Hi Christophe, > > > > > > > gcc/testsuite > > > 2017-09-01 Tamar Christina > > > > > > * lib/target-supports.exp > > > (check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache): > > New. > > > (check_effective_target_arm_v8_2a_dotprod_neon_ok): New. > > > (add_options_for_arm_v8_2a_dotprod_neon): New. > > > (check_effective_target_arm_v8_2a_dotprod_neon_hw): New. > > > (check_effective_target_vect_sdot_qi): New. > > > (check_effective_target_vect_udot_qi): New. > > > * gcc.target/arm/simd/vdot-exec.c: New. > > > > Aren't you defining twice P() and ARR() in vdot-exec.c ? > > I'd expect a preprocessor error, did I read too quickly? > > > > Yes they are defined twice but they're not redefined, all the definitions > are exactly the same so the pre-processor doesn't care. I can leave only > one if this is confusing. > > > > > Thanks, > > > > Christophe > > > > > * gcc.target/aarch64/advsimd-intrinsics/vdot-exec.c: New. > > > * gcc/doc/sourcebuild.texi: Document arm_v8_2a_dotprod_neon. > > > > > > -- This looks ok to me. Thanks, Kyrill