From: Sandra Loosemore <sandra@codesourcery.com>
To: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "Francois.Bedard@synopsys.com" <Francois.Bedard@synopsys.com>,
"andrew.burgess@embecosm.com" <andrew.burgess@embecosm.com>
Subject: Re: [PATCH 5/6] [ARC] Add 'uncached' attribute.
Date: Fri, 03 Nov 2017 18:55:00 -0000 [thread overview]
Message-ID: <59FCBBAE.9040500@codesourcery.com> (raw)
In-Reply-To: <098ECE41A0A6114BB2A07F1EC238DE89667B673E@de02wembxa.internal.synopsys.com>
On 11/03/2017 05:22 AM, Claudiu Zissulescu wrote:
>>
>> I see no documentation here.
>>
>
> Ups, forgot this one :) Please find it attached. I'll merge it into the final patch when everything is approved.
>
> Thanks,
> Claudiu
>
> +@node ARC Type Attributes
> +@subsection ARC Type Attributes
> +
> +@cindex @code{uncached} type attribute, ARC
> +Declaring variables @code{uncached} allows you to exclude data-cache
Since this is a type attribute and not a variable attribute (I presume
to allow accessing objects through a pointer), it would be better to say
Declaring objects with the @code{uncached} type attribute allows....
> +participation in load and store operations on those variables without
And s/variables/objects/ here too.
> +involving the additional semantic implications of volatile. The
You probably want @code{volatile} markup here?
> +@code{.di} instruction suffix is used for all loads and stores of data
> +declared @code{uncached}.
> +
Otherwise, the description makes sense to me. (In fact, I might
eventually want to copy this attribute over to the Nios II backend, too,
since it also has similar "io"-variant load/store instructions.)
-Sandra
next prev parent reply other threads:[~2017-11-03 18:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 12:34 [PATCH 0/6] [ARC] New baremetal features and fixes Claudiu Zissulescu
2017-11-02 12:34 ` [PATCH 5/6] [ARC] Add 'uncached' attribute Claudiu Zissulescu
2017-11-03 2:26 ` Sandra Loosemore
2017-11-03 11:24 ` Claudiu Zissulescu
2017-11-03 18:55 ` Sandra Loosemore [this message]
2017-11-09 9:13 ` Claudiu Zissulescu
2018-01-29 20:23 ` Andrew Burgess
2017-11-02 12:34 ` [PATCH 2/6] [ARC] Add SJLI support Claudiu Zissulescu
2018-01-16 10:37 ` Andrew Burgess
2017-11-02 12:34 ` [PATCH 3/6] [ARC] Add support for "register file 16" reduced register set Claudiu Zissulescu
2018-01-16 10:52 ` Andrew Burgess
2017-11-02 12:34 ` [PATCH 4/6] [ARC] Rework delegitimate_address hook Claudiu Zissulescu
2018-01-23 23:07 ` Andrew Burgess
2017-11-02 12:34 ` [PATCH 1/6] [ARC] Add JLI support Claudiu Zissulescu
2018-01-16 10:20 ` Andrew Burgess
2017-11-02 12:34 ` [PATCH 6/6] [ARC] Add 'aux' variable attribute Claudiu Zissulescu
2018-01-29 20:28 ` Andrew Burgess
2018-02-01 10:10 ` [PATCH 0/6] [ARC] New baremetal features and fixes Claudiu Zissulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59FCBBAE.9040500@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=andrew.burgess@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).