From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4FEDA3858D35 for ; Fri, 1 Mar 2024 21:31:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FEDA3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FEDA3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709328680; cv=none; b=bb/8MsmCzY+BbT5aCBuk3R+bldXe7f9PMSI6CPq9hI5BfXaeNzo7vb/kKtgz1KRm42lyy0+Yri59YwbJw421JZlOsGYJEnHq0456A1Iv/R4MTAK4mU1XUji8Ph9IgdSkLYAK+MtluUSAeSL3+TW21SzV0LXHlShHu80jGZC+ntI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709328680; c=relaxed/simple; bh=nyMv4+VeXJ+Sn7JFmsb2uKxoVFhQaRWvqiZvYzKzF6o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HDYbGDzep+3uAxhQDXmfnvn2fndFNCYQAU1NjrrvkIx9AkVTilvZeWA5rN2cx4md5vpZ5rIW2ZU1xhTWN9XupgSukP5QbCU4rgLFzz99/55FfSNqUgqp9w8sYi2Alozg4lQrgoWWHfL1pXBMuTadk/PP1ppVr0hkQLoHSbsReJw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709328678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/Nnrgr5W9vQHm9xnyGjcM53sYdEULWOaB429OEOIAI=; b=BVv47ovDFrHItH8Xf8ToYd/AyvNGTHA+LKGjxyzx0YqaY1r3WEZa4vioYp/KDPl/w7ZF1y gcYbCsbwqpGQjNsOoltuFsDUA/vXOc4uLioGl7dHi4rOJmYux+jgzMpDEY2I+LxVsAF1A/ GDBdkuYG7XNyBl8EWrRXOe+xa13Tf2k= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-el0CwqVHPTmajIp0Kz961Q-1; Fri, 01 Mar 2024 16:31:14 -0500 X-MC-Unique: el0CwqVHPTmajIp0Kz961Q-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-42ed65fb0ddso4086951cf.0 for ; Fri, 01 Mar 2024 13:31:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709328674; x=1709933474; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8/Nnrgr5W9vQHm9xnyGjcM53sYdEULWOaB429OEOIAI=; b=hOsRbK4bmHYNAAYeSpzzE5UItuJrrEgFEneIiL7bS1WN0efcKVBNzW+2ShfqMvoDvl c6cx7LoRwSwsqRmPnhJ56ruvKjn1IrM9rP8cgdzUq8m6BooeegKINxCESMEty2xJhUqF tgp+BxCQMK7CagZcz9CEi+VXKG98KhPdBxfg/DEnv3op8ozzQQff/P8/9NyLhH1XyYt9 AT+vQspcqKXK1x9UFoZbgakGvGqTcA10NUfyDagvkJ2Jh9a77VLnXbZ2Ato+UoocrI3P DcBfBFZLmkL4mbtVCDbeHGl2FBwuEoC6RbdsF2A12S7204xjxV/BuJ0RsHjMzb09vXXU rFvQ== X-Forwarded-Encrypted: i=1; AJvYcCXtWCRaVV/Mjgk00GPIIqXOIdX6+4Jp//P2GC4YWQ5bSAvSXr9Wrx/mVgi2G4lRRMmmGYrXIKKJLKoV0sWVB/CfAEWajdOowQ== X-Gm-Message-State: AOJu0YxCqtbM5auxgTHt2TFqFU5kidscnbk9X/PQDyPbNo2RCorP4oJG OBVTt4JbGCjgnCPup9GhfR+OZZTgXkwXWQF1ldjD3tTFlydom3dC+uVqNh972tk6csaKJBtL8wA 8WMASam6KCD9iqU1Xmnbdpdh7wxdhyasBfdkbCDdTI8VWqVZFqFAbBOE= X-Received: by 2002:ac8:5d4b:0:b0:42e:74bb:6918 with SMTP id g11-20020ac85d4b000000b0042e74bb6918mr3148496qtx.1.1709328673934; Fri, 01 Mar 2024 13:31:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEU4AiIwukG01vEWXvJQVw1ej7tgkX19NorKeXX/pmxWtyFBF5AbFbyiKwfs2oDYYf0MSAMAA== X-Received: by 2002:ac8:5d4b:0:b0:42e:74bb:6918 with SMTP id g11-20020ac85d4b000000b0042e74bb6918mr3148483qtx.1.1709328673683; Fri, 01 Mar 2024 13:31:13 -0800 (PST) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id l15-20020ac8458f000000b0042e124c7b17sm2038307qtn.60.2024.03.01.13.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 13:31:12 -0800 (PST) Message-ID: <59b38909-e3c4-4bab-8187-fd787720aa62@redhat.com> Date: Fri, 1 Mar 2024 16:31:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] c++: implement [[gnu::non_owning]] [PR110358] To: Patrick Palka Cc: Marek Polacek , GCC Patches References: <20240126013736.70125-1-polacek@redhat.com> <0e4c47b6-604c-4d30-b458-825959c0e1d6@redhat.com> <584f955c-14eb-40b2-9365-a02279c3a763@redhat.com> <370b3ed4-c671-91c5-653f-ea11d231db0c@idea> From: Jason Merrill In-Reply-To: <370b3ed4-c671-91c5-653f-ea11d231db0c@idea> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/1/24 16:23, Patrick Palka wrote: > > Sorry for not asking this sooner, but does it matter whether we attach > the attribute to the function type rather than the function declaration? > I noticed e.g. nodiscard gets attached to the decl. > > And we document it as a function attribute despite attaching it to the > function type. I think it doesn't matter much, some attributes are represented on the type and some on the decl. Might be a bit better on the decl but I wasn't worrying about it. Jason